From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Sachin Sant <sachinp@linux.ibm.com>
Subject: Re: [PATCH] tracing: Have trace_marker writes be just half of TRACE_SEQ_SIZE
Date: Mon, 4 Mar 2024 20:15:57 -0500 [thread overview]
Message-ID: <469d31a7-f358-4547-bb17-0979b3515924@efficios.com> (raw)
In-Reply-To: <20240304192710.4c99677c@gandalf.local.home>
On 2024-03-04 19:27, Steven Rostedt wrote:
> From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
>
> Since the size of trace_seq's buffer is the max an event can output, have
> the trace_marker be half of the entire TRACE_SEQ_SIZE, which is 4K. That
> will keep writes that has meta data written from being dropped (but
> reported), because the total output of the print event is greater than
> what the trace_seq can hold.
Defining the trace_mark limit in terms of "TRACE_SEQ_SIZE / 2"
seems backwards. It's basically using a define of the maximum
buffer size for the pretty-printing output and defining the maximum
input size of a system call to half of that.
I'd rather see, in a header file shared between tracing mark
write implementation and output implementation:
#define TRACING_MARK_MAX_SIZE 4096
and then a static validation that this input fits within your
pretty printing output in the output implementation file:
BUILD_BUG_ON(TRACING_MARK_MAX_SIZE + sizeof(meta data stuff...) > TRACE_SEQ_SIZE);
This way we clearly document that the tracing mark write
input limit is 4kB, rather than something derived from
the size of an output buffer.
Thanks,
Mathieu
>
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> ---
> kernel/trace/trace.c | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 8198bfc54b58..d68544aef65f 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -7320,6 +7320,17 @@ tracing_mark_write(struct file *filp, const char __user *ubuf,
> if ((ssize_t)cnt < 0)
> return -EINVAL;
>
> + /*
> + * TRACE_SEQ_SIZE is the total size of trace_seq buffer used
> + * for output. As the print event outputs more than just
> + * the string written, keep it smaller than the trace_seq
> + * as it could drop the event if the extra data makes it bigger
> + * than what the trace_seq can hold. Half he TRACE_SEQ_SIZE
> + * is more than enough.
> + */
> + if (cnt > TRACE_SEQ_SIZE / 2)
> + cnt = TRACE_SEQ_SIZE / 2;
> +
> meta_size = sizeof(*entry) + 2; /* add '\0' and possible '\n' */
> again:
> size = cnt + meta_size;
> @@ -7328,11 +7339,6 @@ tracing_mark_write(struct file *filp, const char __user *ubuf,
> if (cnt < FAULTED_SIZE)
> size += FAULTED_SIZE - cnt;
>
> - if (size > TRACE_SEQ_BUFFER_SIZE) {
> - cnt -= size - TRACE_SEQ_BUFFER_SIZE;
> - goto again;
> - }
> -
> buffer = tr->array_buffer.buffer;
> event = __trace_buffer_lock_reserve(buffer, TRACE_PRINT, size,
> tracing_gen_ctx());
--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com
next prev parent reply other threads:[~2024-03-05 1:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 0:27 Steven Rostedt
2024-03-05 0:43 ` Randy Dunlap
2024-03-05 0:49 ` Steven Rostedt
2024-03-05 1:15 ` Mathieu Desnoyers [this message]
2024-03-05 1:35 ` Steven Rostedt
2024-03-05 1:36 ` Mathieu Desnoyers
2024-03-05 1:57 ` Steven Rostedt
2024-03-05 1:41 ` Steven Rostedt
2024-03-05 1:42 ` Mathieu Desnoyers
2024-03-05 1:59 ` Steven Rostedt
2024-03-05 2:18 ` Mathieu Desnoyers
2024-03-05 2:35 ` Steven Rostedt
2024-03-05 2:37 ` Steven Rostedt
2024-03-05 2:48 ` Mathieu Desnoyers
2024-03-05 3:07 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469d31a7-f358-4547-bb17-0979b3515924@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sachinp@linux.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®