From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B9DB221290 for ; Mon, 5 Jan 2026 05:36:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767591375; cv=none; b=gVTH7TNWVIRVTrMXtcE+WG2GhXUd/MDENQfdnm+P9AezlHvTnwZQnj1IU+2KT5E9hqEZEJTQUoPWnlfVkzXFSs1vvjfwPZPcvHtAmkqh9M3Ee5wezpzGExaMeeTOlWII2U0GW+PnBEVOqDJ0IG2MsHt9m5N7Tbro+1U70MuUi+c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767591375; c=relaxed/simple; bh=OjXIARhA04v7QTbluibCg1Ua4ca6hpySNteOveDpVyc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Uuh34uu3lEBiMwRFu92xpQowLH2/+m96Wr7zMd/NVvBTl2Jua0SmH4c+n3vBowxai/kuXSMEJ4RA0hNrLa/K1bCaFiP2xKbW6uW26L4SJUEij3lCbX631P6+S5e1oCP1dGPDGktOB5EQ34V2W3ATctjgXZWn0+odceIarQluFCw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=h8B9+KCR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eFRr73xH; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="h8B9+KCR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eFRr73xH" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 604NHBf63895225 for ; Mon, 5 Jan 2026 05:36:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Vc/nABE+NCB330MJT+THBXID+Q7Gd2jX5QLHj0sow+U=; b=h8B9+KCR3b2nJtqe uCsudu9VZsmAv8GM1n65LesAvtE+xNm/6yEokBczvQjpVfXqHaYBqtyc/edfNw6s TPpy1TuLioanda358Vz+F5eU2Ucux7YvehhOgqM2t1dFS2Qny4w2lUxZY7XKn6Fo U/8Wc8fd4kYxs6OIKJgOyOieL1LDpqoD4lLUNlnF5TVORHr98B2urTpjO/47yy87 Cp3OINwjQjytqDnHqZDOjR2N4R6AXswi7HpcmN+5TKWCaOeHLrxEvYTmSbsdDQo9 SqM9DDohiEJUhA+DxJqzlDsd86V1SaFox/lu/xIFxtQ4jbv2CZ/2KBrExVoIs6PW 5Wa5NQ== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4beuvd39gd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 05 Jan 2026 05:36:13 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-7b6b194cf71so26375108b3a.3 for ; Sun, 04 Jan 2026 21:36:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767591373; x=1768196173; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Vc/nABE+NCB330MJT+THBXID+Q7Gd2jX5QLHj0sow+U=; b=eFRr73xHkgG+CbLakTwKdbB7u2vIjiN80jLJjTetUW+kw2QGukHXc5XypSO9ssi6uo LEFtBxJwomzgiLu8Jo+ZeQd/oNt6hdxQrnxPcHBLO7wURyNoGyNeOdb3xSLM+Sx+Rowb x7wyPzHMqJ6jwFVZ65iP97mwHBn/J3p+xivV2mHx9NbWJ7IIrbcxwgFkT+5Ol2MLWSXR MJ2MmtLh4FlerE9BBjMtpTMJ4tZt4Q25PMQhDJ4FCoy7gDq/hT1M6fh/1ndk+a2O6mMi DrzMHyxAr0D9Ma8sx1FycgEzTM5ieK4oS5MClD2XL+lld5HZwoEit9CokHtWBnGg1X/J JcXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767591373; x=1768196173; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Vc/nABE+NCB330MJT+THBXID+Q7Gd2jX5QLHj0sow+U=; b=k86ZndbdsudscRLzqDxjZT5f1sBJb9N3u9RxsoOYU70U0voY1DSQSrUg+bgWoF4osX bWjMUmEPzJ3OgQXqEOEInT0Pq3vhOzMUXDjKahKvonyDP1+LUh+kP7eNQCUAYYQGLrZJ hy8nJJAV28NdSFz2bG8SjFaQXYHuz1ew0/5kevCMKTyLYQHLWLjqTxAq3YWmsHFp/duh jWvmjk1Tofvq2YNvrNy0zqzBHbtFCWdKTGzEjCiUO108vKnmUU/M6iuhfi2iLlifRfzc Lls95BLGBrRTcnkwFbHpZi3fhquPeK7xU7up4pHq4ALfWgtdYLFlX1ObbIVzuSJ0BY6C sTbw== X-Forwarded-Encrypted: i=1; AJvYcCXVRfZSvp97dMAHiQFjU8OrCKPPsc2Wj3BcP2jJtNfFM5QloA1QMTshLrEowSht1V4ABgXj0EoI/a2560s=@vger.kernel.org X-Gm-Message-State: AOJu0YzwIdD0swijVlATEKoT35NI93O/I5gepS3gpmU/FKXrtcz5h40w eU3w91TNDTq5MPcSl5TgQQ3WttR8s/8f/XhOLsH/FETY3hLO2BUZLhF1IRIqQwiEaIwm0B8yyF1 9ULv28kQ4TJTFXJIp8EyXiMHWn1tWiBnLWVCNQJRdYJaPP5lu8RgMUyRYRTEPOGmfCZQ= X-Gm-Gg: AY/fxX4WnsNQq0JWhWFeey0Wafh/TmY5nxcA4n3fSkj6VnP4tGc8sMUC3+2qIgv/i6H QSzBGXNrzn8KihvSWL97hrlUHp8CBjBUl2Oz4nF1Z0J0uDdCAz1iibXkXn2iVT0zzaY9S+py+cM 0e3uYhHEl8qmUriYpUmFSiYmQauo+G696IOOkJFAoTlGfRdS1kKSVE9JV4ENt+T3rwRBlnWM4Qs JiLpKeBWr3JWorVg1vYZ9lNwHBXd2DlWTX00ly432p5q4+1kh/+AAiGrwpS5Ftst2xx03j6aiFH VHiV/sslsLqgdsWjn2cxyeS6i8mjUhsSubSSE/52/NgY5xB/yLz00Nvcn3QP4wUkLXhCsoFagLH EhyuZcnvF30b3v3B2KjmoYr4IqVX1WMBELmSI7KPOwPtzs3ACgYE9fcHoGo53IQCcjKm7/3hmnv 54RXDv1g== X-Received: by 2002:a05:6a20:1016:b0:37e:43b7:5213 with SMTP id adf61e73a8af0-37e43b75332mr17253764637.79.1767591372890; Sun, 04 Jan 2026 21:36:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IHGHuMnlwnPCZ9NdxMzI/8mrigOk1wrLWItrvzXS/LeXU/Fo+Z5aoRx9bFGKuKk3e4kuTm7zw== X-Received: by 2002:a05:6a20:1016:b0:37e:43b7:5213 with SMTP id adf61e73a8af0-37e43b75332mr17253748637.79.1767591372393; Sun, 04 Jan 2026 21:36:12 -0800 (PST) Received: from [10.133.33.108] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3d776c1sm435005785ad.102.2026.01.04.21.36.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Jan 2026 21:36:12 -0800 (PST) Message-ID: <469d89c9-8f6c-4abe-9d9f-b6a47f8cefd8@oss.qualcomm.com> Date: Mon, 5 Jan 2026 13:36:08 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] arm64: dts: qcom: Commonize IQ-X-IOT DTSI To: Krzysztof Kozlowski , Dmitry Baryshkov Cc: Yijie Yang , andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20251222-purwa-v1-0-14ab9316e5ff@oss.qualcomm.com> <20251222060335.3485729-3-yijie.yang@oss.qualcomm.com> <20251222-fluorescent-turkey-of-gallantry-df0906@quoll> <6421f044-2b07-4518-9edc-b9b2ef49f4fb@kernel.org> <8bcf058f-5bf9-46ce-a188-e94954101f2f@oss.qualcomm.com> <4f79d090-7d1c-4fb3-a835-a7e4ff96f79c@oss.qualcomm.com> <448f2efa-5b1e-4855-a62d-2e375938b36f@kernel.org> <36cb7d6e-ece4-42c7-bc11-b66837df5fc4@kernel.org> Content-Language: en-US From: Tingwei Zhang In-Reply-To: <36cb7d6e-ece4-42c7-bc11-b66837df5fc4@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: CRed3bOkEyRp5d2Gec1D6aUBYtEc8c0T X-Proofpoint-GUID: CRed3bOkEyRp5d2Gec1D6aUBYtEc8c0T X-Authority-Analysis: v=2.4 cv=OuhCCi/t c=1 sm=1 tr=0 ts=695b4dcd cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=WYiU0xuuXi8eZROXrnMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA1MDA0OSBTYWx0ZWRfXwEQx4h2zScXH oJg0/FLdtG1NfjhdS/GZ094BVSqwn8P7nZkMSpZAp6wZAlFMdStkTCkhPmL9ISU0Y7N7w7WE6tp eHbBw36Cf5in7UfnoSOtDPBsvHbdS8dPCeG+hBOqMvis0PwUmCwzGoAkczJ2+ggyD9+U9x2ON+p 0Es6XWEOP86NxrXntbja96ZUmLpT/odboJ8RpdUb4+U4bmnC/pSBkcy/TMSs2c0dsK5OJ2LoSGE uC75lJM2ppaQjxAKyxwWhvnEwXKrMfXnTtyX2D0L9NP1s3FU48vz5KZOCNKSyzFyAjfJYJXEAz8 WExYLyXwatHtEUHJukLA2fvm15GR8W6SikuGk3d37wa2oapsoP7ASG4ULkQ2qV1mwjv+Ufr91s0 Vs3gGN7cmBDHlgtdDVXrsglucatsjP1DBhST03NP/YUyrgQ8vhayPIsHwgSEtpMOEQt5dQeUZaq xju1740HbwLHWKFW6EQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-05_01,2025-12-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 impostorscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 suspectscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601050049 On 12/30/2025 3:21 PM, Krzysztof Kozlowski wrote: > On 29/12/2025 21:08, Dmitry Baryshkov wrote: >> On Mon, Dec 29, 2025 at 09:47:05AM +0100, Krzysztof Kozlowski wrote: >>> On 29/12/2025 08:38, Yijie Yang wrote: >>>> >>>> On 12/29/2025 3:21 PM, Krzysztof Kozlowski wrote: >>>>> On 29/12/2025 02:23, Tingwei Zhang wrote: >>>>>> >>>>>> On 12/24/2025 8:12 AM, Tingwei Zhang wrote: >>>>>>> On 12/23/2025 9:41 PM, Krzysztof Kozlowski wrote: >>>>>>>> On 23/12/2025 04:38, Tingwei Zhang wrote: >>>>>>>>> On 12/22/2025 5:11 PM, Krzysztof Kozlowski wrote: >>>>>>>>>> On Mon, Dec 22, 2025 at 02:03:28PM +0800, YijieYang wrote: >>>>>>>>>>> From: Yijie Yang >>>>>>>>>>> >>>>>>>>>>> HAMOA-IOT-EVK and PURWA-IOT-EVK share a similar board design. Extract >>>>>>>>>>> the common components into separate files for better maintainability. >>>>>>>>>> SoMs do not share actual hardware. DTSI does not represent what looks >>>>>>>>>> similar to you, but actually common parts. >>>>>>>>> Purwa SOM board and Hamoa SOM board share same design. They share same PCB. >>>>>>>>> The difference is only on chip. Purwa SOM board has Purwa and Hamoa SOM board >>>>>>>>> has Hamoa on it. >>>>>>>> I do not speak about boards. Read carefully feedback and respond to the >>>>>>>> actual feedback, not some other arguments. >>>>>>>> >>>>>>>> NAK >>>>>>> In this change, the SoM hardware except SoC is described by iq-x-iot-som.dtsi since it's common between Hamoa and Purwa. Hamoa and Purwa SoC hardware is described in hamoa.dtsi and purwa.dtsi. Hamoa-iot-som.dtsi includes iq-x-iot-som.dtsi and hamoa.dtsi. This change could reduce the duplicate code and review effort on a totally new purwa-iot-som.dtsi. If we found any bug, it can be fixed in one common file instead of two separate files. Same idea is used in x1-crd.dtsi. X1e80100-crd.dts include x1-crd.dtsi and hamoa.dtsi. >>>>>> Krzysztof, >>>>>> Please let me know your opinion on this. This could be a common case for >>>>>> Hamoa/Purwa boards share same PCB. Share same dtsi file like x1-crd.dtsi >>>>> It's not the same PCB. You did not really respond to my first message, >>>>> so I responded to you - I do not speak about boards. Then again you did >>>>> not respond to it and brought some irrelevant arguments. >>>>> >>>>>> would reduce maintenance effort. >>>>> Does not matter, I do not question this. Why are you responding to some >>>>> questions which were never asked? >>>>> >>>>> DTSI represents actual shared physical aspect and you cannot share SoM >>>>> physically. It's not the same PCB, because you do not have a socket on >>>>> the SoM. >>>> x1e80100-crd and x1p42100-crd are different boards, yet they share the >>>> same x1-crd.dtsi. Why can’t we apply the same approach here? >>> >>> You should ask the authors there, not me. I presume that the baseboard >>> is the same or very similar. Or pieces of the baseboard are re-used >>> which could be visible in the schematics (same MCN numbers etc). >> For me this sounds like a new rule, which didn't exist beforehand. We >> have enough foo-common.dtsi fragments, covering similar phones, but we >> never required the knowledge of those phones having the same PCB. > I am speaking about it since 2020? 2021? So how new? Other people in > other SoCs were sometimes speaking about it in 2016 or something There’s no doubt that using a common DTSI makes sense when the boards share the same baseboard. I think the real question is whether the baseboards are defined so similarly that they can be treated as the same. For example, would swapping to a different SoC—similar to the Hamoa/Purwa CRD scenario—still be acceptable? Would exchanging components such as the display panel, a single camera lens (not the sensor, as far as I can tell), or removing the 3D iToF module[1] still qualify as the “same” board? In other words, can we consider two boards identical if the underlying circuit board is the same but a few parts are swapped out? [1]https://lore.kernel.org/all/20221114095654.34561-3-konrad.dybcio@linaro.org/ > Best regards, > Krzysztof