From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fllvem-ot04.ext.ti.com (fllvem-ot04.ext.ti.com [198.47.19.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77929211A27; Mon, 3 Feb 2025 23:07:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.19.246 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738624027; cv=none; b=V6QbNspKMGkMKrmwhv/y+zL8DXOozsJgJ/BkOpcwBIuIfNAdAB66djfMlRjXbv4r3Z//S4aie8jsoLY6uqxC833txmK72qJNpCmZEFtcpki8CSXseUzDEZVIzFuA3REMeKa3i/4p29oo+CJor7GifkqRIp92acztMxpgsNXHjpE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738624027; c=relaxed/simple; bh=QOkURqoudhap7sMwmWyDRFppy+OU7xBqYJPCSMM5a2w=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=OuRuMVRIzwEPyiKj/GeUV3GRQN03NgyQWSAJ+WIkCp3KPfyT/nv9VbWZF6B/zR2rwmcN27yqZZVaHURF6XCpGfllRkIuDD2tzknVCjGhdVidgZ1C4s692imEIT49BnEidQd+i/oyN0NZZ8vNJLTU8Gmh7EQK21PRQp6g6da4PVc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=J4+LWMbz; arc=none smtp.client-ip=198.47.19.246 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="J4+LWMbz" Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllvem-ot04.ext.ti.com (8.15.2/8.15.2) with ESMTPS id 513N6pUY2225606 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 3 Feb 2025 17:06:52 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1738624012; bh=am/bBarvIeEoB5opdd4q8vGhdTQUm42S7bkaACiTuoA=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=J4+LWMbzbzlmvqlxzlBATR6IMUM3oiu4dKA8Mxiy9wtwCL0AXpkyG2KxG7XWgZseV M+ehRmqIqc3zlgiAjebSSjJCskoz7N3lsEv60hk7mMtFBzWv9aBefTiwuhO08hU4LW qVOLbAoO91IajFLNVKu6JhWegVj0jyVhj1p8UWhA= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 513N6pha106199 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 3 Feb 2025 17:06:51 -0600 Received: from DFLE103.ent.ti.com (10.64.6.24) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 3 Feb 2025 17:06:51 -0600 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 3 Feb 2025 17:06:51 -0600 Received: from [128.247.81.105] (judy-hp.dhcp.ti.com [128.247.81.105]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 513N6pSl025658; Mon, 3 Feb 2025 17:06:51 -0600 Message-ID: <469ee404-fe33-471e-8652-e9206f7f433b@ti.com> Date: Mon, 3 Feb 2025 17:06:51 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/9] arm64: dts: ti: k3-am62a7-sk: Enable ipc with remote processors To: Andrew Davis , Nishanth Menon , Vignesh Raghavendra CC: Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , , Hari Nagalla References: <20250131214611.3288742-1-jm@ti.com> <20250131214611.3288742-6-jm@ti.com> <0ab5c5ec-cde3-41f1-8adf-2419b31497c1@ti.com> Content-Language: en-US From: Judith Mendez In-Reply-To: <0ab5c5ec-cde3-41f1-8adf-2419b31497c1@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea Hi Andrew, On 2/3/25 4:53 PM, Andrew Davis wrote: > On 1/31/25 3:46 PM, Judith Mendez wrote: >> From: Devarsh Thakkar >> >> For each remote proc, reserve memory for IPC and bind the mailbox >> assignments. Two memory regions are reserved for each remote processor. >> The first region of 1MB of memory is used for Vring shared buffers >> and the second region is used as external memory to the remote processor >> for the resource table and for tracebuffer allocations. >> >> Signed-off-by: Devarsh Thakkar >> Signed-off-by: Hari Nagalla >> Signed-off-by: Judith Mendez >> --- >> Changes since v1: >> - add patches 5-9 to enable ipc and complete device nodes >> --- >>   arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 78 +++++++++++++++++++++++++ >>   1 file changed, 78 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts >> b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts >> index a6f0d87a50d8a..6f4b037537fec 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts >> +++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts >> @@ -61,11 +61,41 @@ secure_ddr: optee@9e800000 { >>               no-map; >>           }; >> +        wkup_r5fss0_core0_dma_memory_region: r5f-dma-memory@9c800000 { >> +            compatible = "shared-dma-pool"; >> +            reg = <0x00 0x9c800000 0x00 0x100000>; >> +            no-map; >> +        }; >> + >>           wkup_r5fss0_core0_memory_region: r5f-dma-memory@9c900000 { >>               compatible = "shared-dma-pool"; >>               reg = <0x00 0x9c900000 0x00 0x01e00000>; >>               no-map; >>           }; >> + >> +        mcu_r5fss0_core0_dma_memory_region: r5f-dma-memory@9b800000 { >> +            compatible = "shared-dma-pool"; >> +            reg = <0x00 0x9b800000 0x00 0x100000>; >> +            no-map; >> +        }; >> + >> +        mcu_r5fss0_core0_memory_region: r5f-dma-memory@9b900000 { >> +            compatible = "shared-dma-pool"; >> +            reg = <0x00 0x9b900000 0x00 0x0f00000>; > > There is a leading 0 here and in a couple other places. > > s/0x0f00000/0xf00000 Ok, will check all other memory carveouts and fix. > >> +            no-map; >> +        }; >> + >> +        c7x_0_dma_memory_region: c7x-dma-memory@99800000 { >> +            compatible = "shared-dma-pool"; >> +            reg = <0x00 0x99800000 0x00 0x100000>; >> +            no-map; >> +        }; >> + >> +        c7x_0_memory_region: c7x-memory@99900000 { >> +            compatible = "shared-dma-pool"; >> +            reg = <0x00 0x99900000 0x00 0x01f00000>; > > 0x01f00000 ? What is this size, all other firmware in all other > K3 use 0xf00000 (16MB), that should be enough for any sane firmware. > If some firmware needs more it is probably doing something hacky > like leaving space for buffer passing internally. That space should > be provided from a shared dma-buf pool or similar mechanism. That is fine, will change to 16MB. (: ~ Judith > > Make this 0xf00000 and fix the firmware. > > Andrew > >> +            no-map; >> +        }; >>       }; >>       opp-table { >> @@ -737,3 +767,51 @@ dpi1_out: endpoint { >>           }; >>       }; >>   }; >> + >> +&mailbox0_cluster0 { >> +    mbox_r5_0: mbox-r5-0 { >> +        ti,mbox-rx = <0 0 0>; >> +        ti,mbox-tx = <1 0 0>; >> +    }; >> +}; >> + >> +&mailbox0_cluster1 { >> +    mbox_c7x_0: mbox-c7x-0 { >> +        ti,mbox-rx = <0 0 0>; >> +        ti,mbox-tx = <1 0 0>; >> +    }; >> +}; >> + >> +&mailbox0_cluster2 { >> +    mbox_mcu_r5_0: mbox-mcu-r5-0 { >> +        ti,mbox-rx = <0 0 0>; >> +        ti,mbox-tx = <1 0 0>; >> +    }; >> +}; >> + >> +&wkup_r5fss0 { >> +    status = "okay"; >> +}; >> + >> +&wkup_r5fss0_core0 { >> +    mboxes = <&mailbox0_cluster0>, <&mbox_r5_0>; >> +    memory-region = <&wkup_r5fss0_core0_dma_memory_region>, >> +        <&wkup_r5fss0_core0_memory_region>; >> +}; >> + >> +&mcu_r5fss0 { >> +    status = "okay"; >> +}; >> + >> +&mcu_r5fss0_core0 { >> +    mboxes = <&mailbox0_cluster2>, <&mbox_mcu_r5_0>; >> +    memory-region = <&mcu_r5fss0_core0_dma_memory_region>, >> +            <&mcu_r5fss0_core0_memory_region>; >> +}; >> + >> +&c7x_0 { >> +    mboxes = <&mailbox0_cluster1>, <&mbox_c7x_0>; >> +    memory-region = <&c7x_0_dma_memory_region>, >> +            <&c7x_0_memory_region>; >> +    status = "okay"; >> +};