From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52566C4167D for ; Mon, 30 Oct 2023 08:30:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232114AbjJ3IaB (ORCPT ); Mon, 30 Oct 2023 04:30:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbjJ3I37 (ORCPT ); Mon, 30 Oct 2023 04:29:59 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C0A3AB for ; Mon, 30 Oct 2023 01:29:57 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-509109104e2so2096307e87.3 for ; Mon, 30 Oct 2023 01:29:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698654595; x=1699259395; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=rnpIzjbYLIpmyoln4TxTiMzbHo5KIuPiksSLMxx86Kw=; b=SypD02QpGbCY8EuPcxe25cw59pDZFne7kZN9d/b8oXtPYo+Ry72i1cb2kCa1yp1p3v 7EmRCkkc4l9YrvCOaJyjRr8LDVxF95PieIBrYE5OyfHFQE6Mp7QYSeYOgzCfSXykvTHY aONuaxzQF5foAT+4a7xTjTuKu3kBBWCtmd+AOlVaUOpGg70QaFhx5BPvo8iKt82hyvjY Bry7tL7aiqYOrgmlczzOZA99eMN+PtgERkkOJHZrw+RQD8o1g3roReaJdct98EaL/I4I Adj6kRG2QMKuQ8n+9TrQqPjw1iLHnX/zsEqxZImkcbtSVmhy7vCkdbkX38+Zsl6aKeh5 I/Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698654595; x=1699259395; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=rnpIzjbYLIpmyoln4TxTiMzbHo5KIuPiksSLMxx86Kw=; b=prFUSheWWY4BHGvnFDoRTEcndkpiJ8N2N51JwRq5ihBXRaemf85qA/WG4mhhAy4sQJ 4eO2/1VdIs17Pp+/n8X62R829s4pgxJkwzllqHJPoam7sWLJ710QBbISp57GOvWqDEFQ o0DjqGhaQp6rpgG9dST8o4Wng7psJLl0whejTl3Z6tfpdSu02J7y022y5e6YdPPIbzQP jf373Ie+l6H+vjcc5ARmo6sKhwu2g7KYMA57VCdQSx+z+MZo1b6FxrZe8Q2hP7OZ76YU 8Ro/ZwRGHMe114A877dv2ADful/1VZG27SuyofQdEtqdUoaZVHixx7UKlfojdQ2Cgd1P UJFg== X-Gm-Message-State: AOJu0Yyo2XotqmBpY1o6rxsaNyTnASz+SNxTYccfSClpFkjH5RhJkv40 Cj+Uh5noNRc2SwH9ObRYm5goow== X-Google-Smtp-Source: AGHT+IEcRMWXLNodTV6mQug71yQCCf+gJGD/OjbqlrKiQem+EyurncoOmzl+I70Jm3gUJApsoX3nng== X-Received: by 2002:a19:5516:0:b0:503:2dce:4544 with SMTP id n22-20020a195516000000b005032dce4544mr6869632lfe.59.1698654595117; Mon, 30 Oct 2023 01:29:55 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:a05f:dffd:3e08:6b03? ([2a01:e0a:982:cbb0:a05f:dffd:3e08:6b03]) by smtp.gmail.com with ESMTPSA id z8-20020adfe548000000b0031c52e81490sm7729674wrm.72.2023.10.30.01.29.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Oct 2023 01:29:54 -0700 (PDT) Message-ID: <469f2249-5f7b-4136-9f65-b58c9baf537c@linaro.org> Date: Mon, 30 Oct 2023 09:29:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 1/3] dt-bindings: remoteproc: qcom,sm8550-pas: document the SM8650 PAS Content-Language: en-US, fr To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231025-topic-sm8650-upstream-remoteproc-v1-0-a8d20e4ce18c@linaro.org> <20231025-topic-sm8650-upstream-remoteproc-v1-1-a8d20e4ce18c@linaro.org> Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro Developer Services In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/10/2023 09:36, Krzysztof Kozlowski wrote: > On 25/10/2023 09:35, Neil Armstrong wrote: >> Document the DSP Peripheral Authentication Service on the SM8650 Platform. >> >> Signed-off-by: Neil Armstrong >> --- >> .../bindings/remoteproc/qcom,sm8550-pas.yaml | 41 +++++++++++++++++++++- >> 1 file changed, 40 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml >> index 58120829fb06..316371c8ee6e 100644 >> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml >> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml >> @@ -19,6 +19,9 @@ properties: >> - qcom,sm8550-adsp-pas >> - qcom,sm8550-cdsp-pas >> - qcom,sm8550-mpss-pas >> + - qcom,sm8650-adsp-pas >> + - qcom,sm8650-cdsp-pas >> + - qcom,sm8650-mpss-pas >> >> reg: >> maxItems: 1 >> @@ -49,6 +52,7 @@ properties: >> - description: Memory region for main Firmware authentication >> - description: Memory region for Devicetree Firmware authentication >> - description: DSM Memory region >> + - description: DSM Memory region 2 >> >> required: >> - compatible >> @@ -63,6 +67,7 @@ allOf: >> enum: >> - qcom,sm8550-adsp-pas >> - qcom,sm8550-cdsp-pas >> + - qcom,sm8650-adsp-pas >> then: >> properties: >> interrupts: >> @@ -71,7 +76,25 @@ allOf: >> maxItems: 5 >> memory-region: >> maxItems: 2 >> - else: >> + - if: >> + properties: >> + compatible: >> + enum: >> + - qcom,sm8650-cdsp-pas >> + then: >> + properties: >> + interrupts: >> + minItems: 5 > > maxItems > > >> + interrupt-names: >> + minItems: 5 > > maxItems > >> + memory-region: >> + minItems: 3 > > maxItems: 3 > >> + - if: >> + properties: >> + compatible: >> + enum: >> + - qcom,sm8550-mpss-pas >> + then: >> properties: >> interrupts: >> minItems: 6 >> @@ -79,12 +102,26 @@ allOf: >> minItems: 6 >> memory-region: >> minItems: 3 > > You need to add here maxItems. Ok, I fixed all that > >> + - if: >> + properties: >> + compatible: >> + enum: >> + - qcom,sm8650-mpss-pas >> + then: > > I am not sure if keeping it in the same binding as sm8550 avoids that > much duplication. Yes it does, 70% is the bindings would be the same, still if it's still preferable I can duplicate. Thanks, Neil > > Best regards, > Krzysztof >