From: Chuan Liu <chuan.liu@amlogic.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Lucas Tanure <tanure@linux.com>
Cc: xianwei.zhao@amlogic.com, Andrew Lunn <andrew+netdev@lunn.ch>,
davem@davemloft.net, Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 2/7] dt-bindings: net: add amlogic,t7-dwmac
Date: Mon, 16 Nov 2026 22:19:27 +0800 [thread overview]
Message-ID: <469f431e-de89-4d42-bc66-488ac5610162@amlogic.com> (raw)
In-Reply-To: <CAFBinCB+DkFDwXm9L+NYgtsUNR2F01xhJJnHN_8ydcRjcpNU3g@mail.gmail.com>
Hi Martin, Cc Lucas, Conor,
On 11/16/2026 1:56 AM, Martin Blumenstingl wrote:
> On Fri, Nov 13, 2026 at 1:18 PM Lucas Tanure <tanure@linux.com> wrote:
>>
>> The T7 has the same ethernet glue as the G12A but needs two clocks of
>> its own. The controller reaches memory through a pipeline stage with
>> its own gate; nothing else claims it, so it is switched off as unused
>> and transfers never finish. The glue registers share a gate with the
>> MDIO multiplexer, which probes after the controller has programmed
>> them: the writes are lost and the port keeps the bootloader's delays.
>>
>> With a newer core, a clock list of its own and delays that follow
>> ethernet-controller.yaml, the T7 gets a binding of its own: the PHY
>> adds the 2ns, and only the receive delay line offers fine tuning, so
>> only rx-internal-delay-ps is valid here.
>>
>> Signed-off-by: Lucas Tanure <tanure@linux.com>
> Looks good to me in general
>
> [...]
>> + - description:
>> + APB clock of the glue registers PRG_ETH0 and PRG_ETH1.
>> + Without it, they read as zero and ignore writes.
> Please give Chuan Liu a few days to clarify this clock input: [0]
Thanks for the reminder, I have confirmed that Lucas' understanding is
right. It is indeed necessary to rely on this clock to access PRG_ETH0
and PRG_ETH1 normally. I have replied in the patch of v5 [0].
[0]
https://lore.kernel.org/linux-amlogic/bd4c8a15-ab13-459f-8fb5-fe3f3b04af43@amlogic.com/
> It would be great if he could provide more details on it. If there's
> no reply then I suggest going with Lucas' testing finding though
> (which means that clock input is correct)
>
>
> [0] https://lore.kernel.org/linux-amlogic/CAJX_Q+0seFwDvd6zksLnJjWYJJY1QcLc1gAjr=FN1p+aTdumpw@mail.gmail.com/
--
Best regards,
Chuan
next prev parent reply other threads:[~2026-11-16 14:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 12:18 [PATCH v7 0/7] Add ethernet support for the Amlogic T7 Lucas Tanure
2026-11-13 12:18 ` [PATCH v7 1/7] dt-bindings: net: amlogic,meson-dwmac: list the compatible combinations Lucas Tanure
2026-11-15 17:40 ` Martin Blumenstingl
2026-11-13 12:18 ` [PATCH v7 2/7] dt-bindings: net: add amlogic,t7-dwmac Lucas Tanure
2026-11-13 17:14 ` Conor Dooley
2026-11-15 17:56 ` Martin Blumenstingl
2026-11-16 14:19 ` Chuan Liu [this message]
2026-11-13 12:18 ` [PATCH v7 3/7] net: stmmac: dwmac-meson8b: add support for the Amlogic T7 Lucas Tanure
2026-11-13 12:18 ` [PATCH v7 4/7] net: stmmac: dwmac-meson8b: follow the generic RGMII delay rules on the T7 Lucas Tanure
2026-11-15 17:57 ` Martin Blumenstingl
2026-11-17 16:58 ` Maxime Chevallier
2026-11-13 12:18 ` [PATCH v7 5/7] arm64: dts: amlogic: t7: add the ethernet pinctrl nodes Lucas Tanure
2026-11-15 17:58 ` Martin Blumenstingl
2026-11-13 12:18 ` [PATCH v7 6/7] arm64: dts: amlogic: t7: add the ethernet controller Lucas Tanure
2026-11-15 18:02 ` Martin Blumenstingl
2026-11-13 12:18 ` [PATCH v7 7/7] arm64: dts: amlogic: t7: khadas-vim4: enable the ethernet port Lucas Tanure
2026-11-15 18:08 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469f431e-de89-4d42-bc66-488ac5610162@amlogic.com \
--to=chuan.liu@amlogic.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=tanure@linux.com \
--cc=xianwei.zhao@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®