From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m32116.qiye.163.com (mail-m32116.qiye.163.com [220.197.32.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5252033EC for ; Sun, 28 Dec 2025 13:23:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.32.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766928228; cv=none; b=G/sZWS0+SY8z3C1rESvqDrcuKbournf5JWPHSpjLlIcMSfLV6hXiajPm02RWUydnE2qH2qY3HaCxKbayvGJwoNwQtckqhKK/m+FtI2vS0hNq2NhMrAAWSkjuNtzMzAh7OR9Jh/fEZe33EQL0sVmFPqSaYP+84G90uynbAwCLNh4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766928228; c=relaxed/simple; bh=qkfNtjWvip+B8Gw+2xhYpMKCbtM/KfbyBLOgSCm/ZOY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oC5+HE43uw3hZG4UlGjtoAoauaDUjbba8SbC15W7gDuUED6QVNS9P7iXn+PwJbdy6xbU2KJLc6zCGx7jDZqyz70+sx5bf8oK5bVVuQBgEbNSPvY3ZGteTSojaCR6Z7p0fQTEWL5m8NIn2eK8ZD/9DXbtC9XNrpLu6t1H7sIy2oE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=Z76NvJSA; arc=none smtp.client-ip=220.197.32.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="Z76NvJSA" Received: from [172.16.12.43] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 2ec8cc627; Sun, 28 Dec 2025 16:47:27 +0800 (GMT+08:00) Message-ID: <469f900d-1352-4137-94ec-4daeb5b7a998@rock-chips.com> Date: Sun, 28 Dec 2025 16:47:25 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RESEND v3] drm/bridge: analogix_dp: Reuse &link_train.training_lane[] to set DPCD DP_TRAINING_LANEx_SET To: andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.baryshkov@oss.qualcomm.com, dianders@chromium.org, m.szyprowski@samsung.com, andy.yan@rock-chips.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20251111022103.1350183-1-damon.ding@rock-chips.com> Content-Language: en-US From: Damon Ding In-Reply-To: <20251111022103.1350183-1-damon.ding@rock-chips.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Tid: 0a9b64241d3b03a3kunm82b17a0c1c0950 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZQhkdS1ZPT0kaQ08dHUNISEhWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSEpKQk xVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=Z76NvJSAgROd5gPtXcZi+ExsVLacwPFhFFrWfpqfe1rOrv5tyuttLwUNfNL66ZuNAGCK5vk9F0IZn8WPSvNHUzWtAoLPFToXB9m1mkMPZDBY2CRISWAINQB6ZJ8HGTSqIrjagaiGD7msXN2ncLEBUYLWj4cs0CkPT3ylkRS2SlU=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=LAKChGK/jlN8bmWUU/MgPZqrpCIuy+LnVeYX41YXAvk=; h=date:mime-version:subject:message-id:from; On 11/11/2025 10:21 AM, Damon Ding wrote: > In analogix_dp_link_start(), &link_train.training_lane[] is used to > set phy PE/VS configurations, and buf[] is initialized with the same > values to set DPCD DP_TRAINING_LANEx_SET. > > It makes sense to reuse &link_train.training_lane[] to set DPCD > DP_TRAINING_LANEx_SET, which can remove the redundant assignments > and make codes more concise. > > Signed-off-by: Damon Ding > Tested-by: Marek Szyprowski > Reviewed-by: Dmitry Baryshkov > > --- > > Changes in v2: > - Add Tested-by tag. > > Changes in v3: > - Add Reviewed-by tag. > - Fix the spelling error 'consice' to 'concise'. Gentle ping. I just added tags in v2 and v3, and I also tried resend. The patch is merely a pre-optimization work for the following patch series: https://lore.kernel.org/all/20251217093321.3108939-1-damon.ding@rock-chips.com/ > --- > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > index 6ec3d811b5f0..1e834d3656c1 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > @@ -281,12 +281,8 @@ static int analogix_dp_link_start(struct analogix_dp_device *dp) > if (retval < 0) > return retval; > > - for (lane = 0; lane < lane_count; lane++) > - buf[lane] = DP_TRAIN_PRE_EMPH_LEVEL_0 | > - DP_TRAIN_VOLTAGE_SWING_LEVEL_0; > - > - retval = drm_dp_dpcd_write(&dp->aux, DP_TRAINING_LANE0_SET, buf, > - lane_count); > + retval = drm_dp_dpcd_write(&dp->aux, DP_TRAINING_LANE0_SET, > + dp->link_train.training_lane, lane_count); > if (retval < 0) > return retval; >