From: Dan Carpenter <dan.carpenter@linaro.org>
To: Gary Rookard <garyrookard@fastmail.org>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8192u: ieee80211: renamed duplicate variable
Date: Thu, 28 Sep 2023 07:58:27 +0300 [thread overview]
Message-ID: <469feda7-80db-4f22-8396-1eb10d07567b@kadam.mountain> (raw)
In-Reply-To: <20230928033220.31783-1-garyrookard@fastmail.org>
On Wed, Sep 27, 2023 at 11:32:20PM -0400, Gary Rookard wrote:
> This patch renames a duplicate variable found in both rtl8192e and
> rtl8192u causing the preprocesser/compiler to compile without error
> when in fact it should throw an error/break the build.
>
> Prototype in files:
> rtl8192e/rtllib.h remaining as ht_update_default_setting
> rtl8192u/ieee80211/ieee80211.h changed to __ht_update_default_setting
>
> Function in files:
> rtl8192e/rtl819x_HTProc.c remaining as ht_update_default_setting
> rtl8192u/ieee80211/rtl819x_HTProc.c changed to __ht_update_default_setting
>
> Referenced in files:
> staging/rtl8192e/rtllib_module.c remaining as ht_update_default_setting
> staging/rtl8192u/ieee80211_module.c changed to __ht_update_default_setting
>
> Linux Kernel Coding Style "cleanup", no change in runtime,
> staging/rtl8192e and rtl8192u compile/build before and after.
>
> Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
> ---
This doesn't apply, and there is no Fixes tag to suggest when these bugs
were introduced.
regards,
dan carpenter
prev parent reply other threads:[~2023-09-28 4:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 3:32 Gary Rookard
2023-09-28 4:57 ` Philipp Hortmann
2023-09-28 4:58 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469feda7-80db-4f22-8396-1eb10d07567b@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=garyrookard@fastmail.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®