mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux1394-devel@lists.sourceforge.net
Cc: David Brownell <david-b@pacbell.net>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	Russell King <rmk@arm.linux.org.uk>,
	David Miller <davem@davemloft.net>
Subject: Re: [patch 2.6.23-rc1] dma_free_coherent() needs irqs enabled (sigh)
Date: Wed, 25 Jul 2007 12:46:20 +0200	[thread overview]
Message-ID: <46A729FC.50407@s5r6.in-berlin.de> (raw)
In-Reply-To: <200707241429.05615.david-b@pacbell.net>

For linux1394-devel:

David Brownell wrote at LKML:
> On at least ARM (and I'm told MIPS too) dma_free_coherent() has a newish
> call context requirement:  unlike its dma_alloc_coherent() sibling, it
> may not be called with IRQs disabled.  (This was new behavior on ARM as
> of late 2006, caused by ARM SMP updates.)  This little surprise can be
> annoyingly driver-visible.
> 
> Since it looks like that restriction won't be removed, this patch changes
> the definition of the API to include that requirement.  Also, to help
> catch nonportable drivers, it updates the x86 and swiotlb versions to
> include the relevant warnings.  (I already observed that it trips on the
> bus_reset_tasklet of the new firewire_ohci driver.)

Also in ohci_set_config_rom().
-- 
Stefan Richter
-=====-=-=== -=== ==--=
http://arcgraph.de/sr/

  parent reply	other threads:[~2007-07-25 10:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-24 21:29 David Brownell
2007-07-24 22:07 ` Russell King
2007-07-24 23:08   ` David Brownell
2007-07-24 23:11     ` Russell King
2007-07-25  0:35       ` David Brownell
2007-07-25 10:46 ` Stefan Richter [this message]
2007-07-25 17:18   ` [PATCH] firewire: fw-ohci: dma_free_coherent needs IRQs enabled Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46A729FC.50407@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=davem@davemloft.net \
    --cc=david-b@pacbell.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome