mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Robert Hancock <hancockr@shaw.ca>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Olaf Hering <olh@suse.de>,
	linuxppc-dev@ozlabs.org, stable@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.22.y] ieee1394: revert "sbp2: enforce	32bit	DMA	mapping"
Date: Tue, 07 Aug 2007 00:59:53 +0200	[thread overview]
Message-ID: <46B7A7E9.5080606@s5r6.in-berlin.de> (raw)
In-Reply-To: <46B7A22D.4030909@shaw.ca>

Robert Hancock wrote:
> I would agree, though, that sbp2 isn't really the place for setting
> this, since the DMA mask is presently a property of the device, not of
> the user..

The mask that sbp2 set was because sbp2 has (in theory, not yet in
practice) a _narrower requirement on address ranges than the chip_ ---
hence it has (in theory) a narrower requirement on DMA mappings than the
ohci1394 driver has.

That's because sbp2 uses the controller in a special mode, as a bus
bridge.  It is the only user of that feature among the higher-level IEEE
1394 drivers.  No other IEEE 1394 application-layer software has this
requirement.

(Well, debugging and forensic tools rely on that mode too, notably
BenH's firescope, but this software runs remote, hence it's a different
beast from sbp2.)
-- 
Stefan Richter
-=====-=-=== =--- --===
http://arcgraph.de/sr/

  reply	other threads:[~2007-08-06 23:00 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fa.Qn3Snqoik3hhnxcA6HqjGV0Yzck@ifi.uio.no>
2007-08-04 17:14 ` Robert Hancock
2007-08-04 17:30   ` Stefan Richter
2007-08-05  0:15     ` Benjamin Herrenschmidt
2007-08-05  7:54       ` Stefan Richter
2007-08-05 22:04         ` Benjamin Herrenschmidt
2007-08-06 13:51           ` Olaf Hering
2007-08-06 21:47             ` Benjamin Herrenschmidt
2007-08-06 22:22               ` Stefan Richter
2007-08-06 22:25                 ` Robert Hancock
2007-08-06 22:32                   ` Benjamin Herrenschmidt
2007-08-06 22:35                     ` Robert Hancock
2007-08-06 22:59                       ` Stefan Richter [this message]
2007-08-06 22:48                   ` Stefan Richter
2007-08-07  2:18                     ` Andi Kleen
2007-08-06 22:29                 ` Benjamin Herrenschmidt
2007-08-06 11:58         ` Olaf Hering
2007-08-06 21:43           ` Benjamin Herrenschmidt
2007-08-06 22:05             ` [PATCH] powerpc: Fix initialization and usage of dma_mask Benjamin Herrenschmidt
2007-08-06 22:30               ` Olaf Hering
2007-08-04 16:39 [PATCH 2.6.22.y] ieee1394: revert "sbp2: enforce 32bit DMA mapping" Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46B7A7E9.5080606@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=benh@kernel.crashing.org \
    --cc=hancockr@shaw.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=olh@suse.de \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®