From: Ayaz Abdulla <aabdulla@nvidia.com>
To: Prakash Punnoor <prakash@punnoor.de>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
torvalds@linux-foundation.org, stable@kernel.org
Subject: Re: Linux 2.6.22.2
Date: Thu, 09 Aug 2007 17:40:16 -0400 [thread overview]
Message-ID: <46BB89C0.5070301@nvidia.com> (raw)
In-Reply-To: <200708101626.21927.prakash@punnoor.de>
[-- Attachment #1: Type: text/plain, Size: 747 bytes --]
Yes, you are right. Copy and paste error. I have attached a patch which
will fix this issue.
Thanks for catching it.
Ayaz
Signed-off-by: Ayaz Abdulla <aabdulla@nvidia.com>
Prakash Punnoor wrote:
> Hi,
>
> I just noticed that PHY_OUI_VITESSE == PHY_OUI_REALTEK. Is that really
> intentional?
>
>
>>diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
>>index 42ba1c0..a361dba 100644
>>--- a/drivers/net/forcedeth.c
>>+++ b/drivers/net/forcedeth.c
>>@@ -550,6 +550,8 @@ union ring_type {
>> /* PHY defines */
>> #define PHY_OUI_MARVELL 0x5043
>> #define PHY_OUI_CICADA 0x03f1
>>+#define PHY_OUI_VITESSE 0x01c1
>>+#define PHY_OUI_REALTEK 0x01c1
>
> -
> (°= =°)
> //\ Prakash Punnoor /\\
> V_/ \_V
[-- Attachment #2: patch-realtek-oui --]
[-- Type: text/plain, Size: 406 bytes --]
--- old/drivers/net/forcedeth.c 2007-08-09 17:37:12.000000000 -0400
+++ new/drivers/net/forcedeth.c 2007-08-09 17:37:07.000000000 -0400
@@ -551,7 +551,7 @@
#define PHY_OUI_MARVELL 0x5043
#define PHY_OUI_CICADA 0x03f1
#define PHY_OUI_VITESSE 0x01c1
-#define PHY_OUI_REALTEK 0x01c1
+#define PHY_OUI_REALTEK 0x0732
#define PHYID1_OUI_MASK 0x03ff
#define PHYID1_OUI_SHFT 6
#define PHYID2_OUI_MASK 0xfc00
next prev parent reply other threads:[~2007-08-10 17:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-09 21:47 Greg Kroah-Hartman
2007-08-09 21:47 ` Greg Kroah-Hartman
2007-08-10 14:26 ` Prakash Punnoor
2007-08-09 21:40 ` Ayaz Abdulla [this message]
2007-08-13 23:39 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46BB89C0.5070301@nvidia.com \
--to=aabdulla@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=prakash@punnoor.de \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome