mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nadav Amit <namit@vmware.com>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: the arch/x86 maintainers <x86@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andy Lutomirski <luto@kernel.org>,
	Brian Gerst <brgerst@gmail.com>,
	Denys Vlasenko <dvlasenk@redhat.com>,
	Ingo Molnar <mingo@kernel.org>, "H . Peter Anvin" <hpa@zytor.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [PATCH] x86/percpu: Introduce const-qualified const_pcpu_hot
Date: Sat, 21 Oct 2023 14:27:10 +0000	[thread overview]
Message-ID: <46C29ACB-0CC2-4484-A3D3-11F33FD08BEB@vmware.com> (raw)
In-Reply-To: <20231020162004.135244-1-ubizjak@gmail.com>



> On Oct 20, 2023, at 7:19 PM, Uros Bizjak <ubizjak@gmail.com> wrote:
> 
> By implementing constant-qualified const_pcpu_hot, the compiler can
> eliminate redundant reads from the constant variables, reducing the
> number of loads from current_task from 3766 to 3217 on a test build,
> a -14.6% reduction.

Thanks again for doing that. LGTM! [*]

--

[*] The negative sign here is unneeded, but that’s just me being
    negative. ;-)

 

  reply	other threads:[~2023-10-21 14:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-20 16:19 Uros Bizjak
2023-10-21 14:27 ` Nadav Amit [this message]
2023-10-23 10:39 ` [tip: x86/percpu] x86/percpu: Introduce const-qualified const_pcpu_hot to micro-optimize code generation tip-bot2 for Uros Bizjak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46C29ACB-0CC2-4484-A3D3-11F33FD08BEB@vmware.com \
    --to=namit@vmware.com \
    --cc=brgerst@gmail.com \
    --cc=dvlasenk@redhat.com \
    --cc=hpa@zytor.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=ubizjak@gmail.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®