From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754915AbbDGQCJ (ORCPT ); Tue, 7 Apr 2015 12:02:09 -0400 Received: from mga03.intel.com ([134.134.136.65]:44887 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754093AbbDGQCG convert rfc822-to-8bit (ORCPT ); Tue, 7 Apr 2015 12:02:06 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,538,1422950400"; d="scan'208";a="691513654" From: "Drokin, Oleg" To: Nickolaus Woodruff CC: Greg Kroah-Hartman , "hpdd-discuss@lists.01.org" , "" , " Mailing List" , "Dilger, Andreas" Subject: Re: [HPDD-discuss] [PATCH] staging: lustre: Make cfs_sched_rehash static Thread-Topic: [HPDD-discuss] [PATCH] staging: lustre: Make cfs_sched_rehash static Thread-Index: AQHQcSt9VL7si+DUh0yyknm27rajUJ1CKzUA Date: Tue, 7 Apr 2015 16:01:26 +0000 Message-ID: <46D5F9C2-7DB5-4D44-A1F4-153FEB192055@intel.com> References: <20150407020227.GA1500@Caladan> In-Reply-To: <20150407020227.GA1500@Caladan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.134.83] Content-Type: text/plain; charset="us-ascii" Content-ID: <6577E365790EC448A6B00AC457EA63E6@intel.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If you checked the code, you would see that it's used in drivers/staging/lustre/lustre/libcfs/module.c too. drivers/staging/lustre/lustre/libcfs/module.c:extern struct cfs_wi_sched *cfs_sched_rehash; drivers/staging/lustre/lustre/libcfs/module.c: rc, &cfs_sched_rehash); drivers/staging/lustre/lustre/libcfs/module.c: if (cfs_sched_rehash != NULL) { drivers/staging/lustre/lustre/libcfs/module.c: cfs_wi_sched_destroy(cfs_sched_rehash); drivers/staging/lustre/lustre/libcfs/module.c: cfs_sched_rehash = NULL; On Apr 6, 2015, at 10:02 PM, Nickolaus Woodruff wrote: > This patch fixes the following sparse warning: > > CHECK drivers/staging/lustre/lustre/libcfs/hash.c > drivers/staging/lustre/lustre/libcfs/hash.c:119:21: warning: symbol > 'cfs_sched_rehash' was not declared. Should it be static? > > Signed-off-by: Nickolaus Woodruff > --- > drivers/staging/lustre/lustre/libcfs/hash.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lustre/libcfs/hash.c b/drivers/staging/lustre/lustre/libcfs/hash.c > index a55567e..a4920a2 100644 > --- a/drivers/staging/lustre/lustre/libcfs/hash.c > +++ b/drivers/staging/lustre/lustre/libcfs/hash.c > @@ -116,7 +116,7 @@ module_param(warn_on_depth, uint, 0644); > MODULE_PARM_DESC(warn_on_depth, "warning when hash depth is high."); > #endif > > -struct cfs_wi_sched *cfs_sched_rehash; > +static struct cfs_wi_sched *cfs_sched_rehash; > > static inline void > cfs_hash_nl_lock(union cfs_hash_lock *lock, int exclusive) {} > -- > 1.9.1 > > _______________________________________________ > HPDD-discuss mailing list > HPDD-discuss@lists.01.org > https://lists.01.org/mailman/listinfo/hpdd-discuss