mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Drokin, Oleg" <oleg.drokin@intel.com>
To: Joe Perches <joe@perches.com>
Cc: James Simmons <jsimmons@infradead.org>,
	"<linux-kernel@vger.kernel.org>" <linux-kernel@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"<devel@driverdev.osuosl.org>" <devel@driverdev.osuosl.org>,
	"<lustre-devel@lists.lustre.org>" <lustre-devel@lists.lustre.org>
Subject: Re: [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef
Date: Fri, 1 Apr 2016 19:14:45 +0000	[thread overview]
Message-ID: <46D8C648-9F97-4D8D-B869-055B81A5E1EE@intel.com> (raw)
In-Reply-To: <1459536253.1744.26.camel@perches.com>


On Apr 1, 2016, at 2:44 PM, Joe Perches wrote:

> On Fri, 2016-04-01 at 14:23 +0000, Drokin, Oleg wrote:
>> On Apr 1, 2016, at 9:02 AM, Joe Perches wrote:
>>> 
>>> Question about removing lustre typedefs.
>>> 
>>> Various bits of lustre code use a mix of struct foo and foo_t.
>>> 
>>> When would be an appropriate time to submit patches similar to
>>> below that individually remove various typedefs from lustre code?
>> I think now is as good time as any.
>> the only small correction is those are LNet typedefs.
>> While LNet is technically part of Lustre, it's a bit of a separate
>> thing useful without Lustre too.
>> 
>> I know James is working on cleaning up LNet, but I don't know if he has
>> anything this would be conflicting at this moment or not.
>> 
>> Thanks for the patches. I wonder if you are generating them automatically?
>> Because it would be great if it also fixes the alignment issues
> 
> It's pretty automatic.
> 
> It's a trivial variant of the detypedef perl script I wrote awhile ago:
> http://permalink.gmane.org/gmane.linux.drivers.driver-project.devel/18603
> 
> 
> I think changing the alignment issues is better done in a
> separate patch.

but then it's two patches per change in a way. fixing one thing breaking
the other warning-wise, that's why I typically try to make such cleanup
patches not to introduce any new warnings.
> 
> James isn't cc'd on these patches as he's not a listed
> maintainer.  Maybe he should be added for all of it or
> some part of it?
> 

for drivers/staging/lustre/lnet

for the drivers/staging/lustre/lustre - the only remaining
few typedefs I am going to address, it's just some of the code using
them will go away or change the users significantly - that's why
they were left out in the first round of lustre detypedefisation.

Thanks.

  reply	other threads:[~2016-04-01 19:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-01 13:02 Joe Perches
2016-04-01 13:02 ` [RFC PATCH 1/3] staging: lustre: Remove typedef lnet_peer_t Joe Perches
2016-04-01 13:02 ` [RFC PATCH 2/3] staging: lustre: Remove typedef lnd_t Joe Perches
2016-04-01 13:02 ` [RFC PATCH 3/3] staging: lustre: Remove typedef lnet_msg_t Joe Perches
2016-04-01 14:23 ` [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef Drokin, Oleg
2016-04-01 18:44   ` Joe Perches
2016-04-01 19:14     ` Drokin, Oleg [this message]
2016-04-01 19:27       ` Joe Perches
2016-04-01 19:56     ` James Simmons
2016-04-01 20:03       ` [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypede James Simmons
2016-04-01 19:56     ` [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef James Simmons
2016-04-01 19:57     ` James Simmons
2016-04-01 19:57     ` James Simmons
2016-04-01 19:59     ` James Simmons
2016-04-01 15:58 ` Simmons, James A.
2016-04-01 18:54   ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46D8C648-9F97-4D8D-B869-055B81A5E1EE@intel.com \
    --to=oleg.drokin@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=jsimmons@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lustre-devel@lists.lustre.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®