From: Micah Gruber <micah.gruber@gmail.com>
To: linux-kernel@vger.kernel.org,
linux-usb-devel@lists.sourceforge.net, gregkh@suse.de
Subject: [PATCH] Fix a potential NULL pointer dereference in usbat_check_status() in drivers/usb/storage/shuttle_usbat.c
Date: Tue, 04 Sep 2007 16:25:05 +0800 [thread overview]
Message-ID: <46DD1661.4070500@gmail.com> (raw)
This patch fixes a potential null dereference bug where we dereference us before a null check. This patch simply moves the dereferencing after the null check.
Signed-off-by: Micah Gruber <micah.gruber@gmail.com>
---
--- a/drivers/usb/storage/shuttle_usbat.c
+++ b/drivers/usb/storage/shuttle_usbat.c
@@ -187,12 +187,14 @@
*/
static int usbat_check_status(struct us_data *us)
{
- unsigned char *reply = us->iobuf;
+ unsigned char *reply;
int rc;
if (!us)
return USB_STOR_TRANSPORT_ERROR;
+ reply = us->iobuf;
+
rc = usbat_get_status(us, reply);
if (rc != USB_STOR_XFER_GOOD)
return USB_STOR_TRANSPORT_FAILED;
next reply other threads:[~2007-09-04 8:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-04 8:25 Micah Gruber [this message]
2007-09-04 11:06 ` Jens Axboe
2007-09-04 19:57 ` Simon Holm Thøgersen
2007-09-04 20:58 ` [linux-usb-devel] " Alan Stern
2007-09-04 21:06 ` Jens Axboe
2007-09-06 22:33 ` [PATCH] Remove pointless NULL pointer check " Simon Holm Thøgersen
2007-09-10 16:33 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46DD1661.4070500@gmail.com \
--to=micah.gruber@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome