From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: Badari Pulavarty <pbadari@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
balbir@in.ibm.com, lkml <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.23-rc6-mm1 panic (memory controller issue ?)
Date: Wed, 19 Sep 2007 23:48:42 +0530 [thread overview]
Message-ID: <46F16802.4010002@linux.vnet.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0709191024440.11138@schroedinger.engr.sgi.com>
Christoph Lameter wrote:
> On Wed, 19 Sep 2007, Balbir Singh wrote:
>
>> The fix looks correct, radix_tree_preload() does the same thing in
>> add_to_page_cache(). Thanks for identifying the fix
>
> Hmmm.... Radix tree preload can only take a limited set of flags?
>
Yes, the whole code is very interesting. From add_to_page_cache()
we call radix_tree_preload with __GFP_HIGHMEM cleared, but
from __add_to_swap_cache(), we don't make any changes to the
gfp_mask. radix_tree_preload() calls kmem_cache_alloc() and in slub
there is a check
BUG_ON(flags & GFP_SLAB_BUG_MASK);
So, I guess all our allocations should check against __GFP_DMA and
__GFP_HIGHMEM. I'll review the code, test it and send a fix.
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
next prev parent reply other threads:[~2007-09-19 18:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-18 22:21 Badari Pulavarty
2007-09-19 0:31 ` Badari Pulavarty
2007-09-19 1:53 ` Balbir Singh
2007-09-19 17:25 ` Christoph Lameter
2007-09-19 18:18 ` Balbir Singh [this message]
2007-09-19 18:54 ` Christoph Lameter
2007-09-19 19:04 ` Balbir Singh
2007-09-19 17:24 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F16802.4010002@linux.vnet.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@in.ibm.com \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome