mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David Bahi" <dbahi@novell.com>
To: <linux-kernel@vger.kernel.org>, <linux-rt-users@vger.kernel.org>
Cc: <tglx@linutronix.de>, "Gregory Haskins" <GHaskins@novell.com>
Subject: nmi_watchdog fix for x86_64 to be more like i386
Date: Wed, 26 Sep 2007 12:03:12 -0600	[thread overview]
Message-ID: <46FA4A800200006C000192FE@sinclair.provo.novell.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 126 bytes --]

Thanks to tglx and ghaskins for all the help in tracking down a very
early nmi_watchdog crash on certain x86_64 machines.


[-- Attachment #2: watchdog_use_timer_and_hpet_on_x86_64.patch --]
[-- Type: text/plain, Size: 1144 bytes --]

This modifies nmi_watchdog_tick behavior for 
x86_64 arch to consider both timer and hpet IRQs
just as the i386 arch does.

Signed-off-by: David Bahi <dbahi@novell.com>

---
 arch/x86_64/kernel/nmi.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Index: linux-2.6.22.8-rt9_1267/arch/x86_64/kernel/nmi.c
===================================================================
--- linux-2.6.22.8-rt9_1267.orig/arch/x86_64/kernel/nmi.c
+++ linux-2.6.22.8-rt9_1267/arch/x86_64/kernel/nmi.c
@@ -369,8 +369,6 @@ int notrace __kprobes nmi_watchdog_tick(
 		touched = 1;
 	}
 
-	sum = read_pda(apic_timer_irqs);
-
 	if (__get_cpu_var(nmi_touch)) {
 		__get_cpu_var(nmi_touch) = 0;
 		touched = 1;
@@ -386,6 +384,12 @@ int notrace __kprobes nmi_watchdog_tick(
 		cpu_clear(cpu, backtrace_mask);
 	}
 
+	/*
+	 * Take the local apic timer and PIT/HPET into account. We don't
+	 * know which one is active, when we have highres/dyntick on
+	 */
+	sum = read_pda(apic_timer_irqs) + kstat_cpu(cpu).irqs[0];
+
 #ifdef CONFIG_X86_MCE
 	/* Could check oops_in_progress here too, but it's safer
 	   not too */

[-- Attachment #3: signature.asc --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

             reply	other threads:[~2007-09-26 18:23 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-26 18:03 David Bahi [this message]
2007-10-01 17:36 ` Andi Kleen
2007-10-01 18:54   ` Thomas Gleixner
2007-10-01 19:16     ` Andi Kleen
2007-10-01 19:27       ` Thomas Gleixner
2007-10-01 19:56         ` Arjan van de Ven
2007-10-01 20:10           ` Dave Jones
2007-10-01 20:11           ` Paul E. McKenney
2007-10-01 21:17           ` Thomas Gleixner
2007-10-01 21:41             ` Andi Kleen
2007-10-01 21:58               ` Thomas Gleixner
2007-10-01 22:07                 ` Andi Kleen
2007-10-01 22:47                   ` Thomas Gleixner
2007-10-01 22:52                     ` Arjan van de Ven
2007-10-02  4:56                     ` Mika Penttilä
2007-10-02  5:00                       ` Arjan van de Ven
2007-10-02  5:51                     ` Andi Kleen
2007-10-02  6:18                       ` Thomas Gleixner
2007-10-05  4:37                         ` Pallipadi, Venkatesh
2007-10-05 20:37                           ` Thomas Gleixner
2007-10-05 16:01 David Bahi
2007-10-05 16:03 ` Andi Kleen
2007-10-05 17:38   ` Peter W. Morreale
2007-10-05 18:00     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46FA4A800200006C000192FE@sinclair.provo.novell.com \
    --to=dbahi@novell.com \
    --cc=GHaskins@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®