From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751192AbdBWLWC (ORCPT ); Thu, 23 Feb 2017 06:22:02 -0500 Received: from mail-lf0-f50.google.com ([209.85.215.50]:35854 "EHLO mail-lf0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751049AbdBWLWA (ORCPT ); Thu, 23 Feb 2017 06:22:00 -0500 Subject: Re: [PATCH] uapi: fix linux/rds.h userspace compilation errors To: "Dmitry V. Levin" , "David S. Miller" , Santosh Shilimkar , Sowmini Varadhan References: <20170223011320.GA16142@altlinux.org> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Message-ID: <46a28c0c-36fe-db81-d263-f737f1d3ea05@cogentembedded.com> Date: Thu, 23 Feb 2017 14:20:24 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20170223011320.GA16142@altlinux.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On 2/23/2017 4:13 AM, Dmitry V. Levin wrote: > Consistently use types from linux/types.h to fix the following > linux/rds.h userspace compilation errors: > > /usr/include/linux/rds.h:198:2: error: unknown type name 'u8' > u8 rx_traces; > /usr/include/linux/rds.h:199:2: error: unknown type name 'u8' > u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX]; > /usr/include/linux/rds.h:203:2: error: unknown type name 'u8' > u8 rx_traces; > /usr/include/linux/rds.h:204:2: error: unknown type name 'u8' > u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX]; > /usr/include/linux/rds.h:205:2: error: unknown type name 'u64' > u64 rx_trace[RDS_MSG_RX_DGRAM_TRACE_MAX]; > > Fixes: 3289025a("RDS: add receive message trace used by application") Need at least 12 hex digits and a space before (. > Signed-off-by: Dmitry V. Levin [...] MBR, Sergei