From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43E95C71145 for ; Thu, 24 Aug 2023 12:40:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238195AbjHXMkX (ORCPT ); Thu, 24 Aug 2023 08:40:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238607AbjHXMkQ (ORCPT ); Thu, 24 Aug 2023 08:40:16 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FC6C198B for ; Thu, 24 Aug 2023 05:40:14 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-51bece5d935so8561037a12.1 for ; Thu, 24 Aug 2023 05:40:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692880812; x=1693485612; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wqMVuZgSs+Wu8Z+ehdcmYCmlouSlct+heFdmNRVbxgA=; b=FIIljaCMS3LSAeyIwGG1CFHuk2amuKWkzFuUPAWNzTZVyoeIg97RcEyJkTNv1AOC4R bUfZ8ZwJG1jNq1FzLnH4TVhJXMtiBMxTIFBgOokj5QQG7FCfPuimrHeeVxJ5n8lCP2wc YiAMaKMi7q6EI9txbhyIKrnUtzLnixK9Fc9tFua9N0Ga5iXAjrWWyBnHfQxiUEx63+H4 bwnoKKrnVUIJieeXJQy67Lhk0jWP5HmSymaxiFHnBqLhROG0nBZHAhqZD30Vo1stVrAa p9D9y67QUvlhYRhPfvm5M1ZxpMJGk/yKHWv4Uq+T3WEQY4XrVzJbSEzYjtsBtrpUFU4E 5F8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692880812; x=1693485612; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wqMVuZgSs+Wu8Z+ehdcmYCmlouSlct+heFdmNRVbxgA=; b=Ve7VMgbIT/W/Pnkb99dhabrxbtwcQ0KqPfzk38fLV/4nleihwa+Ta1bFP5wLETn3j5 H1qi+9iVSb505ycPYd6KV99u7BCBt4n+QY12vtaXLKFbZBLA7OAcoagr2RbsLdsNHH75 ulssOzTxJ5E7mPFeQ4bggcd3mBbT6hcIQgxeS1iVVuh75ct+/pdxTjHLOytoe2uUyEmx /EfSSsAHL/D03vSU/xwlXlOed6L9ZmJfgLQr2fk3W/1JSYQWYN84L/aV7wSCN8MdZdhb UFsv/HymO2Gx7aYqevDFiwYqvzDvsvPZYBRV5wAo3VQz6veNKVUQ8h2BDX2A8WH1z7tc hLEw== X-Gm-Message-State: AOJu0YzWtrhAiSXl4V6xa39OJm958xylUBD3xjCSi9DKm6tWfiZzR5eY OXYgn8tgrX+j46typFTwSdGhJQ== X-Google-Smtp-Source: AGHT+IEjcG+DIJTiu+zFCt/pQNZPjv8quz5M9OOkFjSmEnD6DO15qu9MPOQeD2ffsT+uLol9dT4AhA== X-Received: by 2002:aa7:d9c7:0:b0:529:4642:7933 with SMTP id v7-20020aa7d9c7000000b0052946427933mr13040061eds.36.1692880812560; Thu, 24 Aug 2023 05:40:12 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.198]) by smtp.gmail.com with ESMTPSA id l15-20020a056402124f00b0051dfa2e30b2sm10559541edw.9.2023.08.24.05.40.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Aug 2023 05:40:12 -0700 (PDT) Message-ID: <46a562b5-6984-3b41-3c41-c346107b4c96@linaro.org> Date: Thu, 24 Aug 2023 14:40:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 1/2] power: supply: bq24190: Support bq24193 Content-Language: en-US To: Emmanuel Gil Peyrot Cc: Alexandre Courbot , azkali , CTCaer , Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230824112741.201353-1-linkmauve@linkmauve.fr> <20230824112741.201353-2-linkmauve@linkmauve.fr> From: Krzysztof Kozlowski In-Reply-To: <20230824112741.201353-2-linkmauve@linkmauve.fr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/08/2023 13:27, Emmanuel Gil Peyrot wrote: > From: Alexandre Courbot > > This charger is working with the driver as-is, so enable it to be probed. > > It is used in the Nintendo Switch for instance. > > Signed-off-by: Alexandre Courbot > --- > Documentation/devicetree/bindings/power/supply/bq24190.yaml | 1 + > drivers/power/supply/bq24190_charger.c | 2 ++ Please run scripts/checkpatch.pl and fix reported warnings. Some warnings can be ignored, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Bindings are always separate. Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. > 2 files changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/supply/bq24190.yaml b/Documentation/devicetree/bindings/power/supply/bq24190.yaml > index d3ebc9de8c0b..92a28d3c3070 100644 > --- a/Documentation/devicetree/bindings/power/supply/bq24190.yaml > +++ b/Documentation/devicetree/bindings/power/supply/bq24190.yaml > @@ -18,6 +18,7 @@ properties: > enum: > - ti,bq24190 > - ti,bq24192 > + - ti,bq24193 > - ti,bq24192i > - ti,bq24196 > > diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c > index ef8235848f56..a56122b39687 100644 > --- a/drivers/power/supply/bq24190_charger.c > +++ b/drivers/power/supply/bq24190_charger.c > @@ -2018,6 +2018,7 @@ static const struct dev_pm_ops bq24190_pm_ops = { > static const struct i2c_device_id bq24190_i2c_ids[] = { > { "bq24190" }, > { "bq24192" }, > + { "bq24193" }, > { "bq24192i" }, > { "bq24196" }, > { }, > @@ -2027,6 +2028,7 @@ MODULE_DEVICE_TABLE(i2c, bq24190_i2c_ids); > static const struct of_device_id bq24190_of_match[] = { > { .compatible = "ti,bq24190", }, > { .compatible = "ti,bq24192", }, > + { .compatible = "ti,bq24193", }, > { .compatible = "ti,bq24192i", }, > { .compatible = "ti,bq24196", }, We should really stop doing this. All of them are compatible, aren't they? Best regards, Krzysztof