mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Avri Altman <avri.altman@wdc.com>,
	"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Adrian Hunter <adrian.hunter@intel.com>,
	Bean Huo <beanhuo@micron.com>
Subject: Re: [PATCH 2/3] scsi: ufs: Add temperature notification exception handling
Date: Wed, 1 Sep 2021 09:39:30 -0700	[thread overview]
Message-ID: <46a7ea4f-2c6b-7798-5845-ad47c64617dd@acm.org> (raw)
In-Reply-To: <20210901123707.5014-3-avri.altman@wdc.com>

On 9/1/21 5:37 AM, Avri Altman wrote:
> It is essentially up to the platform to decide what further actions need
> to be taken. So add a designated vop for that.  Each chipset vendor can
> decide if it wants to use the thermal subsystem, hw monitor, or some
> Privet implementation.

Why to make chipset vendors define what to do in case of extreme 
temperatures? I'd prefer a single implementation in ufshcd.c instead of 
making each vendor come up with a different implementation.

> +	void	(*temp_notify)(struct ufs_hba *hba, u16 status);

Please do not add new vops without adding at least one implementation of 
that vop.

Thanks,

Bart.

  parent reply	other threads:[~2021-09-01 16:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-01 12:37 [PATCH 0/3] Add temperature notification support Avri Altman
2021-09-01 12:37 ` [PATCH 1/3] scsi: ufs: Probe for " Avri Altman
2021-09-01 16:35   ` Bart Van Assche
2021-09-02  6:24     ` Avri Altman
2021-09-01 12:37 ` [PATCH 2/3] scsi: ufs: Add temperature notification exception handling Avri Altman
2021-09-01 15:51   ` Asutosh Das (asd)
2021-09-01 16:39   ` Bart Van Assche [this message]
2021-09-01 19:40     ` Asutosh Das (asd)
2021-09-02  6:46       ` Avri Altman
2021-09-01 12:37 ` [PATCH 3/3] scsi: ufs-sysfs: Add sysfs entries for temperature notification Avri Altman
2021-09-01 16:52   ` Bart Van Assche
2021-09-02  6:52     ` Avri Altman
2021-09-02 19:58       ` Avri Altman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46a7ea4f-2c6b-7798-5845-ad47c64617dd@acm.org \
    --to=bvanassche@acm.org \
    --cc=adrian.hunter@intel.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®