From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750932AbdALPWR (ORCPT ); Thu, 12 Jan 2017 10:22:17 -0500 Received: from mail-he1eur01on0068.outbound.protection.outlook.com ([104.47.0.68]:32256 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750805AbdALPWL (ORCPT ); Thu, 12 Jan 2017 10:22:11 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ogerlitz@mellanox.com; Subject: Re: [PATCH] [net] net/mlx5e: fix another -Wmaybe-uninitialized warning To: Arnd Bergmann References: <20170111211451.2705705-1-arnd@arndb.de> CC: Saeed Mahameed , Hadar Hen Zion , "David S . Miller" , , From: Or Gerlitz Message-ID: <46a85790-2cfe-a8d9-f764-4f736fbd1af7@mellanox.com> Date: Thu, 12 Jan 2017 17:21:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170111211451.2705705-1-arnd@arndb.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [193.47.165.251] X-ClientProxiedBy: VI1PR09CA0071.eurprd09.prod.outlook.com (10.174.49.143) To DB6PR0501MB2120.eurprd05.prod.outlook.com (10.168.9.148) X-MS-Office365-Filtering-Correlation-Id: 43224ea1-8677-4816-4031-08d43afebeff X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DB6PR0501MB2120; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0501MB2120;3:13EnQM5bIiivM/XSMxeBFte3CXHgmFDg+w4lfoGoiN2i2lK7Mn2n9uYF0Utq8k0kM/SzPI52g+LdbAH1YAw/8shI20+BdWPhicma3aWJiUEeRYVBL4vp6ufKCBZbnnx8tGKjFdYsAK5klSQr1cO9Hp+ghYtNwrQE/xFyAtTMOPGNjxkuUZWQqO40cFgyK1NP+0wqYimo3TasazaEwsZTHXVJr0W+U/nErkKyf6ANpPeEMrTI/kqHfBb/erE8giWsdDx/NpophQzW0u6NnmFEYQ==;25:14Gv5SF0tsTDbiTLsPK6wqo2U93Eo1kAfLDq/erOSMfuV4SsckCDPpsFJz6UiuA6bNjrVMZnYyCSB3KyDyDgJYxcVhbXGuhrmawNRAA4zxHA4JZcDUGHgScvD/P6BHamORGjyZqdXzlsjiXN/dV85xe5/jqN/cQR/iGzzXU0aM2R0H2PcymJWTGy7sjlB3J1st2mil2JmfMnN/fAgWTD6VDAK3T9nVDyJOORUfWyGMGVE5LBt7/OyknyG1e4VeKtk+goana2NMEvd5mySthtxtRePUeIG5lpcDH4f5d0Np3I60evSaffUZb2idVGmjC0d+GbY7flWZPq/5405x73ck4mp0+e3uoLE/nZcdZqIrKVR3/BxuslqNCESaJkSiL1ROML3jIcti1kirl+yf0NWC1ma0GzAd6ZZIr3Uk7encTR23+nZQiCoTiENxnNQjavGx8ny6C0uZomAvDdh33UWA== X-Microsoft-Exchange-Diagnostics: 1;DB6PR0501MB2120;31:l8H4KXKe7x8I7qwrAYPAIgQY1FQukf4bjlEmCf8koNRBvjvVpPzysj22gJN1utPkuzutnOSZCetePkITwUh1qQVOZRtAe34Q/LTe5BK6BGJ2Qb7FWbkFDsTIen7TVTAz5quPinrE36KoC06RyGIVFcp3ghULpaFRBIEJNg/Q8CI3P4yXBJvygNvZCPLa7TjE/xsHVj4AGJ22Ahvliv1OV2EDjn73t68n+zHwJfI2YFUSYJ64QBxDukXy7Yy4Vsta;20:7JlS9SwNicwId3GjthJVP+g5EpofAq8TKRgxW40yzn91/CRY5t6X8wXlYPiANZExSupyJSp91Xz7BTZfWEMxJy4fuZpi1WWbRJefKzwpa4tvxg4wzS7EUAN42YIPIgXXE7j6jyEhnDrQQSS1yJV/YlBrWMdb1+bNhhTURF6h8LjLj6uWS3d4us9VwRvfNggVb4si5KBWhoytiVTMPTY+EDrXpS7ExcaSD+2xi/y9ItqmvommICSFi4qqrPBts2yhZyZBvXYwmCheY0hq7SwnmkXkK08UTE1fHawFYLmXfGogzLMg6bCTh2XkkQgCdapNHaXs/rpUGieytVgfJDkOKJ++vq6TrGv0w4Xw1X0BWOccIDfK1Kx278Fp1eCg03YZHsr1gQtm6Zhc5bLiWm+Dwfr2DEMsVo434NNvUx5JuRar1BKTLtVnYyjBhGg5LGdYo/+91E8FGs0M24P3tUcixoFI7tsNT5caif7pELWSUGji8NXS40XRyhDAycqvC7lW X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123560025)(20161123564025)(20161123562025)(20161123555025)(6072148);SRVR:DB6PR0501MB2120;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0501MB2120; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0501MB2120;4:JBaJDmXA8kVZ2usFU6RN4aYjtL8HHdXDqCuxmIbAnIR0swiDvZ+u+hvW9wheSosp/5VcMYGtc+LhYppHU+/ibpQeu/U0eWQEO6AFld7v52+WFwdgN4VpzASLzdiJVk+yN14HHKvE4bUPzPsRXU+CQym+ibjtibCBCEcH9kQBNKgAVORIcBtj42hE4sdR/cXSfN7MAjSqieO1gKnjs8yXviX92NnM8QmOtuXFWr7BPobTPMz5XPEeEcCChGHN1tp82FW48eJ7Xo3DchCkoiA2i8gSW5gjWqTNlPWcTr7s8hPhm1m2uFEuqZGo7oXBIat2T4bMbW+7/QN1OUzC8TkXh652qNzCylMUsmRbuNaGdfViXYIK3/0FkA2dn92foxidiVzDpJcGhQc1xXi6LI7aYxQdZpTMTSL4ovgv36aWj8k+PXYkWDhu/CLjuoeKYCqL1D2zsIeWhBNcV42fntBsfCWCxawDJyYJKelee2KE1aJMGg2bhIGh2nOmEr/cLa+DfPWJyE5BRGiIzCz1LBf7baloa+iclnY7TRdnaJ282J3Fydfj+G16kEDACsnN5cZb3Hp2wab+eM8gYdT72RZI4ZmceuYQG/q+BM11AcqWCBk= X-Forefront-PRVS: 018577E36E X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(7916002)(39860400002)(39840400002)(39850400002)(39450400003)(39410400002)(377454003)(199003)(24454002)(189002)(101416001)(4001350100001)(92566002)(50466002)(54356999)(106356001)(36756003)(76176999)(50986999)(229853002)(25786008)(90366009)(83506001)(38730400001)(23746002)(54906002)(6486002)(77096006)(65956001)(3846002)(6116002)(65826007)(86362001)(6666003)(305945005)(31696002)(7736002)(31686004)(66066001)(4326007)(81156014)(81166006)(65806001)(8676002)(47776003)(42186005)(5660300001)(64126003)(68736007)(189998001)(105586002)(97736004)(33646002)(110136003)(2950100002)(6916009)(2906002)(230700001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0501MB2120;H:[10.239.0.153];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DB6PR0501MB2120;23:BFRaBAurJjdz1PeZR10quyTTBAwrwIwd/Ka?= =?Windows-1252?Q?yI/13f5BOwYB+trDXksMML8z+XpciTL6h/TPMFSb91G7f0qbJ/7J7Dyi?= =?Windows-1252?Q?Oq0hIrO2WygWrxnFIZ8d6T8mXNe0IW3zM2IySeftexXLb9+S2LfYE4OH?= =?Windows-1252?Q?QghXrrZtULE20rP5WIuQFD04DZ/M/mTJj5NrppcIkNZFEEKWyxmEDmxk?= =?Windows-1252?Q?+FaxXNEsJ8wGTqPFWGydIdOB9QRneqTJWGHXUkxnqYczmktkYiWXwKUD?= =?Windows-1252?Q?9SuA4Et7tHp/vye33V8W5MUKCFaOpS5NjvilsBoz0AsEiYRNMbkRCeuV?= =?Windows-1252?Q?Ksiqdq02KZ0YZAaU8i4w3Ot4iwA+1TCc3SGmHIHnBHXGwj1CcDuC+N62?= =?Windows-1252?Q?BAVncxEXMLIwenQfPf6LOvSFuPJJrvAlBHokqpCs5W40EWJq+5N6Wfay?= =?Windows-1252?Q?SCJBLBKxIv4IBJT+zacsHN5/e70ELg5L+LAOF6lv2Z8LVMDWS+jIkhOz?= =?Windows-1252?Q?Z1MOTEG6iWJ+YkrlQHxDy0vnzZQnGEV9/aVapFyCz+XUWZpl42WkLD4a?= =?Windows-1252?Q?D5Ou3aGpMAwhJcp6ZJAM9zOGVgtRbTyPpURjwAWX6jtWXdIG7CWTtPRM?= =?Windows-1252?Q?bJVS8ZajQPQBm7L3pkbhKxI2ytmNjSE/9NR/IqJrMMj4dukb5enEmnQ6?= =?Windows-1252?Q?ao1qHHGkteLePMRfSDCIMoFB6qDSf2sqV3dY3yAp7F1plw6eaRg3sX21?= =?Windows-1252?Q?3k3hzdFUFuwyw1T204KIHD78Ffr0QOp1zcNT72oL3o/J89K6UEaTzcqq?= =?Windows-1252?Q?r9DeO5vpvG/L5ZW7RmD/T8hVWnqZ4Ngo+KJBGUW88bjsuO894mfhifWy?= =?Windows-1252?Q?Ym2pShlRUHti7+mGKqde530vSx8o5pqFF8t2rlaQzLYOX6v+cAVFriZD?= =?Windows-1252?Q?sZ31/64dIqp4OpqPutoQDXtwqGrgdNuHzEqBZXScCqjQhIOMHMcwhuFe?= =?Windows-1252?Q?XAqSZPQ7lROZQOKVBFXd2Yl0Hs3h7zH45xtpgiqJF3d2nHsNZUZMMXs9?= =?Windows-1252?Q?cQ/ohV8kYOsIYqTxw2EWPjYf7z0A2cQnJ6Nw2Mp/xyzI0k0vEU92m5ym?= =?Windows-1252?Q?mKimdj7u03ohJGeA5zs76X3kAB797mV9cGNUsqwqyrgzeHWioZ8RXM0U?= =?Windows-1252?Q?xFU34BWghwcztbY4ARiaCpdFj3HKn0w/buKkySLOCKmVEBLI5n5N2LpH?= =?Windows-1252?Q?lupQjP2cC5BGzSWinlxX5JaCFyKeB1/+BS9EHMOWvcAIsBQ2+RDSacuX?= =?Windows-1252?Q?3jTjoDJHUCLNdjmi7OaamvyXFm6I1i+qFqcIvZAVWHlZFX5EbMlMibZX?= =?Windows-1252?Q?H3xNXsvFVYLbeWlo4Ou3d6KGvSt7VQR4VHXf+yF6zWSDcxN+Wh86XTvo?= =?Windows-1252?Q?rnlsQXaJKcyFIjrzW1VYfZTGzzssUq/g/ysGN8UO5df6OlktzGz+gd0F?= =?Windows-1252?Q?YfDYJJBj3E6Je4V0OmNe2+WQkRDG74b0Ik4BZZNuUeP3i2vrhOHQnVRx?= =?Windows-1252?Q?FbHqOEH0NeCx2oYOqH0McwDFL4vG6SsN9vGEA?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0501MB2120;6:2fkDi1BLVm3hFth65rbAG1FbEquIYFWU1TcKDAm8dGcNJRxc0vEbxaL8K1jKWScNMTKM/7tANH9LhqqNxbRvzxhoha+JK32BGohkeeqXYTDOXJ5qpy8GD/u3elKeY02WFqZFxTJcr1hqkG8WayHNWwphOC0B75LpA59yLT2vVavVlyABjeiihge30N8BssFBIlvAmzk2Ib1BklOxK2cHZCRZtPaXrZlXUu0pYtIWCDeS8ndNsmOZ57FWrPGjXxq0lbo/bGEuqJ/G2etyxvVuOgm/3KcOv9N8Ot7RbGTQVRtFE8lCYUBucc75nEUFiyACxsqF3ihnOw+Eq1Q+0NwFUuCwZxceOYaB6L3OmL6ypRZHahFVJfXoIkqBfjF4lN+wiTFgC6Ms8zA21JCrAqWaIzGKZauTXBIaxggSDQ22HN99C7Ug0GD1qk+vJrFBbVMJp8lYh4yQUBvauVCDLR3aeQ==;5:4qb4b5auFeFzpZ1v+htb5lpZ/l4tsoB5bNDLMAfwwrDILxF/K5DT6E2gfppndk6k7pffaHB2WO9sar4eBZAEKM0zuVt/+83gAo/bURwIRjwqu2wEg3Rv6gXfiDOfMtdsgfrKXNztUCI5fWhLWydu7xHDwzxxrKBInHY64oUQdrw=;24:EAr4LOdX2Q6EIlL0UnD4L72YE4MhZ/MabfTVkQGD/i/6R3flRzr2ZmUI948rjHpnrabPL7iZTw2U1q3HX0MVEYKVgS7vKraJi1MnkvPEpuo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB6PR0501MB2120;7:G8SOO8nJw8kr6YrnI9mkVM5Y2zonoeQFidYTqAIlAYk/vyhyx3MvSPbuYWhWDhAQALkt9m8YYvZpQXBiUkYFKwC5JA+L1N11shT7l06c/969JFWmtAxN7JJaK5GxztG4k8eJ6fKzasBybNUA1nLjpO93CTQnPbze/d405HHI7WDZ06TxFJlka6NtBaBk01Viuv5EnxMuDeeUIEgWr4abAwYPS5bccRj6AbufSefH2YWYLi9g7JVRu5U4qC+8r8rAsKJV3LLqjjjDJflZRLV3feuyztbnDE9+rr+ANNwK1w+wt4HebpmyG0f3af9435U0u7I9NIq/mNqZEcDWEl5z/Uqkpoj/0F9EWFiX6nIyJiRUfTuqX4KGIWniDVwva4wjXgH96hpq2pDzg/bEI/zWbdWG+UFvU/5/9O2FqucN+16JqAqFOsnGxVZZt9RRZ/8xp+/eJY2HiEOU+VU6DG3Sxg== X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2017 15:21:55.7078 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2120 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/11/2017 11:14 PM, Arnd Bergmann wrote: > As found by Olof's build bot, today's mainline kernel gained a harmless > warning about a potential uninitalied variable reference: > > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c: In function 'parse_tc_fdb_actions': > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c:769:13: warning: 'out_dev' may be used uninitialized in this function [-Wmaybe-uninitialized] > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c:811:21: note: 'out_dev' was declared here > > This was introduced through the addition of an 'IS_ERR/PTR_ERR' pair that > gcc is unfortunately unable to completely figure out. Replacing it with > PTR_ERR_OR_ZERO makes the code more understandable to gcc so it no longer > warns. can you elaborate on this a little further? > Hadar Hen Zion already attempted to fix the warning earlier by adding > fake initializations, but that ended up just making the code worse without > fully addressing all warnings, so I'm reverting it now that it is no longer needed. ok, so if your approach eliminates the warning on out_dev and also on the variables for which Hadar added the faked initializers, I guess we should be fine with this change (saw your reply on my other comment), just another question: > In order to avoid pulling a variable declaration into the #ifdef, I'm > removing it in favor of a more readable 'if()' statement here that has the same effect. When I build here without CONFIG_INET in my system, the build goes fine with this approach. However, we're pretty sure that in the past we got 0-day report from the kbuild test robot where he was unhappy that we make the ip_route_output_key call without being wrapped with that #if IS_ENABLED(CONFIG_INET) -- so, we don't want to go there again... thoughts? Or.