From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 180823E95B6 for ; Tue, 24 Mar 2026 11:42:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352545; cv=none; b=qBj22oe93AROAaNuqJUMUIgNqtn5xFZBDDWk9NHHY07ED/G1B9WkH0saqHXdWUV3FQ6UzS/qcOfnE4IRDQuUlE/62XcnOWYONtkZmzZCBUIleOA8KKZWpfIqqhXBAgOU1r7UQ5glU6WWE7OkMGJXT1pSO2C14ImfeYdR1jYHnKI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352545; c=relaxed/simple; bh=esc67us1UIomEqAcLAINh+D2RrHyu6uD2oj798DuCUc=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=LbDt+9qUlbRwHaM4vpGES0le92XoBMmWWWDzR1kJHhCcLRCBRr4hxsmGEBdCmPkukeDHHBCyDCEkj0BdY4BFJ1wuGgBwkJUMXIfEl74NrTMHiRImnxY9eW+aGBMqUg0lrGLBwIDZylhrVcM0Su0k/Eh2KbTUmet2gYJ1w3QVkK0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=AfdgZwhh; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="AfdgZwhh" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-486ff201041so32732465e9.1 for ; Tue, 24 Mar 2026 04:42:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1774352541; x=1774957341; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:organization :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=esc67us1UIomEqAcLAINh+D2RrHyu6uD2oj798DuCUc=; b=AfdgZwhhHfXOtrXhS7F+7RnFd6Yq8q61WwxLGC9Vkx2YoRn37+UJzR0p39aSetr/0C e2Wz7ikKtbhSBJa4X/RH/wfVrKAcYCrRiSLf0AE4NqRGHXMRW2MaytNdM5IYzapSN+7Y YvFm/Ht8XjjzziAo8JOdaK+/9bWCnWApCi1waL+4pHlyis+F4bSoMkt3WEGaB9bnTQNK pSv6EXLDbVeFrEUy5RPeJe4AjYF665CnQj9HkriloN5hClKpj0xbjv2499H6M9uzKDGm jGlP2gKCcNhIxS7cBRZvjJyxRyz2rFeHgaao67oq6H9vQyxWVD1v8PDesweEZVdDKWYV BCkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774352541; x=1774957341; h=mime-version:user-agent:content-transfer-encoding:organization :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=esc67us1UIomEqAcLAINh+D2RrHyu6uD2oj798DuCUc=; b=b/Z36PBWZqmjVdThMNY5DJ1iZbBvrmT9OS+2bZvn97EvGWGYo7qr/NdmYaQ/iMM7VZ SSSH08Nt1NhowYanmh+U5RKodQHwJecx0AuGBNmdO/9whqQ89XaMV0if2dDQJEi0axVH t9iEF8n2nWK9h9OEPWL9XMH1Vanjke6zmVCbgce8rQYL0Ih4Tbhp3iJPMIoirDmfoRau QCY8BcfjbHclIJV/k9rOALFrChyl69twuSemxiaOehLK9SWbgJmm8tc9KkMvByVJuwJN MAvNDPw+iApQ9+d5mOYdB9ZLpTcoCjq2qCzNUaO9zec9bRArc4I0de/dcybZGsGP7M0D 5E6g== X-Forwarded-Encrypted: i=1; AJvYcCX65PKrL1YmQFzjASBdTkZUyBWx/n7qcWNE6tOHSfPXv5F9+si6bUC2+Ky0gnpbwjMpIRrPlwa9w5c6n1w=@vger.kernel.org X-Gm-Message-State: AOJu0YwY9RmNJ/xb4lZJUMWOJ1dOG6NfLpjeu6mA7CjYopM7rGFvTyEV yZ29ekTFmM4Wu8/yAezIWn/FhzSihRxgblxtntG5Pa6Wd7ezcqmpSvjHue41BUNJMsY= X-Gm-Gg: ATEYQzzZ/zEQWBgo5beDG5DLInHJOdgzDtgK2YL3OCKi2mlH+VWURFpjUwY/IQ2ofo+ u7n7ymOs9BiP1HWDaSjDSFrKpiT/qeIRwGOR1lVQ8lR2nToM+pwPZEp8vG2MqiNaNdkCWZEowoe gmIMj354jjZPbDIJDAeac4EOXqN7OGJKSoyyX6csEYmeWQGYwjQskNwobSKEElMhmijsJwEh6x4 q1jRCr3JDlTRk854hvJ6ePSptQ+MYgDjLB5s1FilhnLOuHJsNmsOUzLk8pUGCi7c5rwXAE8zIz9 Qj7swtXtGUP8aXl1ajln28+RYBIyisNP9aecNwrJ8Jlm5Ce8lCyQRoBmCDZQU9B1B9I9Bx8blH9 nmd+IXDZR1w9oRtznG/5EkVC9Cgv4bn3aRO8FpfsVRLRjVNtrmZHou1WCbjUf3UwobPxHI2mawo X9fzT4qsw= X-Received: by 2002:a05:600c:3514:b0:483:a27e:6706 with SMTP id 5b1f17b1804b1-486fedb54cdmr221400105e9.9.1774352541482; Tue, 24 Mar 2026 04:42:21 -0700 (PDT) Received: from [10.76.209.150] ([151.35.203.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4870f66f309sm30303835e9.0.2026.03.24.04.42.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 04:42:21 -0700 (PDT) Message-ID: <46a937ffd470d190b8e7da2bfc78dbbb7ecda94c.camel@baylibre.com> Subject: Re: [PATCH v8 2/6] iio: Replace 'sign' field with union in struct iio_scan_type From: Francesco Lavra To: Andy Shevchenko Cc: David Lechner , Jonathan Corbet , Shuah Khan , Jonathan Cameron , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Date: Tue, 24 Mar 2026 12:42:19 +0100 In-Reply-To: References: <20260317150316.3878107-1-flavra@baylibre.com> <20260317150401.3878294-1-flavra@baylibre.com> <4723284d-1e18-4a13-9ec1-878220af257e@baylibre.com> <5c780b1be8a64f7862a421db5a1f5be861cb197c.camel@baylibre.com> Organization: BayLibre Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-03-24 at 13:04 +0200, Andy Shevchenko wrote: > On Mon, Mar 23, 2026 at 06:37:38PM +0100, Francesco Lavra wrote: > > On Mon, 2026-03-23 at 18:49 +0200, Andy Shevchenko wrote: > > > On Mon, Mar 23, 2026 at 05:04:10PM +0100, Francesco Lavra wrote: > > > > On Sat, 2026-03-21 at 12:22 -0500, David Lechner wrote: > > > > > On 3/17/26 10:04 AM, Francesco Lavra wrote: >=20 > ... >=20 > > > > > > + * @IIO_SCAN_FORMAT_SIGNED_INT: Signed integer (two's > > > > > > complement). > > > > > > + * @IIO_SCAN_FORMAT_UNSIGNED_INT: Unsigned integer. > > >=20 > > > > > We could make this proper kernel doc format with one comment per > > > > > macro. > > > >=20 > > > > Actually, a set of related #defines can be documented with a single > > > > comment. I see a few examples doing that in > > > > include/linux/gfp_types.h > > > > and > > > > include/linux/fpga/fpga-mgr.h > > > >=20 > > > > > > +#define IIO_SCAN_FORMAT_SIGNED_INT=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0's' > > > > > > +#define IIO_SCAN_FORMAT_UNSIGNED_INT=C2=A0=C2=A0=C2=A0'u' > > >=20 > > > ...or use enum > > >=20 > > > /** > > > =C2=A0* ...kernel-doc for enum... > > > =C2=A0*/ > > > enum { > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0IIO_SCAN_FORMAT_SIGNE= D_INT =3D 's', > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0IIO_SCAN_FORMAT_UNSIG= NED_INT =3D 'u', > > > }; > >=20 > > There is no standard kernel-doc format for anonymous enums. >=20 > What do you mean? We have such in kernel, for example, > drivers/pinctrl/intel/pinctrl-intel.c. The kernel-doc guidelines at Documentation/doc-guide/kernel-doc.rst, in the section that describe structure, union, and enumeration documentation, include the name of the struct in the example, so I thought they wouldn't apply to anonymous types. But now I see that anonymous enum comments are processed just fine by the kernel-doc tool. Anyway, in v9 I switched to one comment per macro, as suggested by David.