From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB5FD2749D3 for ; Fri, 19 Dec 2025 02:05:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766109916; cv=none; b=DGQ22vWF4EJx2d4/X0EBX7aOwfkMU108RpYLulmAL65uikA9N2iqD4LL1y29AY1XH/kc2yvCQfN8iV6Dd/cDrc6tz51RbFL8xw7YiyXzOiU+/VD3nh37rPv7qFRIzRWWo1lGZDA6A+Cr2iY8ApPDsKiwRNSjbA/6TxBDNHmHAxM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766109916; c=relaxed/simple; bh=fI+95ZOjKY3yfRQ+VZLRoxX/kKmxmxLpPVnrsV75VaU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DrvSdCObLDANIPqIOGI9tm39ir7BkSs8bQtMuBm1y4WwaSpsnljXW0pcjRXAzwXK1Gyro1LoFZ+UQW0DYg4FDOUeSpSQKbO4B+hGBcY7tTaBD0Vv8qdMXLi5XFqSzBisUuacEli9vI65tNfhDYbvv45OEn+NYY9pGuWPUXeHJYo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=L2sWY4AK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iBSZ/fN6; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="L2sWY4AK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iBSZ/fN6" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BILlGCa3139387 for ; Fri, 19 Dec 2025 02:05:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= p+KDl2G72vBzBLF/+z3TjDQ4EH3DJQNpwuc62txgdek=; b=L2sWY4AKIxkhFoEQ BXtNdaJ2lVg0sWy6UgMl9pi/9zGZhKa2rARZq66DjSyGKcwXXuy/3HUJRkMCQyxO rfnJIzCm13yDZyQJWZ7jnR9R2pm2K0cDdx+rhxJIoO5DMv1lQ/WL4MbKfg1pNSvV rW3HhcRkOMUB6p2I8XIwCKKFFcEFSH7SzSXKTKHcw8bdf0d7jYoRi0AEhm5n3UDd 5wZVq6xEosWKHkZg944LRNQZ549il2KxlVDtdJt/DqXYavwSIwaad6hVEwKqO265 l1BC+VOKZBDtoV62nwAxoDou4I2art9MQjSwaci2UW3/gGwqMjB/kUwkw0eycq8S LFL/Eg== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b4r2d8ts0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Dec 2025 02:05:13 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-34c704d5d15so2446371a91.1 for ; Thu, 18 Dec 2025 18:05:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766109912; x=1766714712; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=p+KDl2G72vBzBLF/+z3TjDQ4EH3DJQNpwuc62txgdek=; b=iBSZ/fN6FGfDdHJZDgquKAZ1Eg2Bi1rYb+NqMnwCr3/0YnnpSu9v1yvGtkNWTmHD7Y YQe4V5zfd7MAE2E+9kfxww0hTUMKn0ppwC9ej4iv95E1K7SCGkP9CXqTs7dG5RFHpI01 NgGGVk9SbAox5hFZMWBr8oLHhE4sDAgr0dJSqZiy4BvzFn5Sg8o+aT24S3fZ12zsA90j 9B1I8x8Ucflf0UaWPzTgQGA3mk2mnx30JZPTtLrJ3711zFpvpVBcEEX3qBp+lwb33j+o Lc5uf5eY7v3V0dX1trOAdRVpSfNvGRYopYSFhmIRGw0UJ+rGBF9BmA5PFrIXqx/DmIHr TK4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766109912; x=1766714712; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=p+KDl2G72vBzBLF/+z3TjDQ4EH3DJQNpwuc62txgdek=; b=P98HHmvnOyD8syaVXotxjTI08xUjVoYxVSpXKGt9B5SUyBpRG604UCXENXQlYpIAoG Qn1aG/nYioUHHm4cwztBXQP0KsW3zOtFVcl0ngwUOkUyX4IxMhomX3hKnNKVOd1SzSaV R0X4Ve6y+CbWjJ7KxdzGGv1qsM5PMSR1/xbRlfbra6dSzMCAco/pyHeny/w6Ts6uslyJ 41vkAZvBO3CTO83pbwG+dDcApVthTOnP5dURr7w5WwsEs6nGzxa2co0S8tCVB2mRP7px Hb//Qejbp03F8ifWF5kZLTU2ZYCorIW7WMbgymuctr8IXQZGAhOVKicrgwPCTV+sMGyG X2Bw== X-Forwarded-Encrypted: i=1; AJvYcCVHz5huqmX2Yw7jTw09v3haDSd3d3Dp81jWjdao93Xa5/jyjfFB5N07sBxu+GCvLzHf57NqwDs8RgfJVeI=@vger.kernel.org X-Gm-Message-State: AOJu0Yyyoi4PyJCvNIny7eiAeWkHMd4aFWbxOwy29OvxcC3iBtilZzks LyYzMGF1Gj2BOObjy+TgDcFOrKYnNU6+W2S6ER6FwsYmsYcZlqu1WG89J90RWXkTPYrv3shSTNO 65nJ00O5R/Pfar9XvqFQVawK7NGUGV4ACiZfRhl8Ab56+lD88OmW8nRFUYCcERihS2Iw= X-Gm-Gg: AY/fxX6OMkTl1/hMmNZ9t0LqP5go6L+3t4ZMG8q5Xx+1q0Sch5moVWwdAvJux3Y/DlY RNm5xwRPAaKNyWWgfJhEGj19Mvg586ggfJOexGUJND0MM/iQ5OGsfPL4zyiS+4jwJVikVa5T/tw dwTIShYOHkc/gEDDZ9J8gedNW80ABpdxIPsduoryj36E7NVCMO9Igzcs1Dk3xcuwNBx4fcxU0zA JkRL8VkHm/uX7AbGGcKoRzF7eCVUshFClrGUjjEyjuJzrJDaAhwOtRxm+TYB52G3ZkEK0vwqqii 5VtQwP4PtzHY5kG22v3WyblmZBwtGOfRzoTPRu/XZP5TKrRgPLzFt5yHwrSrZmaLjFHp/n1LtfB PXplVC/adgvt8BpaHWUukJJogPNAKTY8N1L/+dFRFJpmboDb6YbEGXMtQPMrkTtuLq/9sVWkBvA Y= X-Received: by 2002:a05:6a21:6d9e:b0:35b:b97f:7471 with SMTP id adf61e73a8af0-376a75ef388mr1339449637.4.1766109911844; Thu, 18 Dec 2025 18:05:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IENweru9eTuM8/f/hzvfINoPNb14Iccv5nkKoLSJUQfoBqv5hSIXuuu8B1IOuUhk1nYq6XY7Q== X-Received: by 2002:a05:6a21:6d9e:b0:35b:b97f:7471 with SMTP id adf61e73a8af0-376a75ef388mr1339414637.4.1766109911303; Thu, 18 Dec 2025 18:05:11 -0800 (PST) Received: from [10.133.33.174] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c1e7961b4d0sm516718a12.5.2025.12.18.18.05.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Dec 2025 18:05:10 -0800 (PST) Message-ID: <46afd4f6-f287-4d19-bc68-f2f6eac36e6a@oss.qualcomm.com> Date: Fri, 19 Dec 2025 10:05:03 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 5/8] dt-bindings: arm: add an interrupt property for Coresight CTCU To: Suzuki K Poulose , Krzysztof Kozlowski , Rob Herring Cc: Mike Leach , James Clark , Alexander Shishkin , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Mao Jinlong , Bjorn Andersson , Konrad Dybcio , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20251211-enable-byte-cntr-for-ctcu-v8-0-3e12ff313191@oss.qualcomm.com> <20251211-enable-byte-cntr-for-ctcu-v8-5-3e12ff313191@oss.qualcomm.com> <20251211133723.GA859302-robh@kernel.org> <2db74a3e-4aeb-4e87-9fe8-5c9693bfb67c@arm.com> Content-Language: en-US From: Jie Gan In-Reply-To: <2db74a3e-4aeb-4e87-9fe8-5c9693bfb67c@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=AcG83nXG c=1 sm=1 tr=0 ts=6944b2d9 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=aQ7FMZSyy468aWolCDYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE5MDAxNSBTYWx0ZWRfXykdVyFVzAWv2 Q/fWAj+BJ2ZLNQ9E33vN6gnySF/CNYKcRt80Mas1uRgLLaFgyC2myiWLJiIUrJTl1pohhfoGzth iNJBh1gsYx1mMlkXm2WKD3f9UZg37hIYC5PwdxLdf53OnVsG/0fHWOOL9p5MJDk1JS7fF3Usp7s kldfIJMK495ox9o9/mT2gjVhqymJZMYY/0P1onCld7WigQouwZjWMTLp/M08ywUtDbfh98WCNBc lABRgYylao9qXcskKKg/C5gh/3N7srXd53pVghShH1wikPPplQeKXxmbu8yRVSQb1genViPobIY +Gjr6aRQBJm7u2MN5qzDqQCt4DCnrK3IxmDZP5061uTLLvEl6+INt8/RvkzgvzdP1jkFFWL99hq XX23UiILDiLh9PdCX7HDWC6AS7ojTwxUichwNjM+bh8iYosXBoRh8G27nuBz9hLdc7jiLjYxxHx XBSei00LUO+8iTyZuWA== X-Proofpoint-GUID: wjBWkPOTMFNyHvIK0n0PaFL4lqW863NF X-Proofpoint-ORIG-GUID: wjBWkPOTMFNyHvIK0n0PaFL4lqW863NF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-19_01,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 adultscore=0 phishscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512190015 On 12/19/2025 7:19 AM, Suzuki K Poulose wrote: > On 18/12/2025 10:17, Krzysztof Kozlowski wrote: >> On 12/12/2025 02:12, Jie Gan wrote: >>> >>> >>> On 12/11/2025 9:37 PM, Rob Herring wrote: >>>> On Thu, Dec 11, 2025 at 02:10:44PM +0800, Jie Gan wrote: >>>>> Add an interrupt property to CTCU device. The interrupt will be >>>>> triggered >>>>> when the data size in the ETR buffer exceeds the threshold of the >>>>> BYTECNTRVAL register. Programming a threshold in the BYTECNTRVAL >>>>> register >>>>> of CTCU device will enable the interrupt. >>>>> >>>>> Acked-by: Krzysztof Kozlowski >>>>> Reviewed-by: Mike Leach >>>>> Signed-off-by: Jie Gan >>>>> --- >>>>>    .../devicetree/bindings/arm/qcom,coresight-ctcu.yaml    | 17 +++ >>>>> ++++++++++++++ >>>>>    1 file changed, 17 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight- >>>>> ctcu.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight- >>>>> ctcu.yaml >>>>> index c969c16c21ef..90f88cc6cd3e 100644 >>>>> --- a/Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml >>>>> +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml >>>>> @@ -39,6 +39,16 @@ properties: >>>>>        items: >>>>>          - const: apb >>>>> +  interrupts: >>>>> +    items: >>>>> +      - description: Byte cntr interrupt for the first etr device >>>>> +      - description: Byte cntr interrupt for the second etr device > > This is really vague. How do you define first vs second ? Probe order ? > No way. This must be the "port" number to which the ETR is connected > to the CTCU. IIUC, there is a config area for each ETR (e.g., trace id > filter) connected to the CTCU. I was under the assumption that they > are identified as "ports" (input ports). I don't really understand how > this interrupt mapping works now. Please explain it clearly. > Sorry for the misunderstanding. Each ETR device should have its own interrupt line and an IRQ register within the CTCU device, as defined by the specification. In existing projects, the maximum supported number of ETR devices is 2. Each interrupt is directly mapped to a specific ETR device, for example: tmc@1000 → interrupt line 0 tmc@1001 → interrupt line 1 The suggestion to identify devices by ‘ports’ is much clearer than my previous explanation, as it explicitly shows which device is connected to which port. >>>>> + >>>>> +  interrupt-names: >>>>> +    items: >>>>> +      - const: etrirq0 >>>>> +      - const: etrirq1 >>>> >>>> Names are kind of pointless when it is just foo. >>> >>> Hi Rob, >>> >>> I was naming them as etr0/etr1. Are these names acceptable? >> >> Obviously irq is redundant, but how does etr0 solves the problem of >> calling it foo0? >> >> I don't think you really read Rob's comment. >> >>> The interrupts are assigned exclusively to a specific ETR device. >>> >>> But Suzuki is concerned that this might cause confusion because the ETR >>> device is named randomly in the driver. Suzuki suggested using ‘port-0’ >>> and ‘port-1’ and would also like to hear your feedback on these names. >> >> There is no confusion here. Writing bindings luckily clarifies this what >> the indices in the array mean. > > The point is there are "n" interrupts. Question is, could there be more > devices(ETRs) connected to the CTCU than "n". > > e.g., Lets CTCU can control upto 4 ETRs and on a particular system, the > > TMC-ETR0 -> CTCU-Port0 > > TMC-ETR1 -> CTCU-Port2 > TMC-ETR2 -> CTCU-Port3 > > Now, how many interrupts are described in the DT ? How do we map which > interrupts correspond to the CTCU-Portn. (Finding the TMC-ETRx back > from the port is possible, with the topology). > Got your point and it's much clearer. > This is what I raised in the previous version. Again, happy to hear > if there is a standard way to describe the interrupts. > > Suzuki > > >> >>> >>> Usually, the probe sequence follows the order of the addresses. In our >>> specification, ‘ETR0’ is always probed before ‘ETR1’ because its address >>> is lower. >> >> How is this even relevant? You are answering to something completely >> different, so I don't think you really tried to understand review. >> My previous explanation was definitely unclear. As Suzuki suggested, mapping the interrupt to the port number (to identify the relevant device based on topology) makes sense and provides a much easier way to understand the relationship between the interrupt and the ETR device. So with the suggestion, here is the new description about the interrupts: interrupts: items: - description: Interrupt for the ETR device connected to in-port0. - description: Interrupt for the ETR device connected to in-port1. interrupt-names: items: - const: port0 - const: port1 Thanks, Jie >> >> >> Best regards, >> Krzysztof >