From: Oliver Neukum <oneukum@suse.com>
To: Marc Zyngier <maz@kernel.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] usb: cdc-acm: Restore CAP_BRK functionnality to CH343
Date: Mon, 2 Mar 2026 11:27:23 +0100 [thread overview]
Message-ID: <46b003fb-c3b2-4ad6-a3a5-c73e2e248a26@suse.com> (raw)
In-Reply-To: <20260301124440.1192752-1-maz@kernel.org>
On 01.03.26 13:44, Marc Zyngier wrote:
> The CH343 USB/serial adapter is as buggy as it is popular (very).
> One of its quirks is that despite being capable of signalling a
> BREAK condition, it doesn't advertise it.
>
> This used to work nonetheless until 66aad7d8d3ec5 ("usb: cdc-acm:
> return correct error code on unsupported break") applied some
> reasonable restrictions, preventing breaks from being emitted on
> devices that do not advertise CAP_BRK.
>
> Add a quirk for this particular device, so that breaks can still
> be produced on some of my machines attached to my console server.
>
> Fixes: 66aad7d8d3ec5 ("usb: cdc-acm: return correct error code on unsupported break")
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> Cc: stable@vger.kernel.org
> Cc: Oliver Neukum <oneukum@suse.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Oliver Neukum <oneukum@suse.com>
prev parent reply other threads:[~2026-03-02 10:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 12:44 Marc Zyngier
2026-03-02 10:27 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46b003fb-c3b2-4ad6-a3a5-c73e2e248a26@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maz@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®