From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15B80C433E0 for ; Wed, 23 Dec 2020 20:15:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE265223E4 for ; Wed, 23 Dec 2020 20:15:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728809AbgLWUPE (ORCPT ); Wed, 23 Dec 2020 15:15:04 -0500 Received: from smtprelay0221.hostedemail.com ([216.40.44.221]:48888 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727671AbgLWUPD (ORCPT ); Wed, 23 Dec 2020 15:15:03 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id B0E7F180A7FF4; Wed, 23 Dec 2020 20:14:22 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: table59_3c14bbe2746b X-Filterd-Recvd-Size: 3703 Received: from XPS-9350.home (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf01.hostedemail.com (Postfix) with ESMTPA; Wed, 23 Dec 2020 20:14:21 +0000 (UTC) Message-ID: <46b3bba25d09e89471048ae119a2c3b460b6b7be.camel@perches.com> Subject: Re: [PATCH] amd-xgbe: remove h from printk format specifier From: Joe Perches To: trix@redhat.com, thomas.lendacky@amd.com, davem@davemloft.net, kuba@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 23 Dec 2020 12:14:20 -0800 In-Reply-To: <20201223194345.125205-1-trix@redhat.com> References: <20201223194345.125205-1-trix@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-12-23 at 11:43 -0800, trix@redhat.com wrote: > From: Tom Rix > > This change fixes the checkpatch warning described in this commit > commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") > > Standard integer promotion is already done and %hx and %hhx is useless > so do not encourage the use of %hh[xudi] or %h[xudi]. Why only xgbe-ethtool? Perhaps your script only converts direct uses of functions marked with __printf and not any uses of the same functions via macros. $ git grep -P '%[\w\d\.]*h\w' drivers/net/ethernet/amd/xgbe/ drivers/net/ethernet/amd/xgbe/xgbe-dcb.c: "TC%u: tx_bw=%hhu, rx_bw=%hhu, tsa=%hhu\n", i, drivers/net/ethernet/amd/xgbe/xgbe-dcb.c: netif_dbg(pdata, drv, netdev, "PRIO%u: TC=%hhu\n", i, drivers/net/ethernet/amd/xgbe/xgbe-dcb.c: "unsupported TSA algorithm (%hhu)\n", drivers/net/ethernet/amd/xgbe/xgbe-dcb.c: "cap=%hhu, en=%#hhx, mbc=%hhu, delay=%hhu\n", drivers/net/ethernet/amd/xgbe/xgbe-dev.c: netif_dbg(pdata, drv, pdata->netdev, "VXLAN tunnel id set to %hx\n", drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c: netdev_err(netdev, "invalid phy address %hhu\n", drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c: netdev_err(netdev, "unsupported autoneg %hhu\n", drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c: netdev_err(netdev, "unsupported duplex %hhu\n", > > Signed-off-by: Tom Rix > --- >  drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c | 6 +++--- >  1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c b/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c > index 61f39a0e04f9..3c18f26bf2a5 100644 > --- a/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c > +++ b/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c > @@ -339,14 +339,14 @@ static int xgbe_set_link_ksettings(struct net_device *netdev, >   speed = cmd->base.speed; >   > >   if (cmd->base.phy_address != pdata->phy.address) { > - netdev_err(netdev, "invalid phy address %hhu\n", > + netdev_err(netdev, "invalid phy address %u\n", >   cmd->base.phy_address); >   return -EINVAL; >   } >   > >   if ((cmd->base.autoneg != AUTONEG_ENABLE) && >   (cmd->base.autoneg != AUTONEG_DISABLE)) { > - netdev_err(netdev, "unsupported autoneg %hhu\n", > + netdev_err(netdev, "unsupported autoneg %u\n", >   cmd->base.autoneg); >   return -EINVAL; >   } > @@ -358,7 +358,7 @@ static int xgbe_set_link_ksettings(struct net_device *netdev, >   } >   > >   if (cmd->base.duplex != DUPLEX_FULL) { > - netdev_err(netdev, "unsupported duplex %hhu\n", > + netdev_err(netdev, "unsupported duplex %u\n", >   cmd->base.duplex); >   return -EINVAL; >   }