From: Chanwoo Choi <cwchoi00@gmail.com>
To: Yassine Oudjana <y.oudjana@protonmail.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Rob Herring <robh+dt@kernel.org>
Cc: Michael Auchter <michael.auchter@ni.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 0/3] extcon: usbc-tusb320: Initial TUSB320L support
Date: Thu, 16 Sep 2021 02:22:42 +0900 [thread overview]
Message-ID: <46b969d0-9039-67e4-53f9-c461718ff089@gmail.com> (raw)
In-Reply-To: <20210901161339.223973-1-y.oudjana@protonmail.com>
On 21. 9. 2. 오전 1:13, Yassine Oudjana wrote:
> The TUSB320L is a newer chip with additional features. It is close enough to TUSB320 so it works
> to some extent out-of-the-box, but for some reason it can start in UFP mode which is not desirable.
>
> This series adds support for reset and mode setting for both chips, and does that while probing
> to ensure the chip starts with the default mode of following the PORT pin.
>
> Changes since v3:
> - Remove unused tusb_modes.
> - Remove extra blank line.
> Changes since v2:
> - Read state before setting default mode, then update it again after resetting.
> - Remove mode tracing from irq handler
> - Add a delay after reset to handle tSOFT_RESET
> - Use a separate mode setting function for each of TUSB320 and TUSB320L.
> Changes since v1:
> - Split first patch into two patches, one adding support for mode setting and reset on TUSB320,
> and the other adding support for TUSB320L.
> - Fix dt_binding_check warning:
> ../Documentation/devicetree/bindings/extcon/extcon-usbc-tusb320.yaml:15:6: [warning] wrong indentation: expected 6 but found 5 (indentation)
>
> Yassine Oudjana (3):
> extcon: usbc-tusb320: Add support for mode setting and reset
> extcon: usbc-tusb320: Add support for TUSB320L
> dt-bindings: extcon: usbc-tusb320: Add TUSB320L compatible string
>
> .../bindings/extcon/extcon-usbc-tusb320.yaml | 4 +-
> drivers/extcon/extcon-usbc-tusb320.c | 156 +++++++++++++++++-
> 2 files changed, 154 insertions(+), 6 deletions(-)
>
Applied them. Thanks.
--
Best Regards,
Samsung Electronics
Chanwoo Choi
prev parent reply other threads:[~2021-09-15 17:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 16:13 Yassine Oudjana
2021-09-01 16:14 ` [PATCH v4 1/3] extcon: usbc-tusb320: Add support for mode setting and reset Yassine Oudjana
2021-09-01 16:14 ` [PATCH v4 2/3] extcon: usbc-tusb320: Add support for TUSB320L Yassine Oudjana
2021-09-01 16:14 ` [PATCH v4 3/3] dt-bindings: extcon: usbc-tusb320: Add TUSB320L compatible string Yassine Oudjana
2021-09-15 17:22 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46b969d0-9039-67e4-53f9-c461718ff089@gmail.com \
--to=cwchoi00@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.auchter@ni.com \
--cc=myungjoo.ham@samsung.com \
--cc=robh+dt@kernel.org \
--cc=y.oudjana@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®