Re: [PATCH v5 1/2] dt-bindings: phy: Add USB PHY support for Intel LGM SoC

["Ramuthevar, Vadivel MuruganX" <vadivel.muruganx.ramuthevar@linux.intel.com>]

Hi Rob,

On 13/7/2020 11:08 pm, Rob Herring wrote:
> On Mon, Jul 13, 2020 at 04:54:52PM +0800, Ramuthevar,Vadivel MuruganX wrote:
>> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>>
>> Add the dt-schema to support USB PHY on Intel LGM SoC
>>
>> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> ---
>>   .../devicetree/bindings/phy/intel,lgm-usb-phy.yaml | 53 ++++++++++++++++++++++
>>   1 file changed, 53 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/phy/intel,lgm-usb-phy.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/phy/intel,lgm-usb-phy.yaml b/Documentation/devicetree/bindings/phy/intel,lgm-usb-phy.yaml
>> new file mode 100644
>> index 000000000000..0fc76cd23774
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/phy/intel,lgm-usb-phy.yaml
>> @@ -0,0 +1,53 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/usb/intel,lgm-usb-phy.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Intel LGM USB PHY Device Tree Bindings
>> +
>> +maintainers:
>> +  - Vadivel Murugan Ramuthevar <vadivel.muruganx.ramuthevar@linux.intel.com>
>> +
>> +properties:
>> +  compatible:
>> +    const: intel,lgm-usb-phy
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    maxItems: 1
>> +
>> +  resets:
>> +    items:
>> +      - description: USB PHY and Host controller reset
>> +      - description: APB BUS reset
>> +      - description: General Hardware reset
>> +
>> +  reset-names:
>> +    items:
>> +      - const: phy
>> +      - const: apb
>> +      - const: phy31
>> +
>> +required:
>> +  - compatible
>> +  - clocks
>> +  - reg
>> +  - resets
>> +  - reset-names
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    usb_phy: usb_phy@e7e00000 {
> 
> usb-phy@...
Noted, will updated.
Thanks!
> 
>> +        compatible = "intel,lgm-usb-phy";
>> +        reg = <0xe7e00000 0x10000>;
>> +        clocks = <&cgu0 153>;
>> +        resets = <&rcu 0x70 0x24>,
>> +                 <&rcu 0x70 0x26>,
>> +                 <&rcu 0x70 0x28>;
>> +        reset-names = "phy", "apb", "phy31";
>> +    };
>> -- 
>> 2.11.0
>>