mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ma, Jun" <majun@amd.com>
To: Kalle Valo <kvalo@kernel.org>,
	Mario Limonciello <mario.limonciello@amd.com>
Cc: majun@amd.com, Johannes Berg <johannes@sipsolutions.net>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	"open list:MAC80211" <linux-wireless@vger.kernel.org>,
	"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	Jun Ma <Jun.ma2@amd.com>
Subject: Re: [PATCH] wifi: mac80211: Use subsystem appropriate debug call
Date: Thu, 21 Dec 2023 13:57:50 +0800	[thread overview]
Message-ID: <46bf6ed5-31f6-48f4-b63d-f532e163204e@amd.com> (raw)
In-Reply-To: <87frzzsfoi.fsf@kernel.org>

Hi,

On 12/18/2023 11:17 PM, Kalle Valo wrote:
> Mario Limonciello <mario.limonciello@amd.com> writes:
> 
>> mac80211 doesn't use dev_dbg() but instead various macros from
>> net/mac80211/debug.h. Adjust wbrf code to use wiphy_dbg() instead.
>>
>> Cc: Jun Ma <Jun.ma2@amd.com>
>> Reported-by: kvalo@kernel.org
>> Closes:
>> https://lore.kernel.org/amd-gfx/8bd60010-7534-4c22-9337-c4219946d8d6@amd.com/T/#mfe2f29372c45130d27745912faf33d9f7ce50118
>> Fixes: d34be4310cbe ("wifi: mac80211: Add support for WBRF features")
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>>  net/mac80211/wbrf.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/net/mac80211/wbrf.c b/net/mac80211/wbrf.c
>> index a05c5b971789..12c23e14f884 100644
>> --- a/net/mac80211/wbrf.c
>> +++ b/net/mac80211/wbrf.c
>> @@ -23,8 +23,8 @@ void ieee80211_check_wbrf_support(struct ieee80211_local *local)
>>  		return;
>>  
>>  	local->wbrf_supported = acpi_amd_wbrf_supported_producer(dev);
>> -	dev_dbg(dev, "WBRF is %s supported\n",
>> -		local->wbrf_supported ? "" : "not");
>> +	wiphy_dbg(wiphy, "WBRF is %s supported\n",
>> +		  local->wbrf_supported ? "" : "not");
>>  }
> 
> This won't work, I still see the debug message:
> 
> [  333.765867] ieee80211 phy0: WBRF is not supported
> 
> The issue seems to be that mac80211 defines DEBUG in
> net/mac80211/Makefile:
> 
> ccflags-y += -DDEBUG
> 
> That -DDEBUG should be cleaned up, but I think separately. It's just
> that I cannot come up with any good proposal, all the macros in
> net/mac80211/debug.h require sdata and we don't have that in this stage.
> Any ideas?

I will submit a patch that only compiles wbrf.c when CONFIG_AMD_WBRF=y

Regards,
Ma Jun


> 

  reply	other threads:[~2023-12-21  5:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-15 14:54 Mario Limonciello
2023-12-18 15:17 ` Kalle Valo
2023-12-21  5:57   ` Ma, Jun [this message]
2023-12-21  6:38     ` Kalle Valo
2023-12-30  2:42       ` Mario Limonciello
2024-01-11 10:58         ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46bf6ed5-31f6-48f4-b63d-f532e163204e@amd.com \
    --to=majun@amd.com \
    --cc=Jun.ma2@amd.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=johannes@sipsolutions.net \
    --cc=kuba@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®