From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D18D7C433DB for ; Wed, 23 Dec 2020 20:54:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 86096223E4 for ; Wed, 23 Dec 2020 20:54:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728911AbgLWUyd (ORCPT ); Wed, 23 Dec 2020 15:54:33 -0500 Received: from smtprelay0229.hostedemail.com ([216.40.44.229]:47208 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726650AbgLWUyc (ORCPT ); Wed, 23 Dec 2020 15:54:32 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id EC02F18015400; Wed, 23 Dec 2020 20:53:50 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: toys42_2915b912746b X-Filterd-Recvd-Size: 4983 Received: from XPS-9350.home (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf03.hostedemail.com (Postfix) with ESMTPA; Wed, 23 Dec 2020 20:53:49 +0000 (UTC) Message-ID: <46c0d5336f079e9f889af711a478d189313d278d.camel@perches.com> Subject: Re: [PATCH] amd-xgbe: remove h from printk format specifier From: Joe Perches To: Tom Rix , thomas.lendacky@amd.com, davem@davemloft.net, kuba@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 23 Dec 2020 12:53:48 -0800 In-Reply-To: References: <20201223194345.125205-1-trix@redhat.com> <46b3bba25d09e89471048ae119a2c3b460b6b7be.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-12-23 at 12:33 -0800, Tom Rix wrote: > On 12/23/20 12:14 PM, Joe Perches wrote: > > On Wed, 2020-12-23 at 11:43 -0800, trix@redhat.com wrote: > > > From: Tom Rix > > > > > > This change fixes the checkpatch warning described in this commit > > > commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") > > > > > > Standard integer promotion is already done and %hx and %hhx is useless > > > so do not encourage the use of %hh[xudi] or %h[xudi]. > > Why only xgbe-ethtool? > > > > Perhaps your script only converts direct uses of functions > > marked with __printf and not any uses of the same functions > > via macros. > > The fixer may have issues. Perhaps until the fixer is fixed, it'd be more complete coverage to use checkpatch like: $ git ls-files | \ xargs ./scripts/checkpatch.pl -f --fix-inplace --types=unnecessary_modifier e.g.: $ git ls-files drivers/net/ethernet/amd/xgbe | \ xargs ./scripts/checkpatch.pl -f --fix-inplace --types=unnecessary_modifier $ git diff -U0 drivers/net/ethernet/amd/xgbe/ diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-dcb.c b/drivers/net/ethernet/amd/xgbe/xgbe-dcb.c index 895d35639129..dcd2a181d43a 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-dcb.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-dcb.c @@ -155 +155 @@ static int xgbe_dcb_ieee_setets(struct net_device *netdev, - "TC%u: tx_bw=%hhu, rx_bw=%hhu, tsa=%hhu\n", i, + "TC%u: tx_bw=%u, rx_bw=%u, tsa=%u\n", i, @@ -158 +158 @@ static int xgbe_dcb_ieee_setets(struct net_device *netdev, - netif_dbg(pdata, drv, netdev, "PRIO%u: TC=%hhu\n", i, + netif_dbg(pdata, drv, netdev, "PRIO%u: TC=%u\n", i, @@ -233 +233 @@ static int xgbe_dcb_ieee_setpfc(struct net_device *netdev, - "cap=%hhu, en=%#hhx, mbc=%hhu, delay=%hhu\n", + "cap=%u, en=%#x, mbc=%u, delay=%u\n", @@ -267 +267 @@ static u8 xgbe_dcb_setdcbx(struct net_device *netdev, u8 dcbx) - netif_dbg(pdata, drv, netdev, "DCBX=%#hhx\n", dcbx); + netif_dbg(pdata, drv, netdev, "DCBX=%#x\n", dcbx); diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c b/drivers/net/ethernet/amd/xgbe/xgbe-dev.c index d5fd49dd25f3..ff0cd94bb91a 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-dev.c @@ -488 +488 @@ static void xgbe_set_vxlan_id(struct xgbe_prv_data *pdata) - netif_dbg(pdata, drv, pdata->netdev, "VXLAN tunnel id set to %hx\n", + netif_dbg(pdata, drv, pdata->netdev, "VXLAN tunnel id set to %x\n", diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c index 2709a2db5657..0ae16bc87833 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c @@ -2781 +2781 @@ void xgbe_print_pkt(struct net_device *netdev, struct sk_buff *skb, bool tx_rx) - netdev_dbg(netdev, "Protocol: %#06hx\n", ntohs(eth->h_proto)); + netdev_dbg(netdev, "Protocol: %#06x\n", ntohs(eth->h_proto)); diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c b/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c index 61f39a0e04f9..3c18f26bf2a5 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c @@ -342 +342 @@ static int xgbe_set_link_ksettings(struct net_device *netdev, - netdev_err(netdev, "invalid phy address %hhu\n", + netdev_err(netdev, "invalid phy address %u\n", @@ -349 +349 @@ static int xgbe_set_link_ksettings(struct net_device *netdev, - netdev_err(netdev, "unsupported autoneg %hhu\n", + netdev_err(netdev, "unsupported autoneg %u\n", @@ -361 +361 @@ static int xgbe_set_link_ksettings(struct net_device *netdev, - netdev_err(netdev, "unsupported duplex %hhu\n", + netdev_err(netdev, "unsupported duplex %u\n",