From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=158.69.130.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795105506; b=hD5fmSum2PBmEZj9NCNKkSyJ6qDX6oLjCq+M2HaPx1F8S/70FC7cD7AqB8+9zIVZDC3B 4LHqZdefAWsmPLatAZbQPfs6+GCymDWJBsr8R8Pz8v+1NTSc9Nq0wFggNQlwAmeTe3qoo TyE7b0SmH/mZ5iS3fWNYLKsOJTMzrVTnqepL6cM22vYb/lHuOqaZw57Qg07FTD3WiDG+H yDW3FfMZtd4bkXlVxYJr5OZuTnNEcbuzlsliJdQho9kAh6LaEZ4zkqhvOyueKh4gq1xa4 kp7SUYShZQDtkb8cNWr7aOYiKHsOBwuz0J5A+9Boephc836Xgsdx8W8vWpuEIsdR92g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795105506; h=DMARC-Filter:DKIM-Signature:Received:From:To:Cc:Subject:Date: Message-Id:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=2GDIvsu7zv8+pf1iUkWvntMzShMjZhVgxoA9fdCxHRA=; b=t4u9ea5OP1RCFYdWgVw4fXUtCamEF156tzD0u3V7zCRTU4IIXeDZOdF2NRgyK71UBEa3 03ACM2x7tyaFB2O1DXm8bra5pNO+Z6lwyOfneh6BJpTFRLoWtH/afhYiLaqi+q+j1gSef bALN8+Tup10WlK/bDY+QyBgg+XNeV/LTMtnhvsluIH8J7GSxmWko97Ntevd9j95b7uVRJ Sq1iex+101ZoVpEUPFf6scWBxjI4VIwbaP6YrEQy+A8IhGQHte1l1BP0mW9C8XlgjGI0y Gd1XcV43SHOCRP7mJ39UqEgrOBRmnMNn8b66TyA3IqUBr6gNWkwlW9yR6b1AyluWYLg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=smtpout1 header.b=q903Dpd1; arc=none smtp.remote-ip=158.69.130.18 Received: from smtpout.efficios.com (smtpout.efficios.com [158.69.130.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48099606A32C; Thu, 19 Nov 2026 16:25:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 48099606A32C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=smtpout1 header.b=q903Dpd1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=smtpout1; t=1795105502; bh=2GDIvsu7zv8+pf1iUkWvntMzShMjZhVgxoA9fdCxHRA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q903Dpd1YnFJ8s9Xgk4FGvQROE/EnMo735/8+nVwWhOj2oiKuiIOWa/q9cgv0E3ln MAW9fSRDTUNSbGbPKhcqauC4NsfJtFHYFS6LsU1j6Nap6JGTNS8xZUAWsumwdkWkgo zsVXmueiqi78HiDNuz5BolGJyZeUnwpi27luNGFLDS0s6SWMFfi8hY7vmQtTw5g9+p ujTlsrdliomuS/SZW+12kbSuUV6CK2/agaarUrWkn0RVT9HmMG/nckaQ/9j4EOW0wq Nh1iHckdsYI87mHbQTogK8vrue5GTRVPc/tQpyF31i2uG16x45iDugGLf2K62RKsf9 8RvsleFuX3r1w== Received: from thinkos.internal.efficios.com (mtl.efficios.com [216.120.195.104]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4jVkMf3Fs2zTnG; Thu, 19 Nov 2026 11:25:02 -0500 (EST) From: Mathieu Desnoyers To: juri.lelli@redhat.com, peterz@infradead.org, mingo@redhat.com, vincent.guittot@linaro.org Cc: Mathieu Desnoyers , tglx@kernel.org, will@kernel.org, boqun@kernel.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, kprateek.nayak@amd.com, luca.abeni@santannapisa.it, mathieu.poirier@linaro.org, longman@redhat.com, ridong.chen@linux.dev, tj@kernel.org, hannes@cmpxchg.org, mkoutny@suse.com, shuah@kernel.org, bigeasy@linutronix.de, clrkwllms@kernel.org, parri.andrea@gmail.com, m.szyprowski@samsung.com, kayracizmeci@gmail.com, weihengqiuu@gmail.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-rt-devel@lists.linux.dev, stable@vger.kernel.org Subject: [RESEND PATCH v4 04/17] sched/deadline: Do not divide by zero active CPUs of a root domain Date: Thu, 19 Nov 2026 11:24:44 -0500 Message-Id: <46cf3d11435498c167e87c1e402c6ab2522f71ab.1795105408.git.mathieu.desnoyers@efficios.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit __dl_sub() and __dl_add() divide by their cpus argument. Most callers pass dl_bw_cpus(), the number of active CPUs of a root domain. That number can be 0, and the division then traps. Commit daec57983670 ("sched/deadline: Reclaim bandwidth not used by dl tasks") added extra_bw, the bandwidth that deadline tasks can reclaim on a runqueue. A change of a root domain's total_bw is spread over the extra_bw of its active CPUs. During hotplug, a CPU sits in the default root domain, which can then have no active CPU. This lasts from the rebuild in sched_cpu_deactivate() to the offline, and from the online to sched_cpu_activate(). A debugfs write to the runtime or period of its fair or ext server divides there. A write of the current value passes admission in the window. In 8-CPU VMs of v7.4-rc2, a loop of such writes oopses at the first offline and online: Oops: divide error: 0000 [#1] SMP NOPTI RIP: 0010:dl_server_apply_params+0x335/0x380 Call Trace: sched_server_write_common.isra.0+0x1c0/0x260 full_proxy_write+0x58/0x90 vfs_write+0xcb/0x550 By reading, two other paths would divide by zero: - inactive_task_timer(), for a task that left SCHED_DEADLINE or died, if its CPU went offline. - sched_setattr(SCHED_DEADLINE) on a task asleep on an offline CPU, with admission control off. Fix this by changing total_bw alone when the root domain has no active CPU. With this patch, the reproducer survives 20 rounds with no warning. Fixes: daec57983670 ("sched/deadline: Reclaim bandwidth not used by dl tasks") Signed-off-by: Mathieu Desnoyers Reviewed-by: Juri Lelli Cc: stable@vger.kernel.org --- kernel/sched/deadline.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index dfae08625342..b614d5fc1a1a 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -189,18 +189,25 @@ void __dl_update(struct dl_bw *dl_b, s64 bw) } } +/* + * Spread a change of total_bw over the extra_bw of the active CPUs of the + * root domain. @cpus is their number. With no active CPU, as can happen + * during CPU hotplug, change total_bw alone. + */ static inline void __dl_sub(struct dl_bw *dl_b, u64 tsk_bw, int cpus) { dl_b->total_bw -= tsk_bw; - __dl_update(dl_b, (s32)tsk_bw / cpus); + if (cpus) + __dl_update(dl_b, (s32)tsk_bw / cpus); } static inline void __dl_add(struct dl_bw *dl_b, u64 tsk_bw, int cpus) { dl_b->total_bw += tsk_bw; - __dl_update(dl_b, -((s32)tsk_bw / cpus)); + if (cpus) + __dl_update(dl_b, -((s32)tsk_bw / cpus)); } static inline bool -- 2.47.3