From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760908AbdAEIo0 (ORCPT ); Thu, 5 Jan 2017 03:44:26 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:48795 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761012AbdAEIoY (ORCPT ); Thu, 5 Jan 2017 03:44:24 -0500 Subject: Re: [PATCH] locking/pvqspinlock: Wait early if vcpu is preempted To: Ingo Molnar , Pan Xinhui References: <1481049850-42610-1-git-send-email-xinhui.pan@linux.vnet.ibm.com> <20170105082324.GF2098@gmail.com> Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, longman@redhat.com From: Pan Xinhui Date: Thu, 5 Jan 2017 16:44:25 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170105082324.GF2098@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17010508-0012-0000-0000-000002006856 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17010508-0013-0000-0000-000006C1F745 Message-Id: <46d0cfa0-888f-648a-b31c-9b760eda3ca2@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-05_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1701050141 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2017/1/5 16:23, Ingo Molnar 写道: > > * Pan Xinhui wrote: > >> If prev node is not in runnig state or its cpu is preempted, we need >> wait early in pv_wait_node. After commit "sched/core: Introduce the >> vcpu_is_preempted(cpu) interface" kernel has knowledge of one vcpu is >> running or not. So lets use it. > > That's not how we reference upstream commits. I had to search the git log the hard > way to figure out that it's commit d9345c65eb79 ... > hi, Ingo Sorry. Such stupid mistake will not happen next time. > Also, once you look at that commit you'll see how sloppy the capitalization in > your changelog is. I fixed that up for all the original commits in the hope of you > learning from those mistakes - but that was last year and the experiment failed. > So sorry, I pay most attention on spelling of words. :( Maybe I rely on the tools of ./scripts/checkpatch.pl too much. I will rewrite the comments and resend this patch. > Thanks, > > Ingo >