From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD09930FC30 for ; Wed, 4 Feb 2026 16:38:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.125.188.122 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770223141; cv=none; b=dKY+04UTY0S7+mYe8nYQtd+1THAf6ohk1wwirvs8tnH+SFiluzSB2kbQZ31OagmQRiAhRIcl5Je11Xo3S6HSKMpylTzOuzL5gv3wEeYr+XMtwNrhH5mgpkz8IczEpHAQucne5LgLRZj+IhjVqgIoXtsEag+X1SclR0euASNFJck= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770223141; c=relaxed/simple; bh=F853b0KXSPGAcQ9VwtxlP4kGSJnL/qktYMbKK6xPExY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OeAqPVSbpcqXQiUBuF5Vq+x94hrfeFvHjH37Bq9ySML6Fer/9/sO92rbf0Lszf1w9PgGRQGTxUzA+0FLquHykTG8Gf2/un69xkVLaJlLsUnnJk2pYr7DsdEAinZwuqiEFnnfM7tDvJfsTcmvCplRSF6iygQhRkcfy/PNpu4W6qU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com; spf=pass smtp.mailfrom=canonical.com; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b=sayAvqVn; arc=none smtp.client-ip=185.125.188.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b="sayAvqVn" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id E37D040378 for ; Wed, 4 Feb 2026 16:38:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20251003; t=1770223137; bh=Rp00X+xKKqyCYdahSrblPa7LJgKvIx3gSCIrSAbBoco=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sayAvqVn5P6+VOwBcRmV2ETINp8f2i88/Eyqon7wGOw8+qyq2EdwInRI9U4THJt9f xrritaMWSTE6ARY4Ozk/nNt/fB2eKad8mWZExWHtBwaAol0UCmdpEVHeEMt8chfY4B pKmWwiiFr7sGO2cb8T2906lE3LOAOtY/L90VDfJNCcaeI8DYPxnfmZ/dOPe7JZIZWL aK36AM1hYRiTLpEem9OLt3z7gp+C5EjTq5rtFzzYnIgssWvaID2csSyULyrHYS2jc6 CHvV1/VfVjJ9+fVbES7/B6DrJ0QI5RedOLaM1lHZh2Fe49giELHecPBtcKHijEu+jb z0U6QRyeyEgbrQv5QCKW8WlPxsChsieUF9uI/AUz1SueJ2GoJ0l9J7elDiesQL9gTN F12tEwC89PfYY1faxWucMKEYwZVZlbMlr8QWcH9KIs8jFWAOj/8BkceZyBTlOmGlgb 9QwSHbXDXpSfZa53u37GHVuUwZmESoeCN/q9QbKg4CY9xd8oMpiTpAo7nC+ZUxtF23 XgSa5xhvE1NfVAxUwb/Fezsk6VrvEDK7tW2eWVJPLShcbMJ8tGUaQQgtBVraBPp1q+ iLMFBFUz7KMKqoEijYEevq68lWh2lldi5pRO3eA3zjL3aiXuZUVeBti1+8J+YBprW/ tr0uhWlaRV0bCiQamd8ZnEy0= Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-435aadfaf4eso23111f8f.2 for ; Wed, 04 Feb 2026 08:38:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770223137; x=1770827937; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Rp00X+xKKqyCYdahSrblPa7LJgKvIx3gSCIrSAbBoco=; b=SZVlaqFAiTNhD0sh+0BPd9I7eYC+WiSOD7EuYgbLiINq0uMIIdKPM3mR5qr2UrrRIa mLpFr1+g7qRbMJNlDqigipfo6CSLnlASpJRAPVGPxIqgLKQcyvTec92/ahxBB8h9wwj/ YUrowsKZucPMpqJY095G0hsHG4CRxOlJBDEXmb1Zw1ob20EPi8q33VeFukX6a5vWlFwE xo17F6VTl8bUtfQ1Jtku8yQdv+sF3vM9L4/e6t4vqKZv2ym5GlOCWyKRVsO7k0bwbXKY gIObR8ybsjDYA9R9XcTIYaxgwjMf0CrTknQkNa18iKpDgopNYiuavQYyn2LTWQ/aZSFc XyJQ== X-Forwarded-Encrypted: i=1; AJvYcCVPa60J9s/mjvBatI0q59Wfpeodmt02eaNl86mjY7W/bS1o6WBYHiLxCdZuaYKM8apsfbJWakaWm329wco=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9LobBx+thTkAmdKXOt3Oz210nYAK7NrEwY03P0FGZL5l4fP4n AJ+g4sfzu96/Qgwmo6znoVrQIZ96w9SHoxMhq2QpyyguogVd6ITk5MKtqp1OoXxuOA0ghkQzCf8 rrf8Du79JJsWWiUMvvCVhNqvQOO3TpYeix4zLCl4i7t/M4zPpihe6vNRbN5CGwYQ6ubGultBee7 pcfZZG0Q== X-Gm-Gg: AZuq6aKga9GHop6apIFT/CykyNqCRfoN5XqJRdk9Jlq7ok6O3tna5veKn70fp7vGK7r Zy/DyL3sQc0JqkSkhsDxOYIrBojoRynQOlpQknolu8sfsXFyhexNoXMOL2GRhE9j+bchIyLTvfX ImDeHDZWWZauClKhpvIV5CO7EmppK8ubXFaa2pLsmDtclAZ15LwpQeypxKrT4Qj2+StsPbGoGKy XPtWtoqErQ7WqqJ0/wLozRs7sTeH2jdtTfqFd1Ai7JS9YD/Y8pPGLFqMD1VTGy4FqygDwPJ+CRD 73a515SBNsLfKPxwDTl042lYlN7xrH++81wkfIY6lirChEaovCt/twUoqj4sFWC8cAKeMwJpbuZ mHGHAY1gx9SEIU+GkhFzUlpgthEGUWvAAxKEBaPsYMBZhBqL5ZZPTrrxWBTvkqziran2T0MZDpa 8hg4NHWN8= X-Received: by 2002:a5d:5d0d:0:b0:435:e3bd:5838 with SMTP id ffacd0b85a97d-43617e3c9bemr3476201f8f.25.1770223137428; Wed, 04 Feb 2026 08:38:57 -0800 (PST) X-Received: by 2002:a5d:5d0d:0:b0:435:e3bd:5838 with SMTP id ffacd0b85a97d-43617e3c9bemr3476162f8f.25.1770223136979; Wed, 04 Feb 2026 08:38:56 -0800 (PST) Received: from [192.168.103.128] (ip-005-147-080-091.um06.pools.vodafone-ip.de. [5.147.80.91]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43618057f9esm6385227f8f.28.2026.02.04.08.38.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Feb 2026 08:38:56 -0800 (PST) Message-ID: <46d5d249-8cf2-46d1-a90c-1f2c5f146e15@canonical.com> Date: Wed, 4 Feb 2026 17:38:54 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] riscv: dts: starfive: Milk-V Mars CM Lite broken-cd To: Emil Renner Berthing , Conor Dooley Cc: Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , E Shattow , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260204101602.30184-1-heinrich.schuchardt@canonical.com> Content-Language: en-US From: Heinrich Schuchardt In-Reply-To: <20260204101602.30184-1-heinrich.schuchardt@canonical.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/4/26 11:16, Heinrich Schuchardt wrote: > The card detect GPIO depends on support by the base board. > > Detecting an SD-card did not work for me with a Milk-V Mars CM Lite > mounted on an Waveshare CM4-IO-BASE-A board. The schematic of the Waveshare CM4-IO-BASE-A board is available at https://files.waveshare.com/upload/a/aa/CM4-IO-BASE-A_V4_SchDoc.pdf showing pin 76 is not connected. In https://forums.raspberrypi.com/viewtopic.php?t=291041 the Raspberry Foundation explicitly wrote that pin 76 should not be connected when using a compute module socket. E. Shattow pointed me to a board https://github.com/NabuCasa/yellow/releases/download/v1.3c/Yellow_v1.3c_Schematic_git.8957b440adda.pdf that actually disregarded this advice and uses pin 76 actually as cd-gpio. This usage of GPIO 41 is a property of the specific base board and not of the Milk-V Mars CM and should be described in a device-tree overlay if needed. Best regards Heinrich > > According to [1] SD_SDIO0_CD_GPIO41 is connected to pin 76 reserved. > The Raspberry Pi Compute Module 4 IO Board documentation marks that pin as > reserved. The Raspberry Pi Compute Module 5 IO Board documentation > marks the pin as VBAT. > > Remove the cd-gpios definition and add broken-cd. > > [1] https://github.com/milkv-mars/mars-files/blob/main/Mars-CM_Hardware_Schematices/Milk-V_Mars-CM_SCH_V1.0-2023-0905_Lite.pdf > > Signed-off-by: Heinrich Schuchardt > --- > arch/riscv/boot/dts/starfive/jh7110-milkv-marscm-lite.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/boot/dts/starfive/jh7110-milkv-marscm-lite.dts b/arch/riscv/boot/dts/starfive/jh7110-milkv-marscm-lite.dts > index 63aa94d65ab55..566b0bdc2800d 100644 > --- a/arch/riscv/boot/dts/starfive/jh7110-milkv-marscm-lite.dts > +++ b/arch/riscv/boot/dts/starfive/jh7110-milkv-marscm-lite.dts > @@ -13,7 +13,7 @@ / { > > &mmc0 { > bus-width = <4>; > - cd-gpios = <&sysgpio 41 GPIO_ACTIVE_LOW>; > + broken-cd; > disable-wp; > }; >