Re: [PATCH v3 09/10] drm/panel: ilitek-ili9805: add support for Tianma TM041XDHG01 panel

[Neil Armstrong <neil.armstrong@linaro.org>]

On 30/11/2023 15:16, Dario Binacchi wrote:
> From: Michael Trimarchi <michael@amarulasolutions.com>
> 
> Tianma TM041XDHG01 utilizes the Ilitek ILI9805 controller.
> 
> Add this panel's initialzation sequence and timing to ILI9805 driver.
> 
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
> 
> (no changes since v1)
> 
>   drivers/gpu/drm/panel/panel-ilitek-ili9805.c | 53 ++++++++++++++++++++
>   1 file changed, 53 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9805.c b/drivers/gpu/drm/panel/panel-ilitek-ili9805.c
> index 749959e10d92..cd187b0b1998 100644
> --- a/drivers/gpu/drm/panel/panel-ilitek-ili9805.c
> +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9805.c
> @@ -89,6 +89,36 @@ static const struct ili9805_instr gpm1780a0_init[] = {
>   	ILI9805_INSTR(0, 0xB9, 0x02, 0x00),
>   };
>   
> +static const struct ili9805_instr tm041xdhg01_init[] = {
> +	ILI9805_INSTR(100, ILI9805_EXTCMD_CMD_SET_ENABLE_REG, ILI9805_SETEXTC_PARAMETER1,
> +		      ILI9805_SETEXTC_PARAMETER2, ILI9805_SETEXTC_PARAMETER3),
> +	ILI9805_INSTR(100, 0xFD, 0x0F, 0x13, 0x44, 0x00),
> +	ILI9805_INSTR(0, 0xf8, 0x18, 0x02, 0x02, 0x18, 0x02, 0x02, 0x30, 0x01,
> +		      0x01, 0x30, 0x01, 0x01, 0x30, 0x01, 0x01),
> +	ILI9805_INSTR(0, 0xB8, 0x74),
> +	ILI9805_INSTR(0, 0xF1, 0x00),
> +	ILI9805_INSTR(0, 0xF2, 0x00, 0x58, 0x40),
> +	ILI9805_INSTR(0, 0xFC, 0x04, 0x0F, 0x01),
> +	ILI9805_INSTR(0, 0xEB, 0x08, 0x0F),
> +	ILI9805_INSTR(0, 0xe0, 0x01, 0x0d, 0x15, 0x0e, 0x0f, 0x0f, 0x0b, 0x08, 0x04,
> +		      0x07, 0x0a, 0x0d, 0x0c, 0x15, 0x0f, 0x08),
> +	ILI9805_INSTR(0, 0xe1, 0x01, 0x0d, 0x15, 0x0e, 0x0f, 0x0f, 0x0b, 0x08, 0x04,
> +		      0x07, 0x0a, 0x0d, 0x0c, 0x15, 0x0f, 0x08),
> +	ILI9805_INSTR(10, 0xc1, 0x15, 0x03, 0x03, 0x31),
> +	ILI9805_INSTR(10, 0xB1, 0x00, 0x12, 0x14),
> +	ILI9805_INSTR(10, 0xB4, 0x02),
> +	ILI9805_INSTR(0, 0xBB, 0x14, 0x55),
> +	ILI9805_INSTR(0, MIPI_DCS_SET_ADDRESS_MODE, 0x0a),
> +	ILI9805_INSTR(0, MIPI_DCS_SET_PIXEL_FORMAT, 0x77),
> +	ILI9805_INSTR(0, 0x20),
> +	ILI9805_INSTR(0, 0xB0, 0x00),
> +	ILI9805_INSTR(0, 0xB6, 0x01),
> +	ILI9805_INSTR(0, 0xc2, 0x11),
> +	ILI9805_INSTR(0, 0x51, 0xFF),
> +	ILI9805_INSTR(0, 0x53, 0x24),
> +	ILI9805_INSTR(0, 0x55, 0x00),
> +};
> +
>   static inline struct ili9805 *panel_to_ili9805(struct drm_panel *panel)
>   {
>   	return container_of(panel, struct ili9805, panel);
> @@ -239,6 +269,20 @@ static const struct drm_display_mode gpm1780a0_timing = {
>   	.vtotal = 480 + 2 + 4 + 10,
>   };
>   
> +static const struct drm_display_mode tm041xdhg01_timing = {
> +	.clock = 26227,
> +
> +	.hdisplay = 480,
> +	.hsync_start = 480 + 10,
> +	.hsync_end = 480 + 10 + 2,
> +	.htotal = 480 + 10 + 2 + 36,
> +
> +	.vdisplay = 768,
> +	.vsync_start = 768 + 2,
> +	.vsync_end = 768 + 10 + 4,
> +	.vtotal = 768 + 2 + 4 + 10,
> +};
> +
>   static int ili9805_get_modes(struct drm_panel *panel,
>   			      struct drm_connector *connector)
>   {
> @@ -343,8 +387,17 @@ static const struct ili9805_desc gpm1780a0_desc = {
>   	.height_mm = 65,
>   };
>   
> +static const struct ili9805_desc tm041xdhg01_desc = {
> +	.init = tm041xdhg01_init,
> +	.init_length = ARRAY_SIZE(tm041xdhg01_init),
> +	.mode = &tm041xdhg01_timing,
> +	.width_mm = 42,
> +	.height_mm = 96,
> +};
> +
>   static const struct of_device_id ili9805_of_match[] = {
>   	{ .compatible = "giantplus,gpm1790a0", .data = &gpm1780a0_desc },
> +	{ .compatible = "tianma,tm041xdhg01", .data = &tm041xdhg01_desc },
>   	{ }
>   };
>   MODULE_DEVICE_TABLE(of, ili9805_of_match);

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>