From: Alexander Lochmann <info@alexander-lochmann.de>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Andrey Konovalov <andreyknvl@google.com>,
Jonathan Corbet <corbet@lwn.net>,
Andrew Morton <akpm@linux-foundation.org>,
Wei Yongjun <weiyongjun1@huawei.com>,
Maciej Grochowski <maciej.grochowski@pm.me>,
kasan-dev <kasan-dev@googlegroups.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
syzkaller <syzkaller@googlegroups.com>
Subject: Re: [PATCH] KCOV: Introduced tracing unique covered PCs
Date: Wed, 17 Mar 2021 22:10:25 +0100 [thread overview]
Message-ID: <46db8e40-b3b6-370c-98fe-37610b789596@alexander-lochmann.de> (raw)
In-Reply-To: <CACT4Y+ZPX43ihuL0TCiCY-ZNa4RmfwuieLb1XUDJEa4tELsUsQ@mail.gmail.com>
On 15.03.21 09:02, Dmitry Vyukov wrote:
>>> Does this introduce an additional real of t->kcov_mode?
>>> If yes, please reuse the value read in check_kcov_mode.
>> Okay. How do I get that value from check_kcov_mode() to the caller?
>> Shall I add an additional parameter to check_kcov_mode()?
>
> Yes, I would try to add an additional pointer parameter for mode. I
> think after inlining the compiler should be able to regestrize it.
First, I'll go for the extra argument. However, the compiler doesn't
seem to inline check_kcov_mode(). Can I enforce inlining?
I'm using GCC 9.3 on Debian Testing.
- Alex
--
Alexander Lochmann PGP key: 0xBC3EF6FD
Heiliger Weg 72 phone: +49.231.28053964
D-44141 Dortmund mobile: +49.151.15738323
next prev parent reply other threads:[~2021-03-17 21:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 8:07 Alexander Lochmann
2021-02-12 12:54 ` Dmitry Vyukov
2021-03-14 21:29 ` Alexander Lochmann
2021-03-15 8:02 ` Dmitry Vyukov
2021-03-15 21:43 ` Alexander Lochmann
2021-03-16 6:36 ` Dmitry Vyukov
2021-03-17 21:10 ` Alexander Lochmann [this message]
2021-03-18 7:17 ` Dmitry Vyukov
2021-03-21 18:43 ` [PATCH] Introduced new tracing mode KCOV_MODE_UNIQUE Alexander Lochmann
2021-03-22 12:17 ` Miguel Ojeda
2021-03-22 21:14 ` Alexander Lochmann
2021-03-23 7:23 ` Dmitry Vyukov
2021-03-23 8:19 ` Alexander Lochmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46db8e40-b3b6-370c-98fe-37610b789596@alexander-lochmann.de \
--to=info@alexander-lochmann.de \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=corbet@lwn.net \
--cc=dvyukov@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.grochowski@pm.me \
--cc=syzkaller@googlegroups.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®