From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756214AbZBJVhU (ORCPT ); Tue, 10 Feb 2009 16:37:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755294AbZBJVhG (ORCPT ); Tue, 10 Feb 2009 16:37:06 -0500 Received: from mail-bw0-f161.google.com ([209.85.218.161]:54048 "EHLO mail-bw0-f161.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754562AbZBJVhE (ORCPT ); Tue, 10 Feb 2009 16:37:04 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=GOQwiyYuqfBUWTyX5VlLj6c8z4YZ3WvcLydJTGOzQfqvKE2Aa2kc8N3fHiZbyKp7G7 f4J7VC5QoxJCipQtUu1d64efa+blZXX2+P1JxIsUSV+Pae0fX0sMKjprMmsC2a1eM7qV Lv0KLkZfkZMXmFmB6s5fKnmA+M9XZ91UPVM/g= MIME-Version: 1.0 In-Reply-To: <46e1c7760901240649v1e45bbb1v8c9997f236a3ec4c@mail.gmail.com> References: <46e1c7760901230433i3045f273oa109ce97e790bca3@mail.gmail.com> <46e1c7760901240109m5a0f3a85p788aa3ce35b49fa9@mail.gmail.com> <46e1c7760901240649v1e45bbb1v8c9997f236a3ec4c@mail.gmail.com> Date: Tue, 10 Feb 2009 23:37:01 +0200 Message-ID: <46e1c7760902101337qe239336n9ef2652a47f89aed@mail.gmail.com> Subject: Re: [Linux-fbdev-devel] [PATCH] fb: hide cursor in graphics mode From: Risto Suominen To: Geert Uytterhoeven Cc: adaplas@pol.net, linux-fbdev-devel@lists.sourceforge.net, lkml Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Xserver Xfbdev (kdrive) uses linux framebuffer in graphics mode. It doesn't need the text mode cursor, it's a bit annoying to have it there sitting in a corner. This patch disables the cursor even when in graphics mode. Signed-off-by: Risto Suominen --- The testing is done on kernel version 2.6.18. This version should be applyable on 2.6.28.4. --- a/drivers/video/console/fbcon.c.org 2007-03-03 07:14:54.000000000 +0200 +++ b/drivers/video/console/fbcon.c 2009-01-23 12:42:14.000000000 +0200 @@ -1363,6 +1363,12 @@ static void fbcon_cursor(struct vc_data int y; int c = scr_readw((u16 *) vc->vc_pos); + if (mode == CM_ERASE && info->fbops->fb_cursor) { + /* Hide H/W-cursor unconditionally */ + ops->cursor(vc, info, mode, 0, 0, 0); + return; + } + if (fbcon_is_inactive(vc, info) || vc->vc_deccm != 1) return;