From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BEB5CE7A88 for ; Sat, 23 Sep 2023 18:04:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232213AbjIWSE6 (ORCPT ); Sat, 23 Sep 2023 14:04:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232177AbjIWSE4 (ORCPT ); Sat, 23 Sep 2023 14:04:56 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A329136 for ; Sat, 23 Sep 2023 11:04:50 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-52fe27898e9so4574864a12.0 for ; Sat, 23 Sep 2023 11:04:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695492289; x=1696097089; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bLYCr2Z4vuDAhql4XDXkXixLZPPP1JO3qvIuyryDbtU=; b=MdfOxM+4i5rXjQE6r64pURUoMCKoCA9GMhjezZ3FNry/5OafHYfU5xE4f5wBK9//Gk 8hMGkMsRt664FFGP23+Jmo93tx42XFnUzMzWv5iQL7vDY3+hHdedqV45PHBtBoAK0H6p 4wRhKS+OBihlSbvEkwcpJTUsNM+QRahSckhNTuoXzYpaHizXm9GIw0+OHQhbp14GwoTt q/a3m8mFW6YVjP5H+r13HFkrHCFT1MhEqzb+5EFPsfND1IabYGZK5C7ANCZbwen8RSJX V3mFm+FVjR4hcsBXz5kGgOeIFwl4lVlLXYLuzmrlQff+PYoob0YFyDpUwkceIlayqus4 c9FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695492289; x=1696097089; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bLYCr2Z4vuDAhql4XDXkXixLZPPP1JO3qvIuyryDbtU=; b=VyGK6TOqo/hdWWhWWSkGiQYOtgH1ifXjssQ6LE1cyM/jIvTF3DaZp2VLw0i4LkgDFo op2zWMluwNQVeO5701ko2PqfCr4/KFcGs5HSs5mGJka9kEPDh5nh/wkT6LprILUgxBkv EW8eQ425IsJZV+1HKFPktsnqXXsFJJHObIiGQUY+1+ZUMecEaR2FgOuVlmL2hhIwmywQ ntWWgWv8/ZsY+m6xbUiLUwnGaVEUR1jvYVvwyC37tiWQaYNkv5fsIQ8PaD9wJxw/dZxA PBIbcJpGZ3x+ndFrRIukq3THC26hard+9RQJ4iCkHZWsayasSBoZ6TgJUgwDELtCCV9N sagA== X-Gm-Message-State: AOJu0YyTZrPNYDQrG5wweJbPNHkNeA5MeaAsjU3PLtSKMJhUWnCVxPGd qkCfH7ShZ9VxbjiAj3RKuPmpww== X-Google-Smtp-Source: AGHT+IEw+sN5D8rf7LUOkThHrXnJDjHXiCrShJbLvyy6HlUTwvbaS++DGIvd128TxX7bpTRBo77clg== X-Received: by 2002:aa7:d518:0:b0:522:2111:1063 with SMTP id y24-20020aa7d518000000b0052221111063mr2280637edq.18.1695492288665; Sat, 23 Sep 2023 11:04:48 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.100]) by smtp.gmail.com with ESMTPSA id s3-20020aa7d783000000b0053116e45317sm3534309edq.44.2023.09.23.11.04.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Sep 2023 11:04:48 -0700 (PDT) Message-ID: <46e6aba3-cd10-5fb1-c217-5d9341a65381@linaro.org> Date: Sat, 23 Sep 2023 20:04:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 08/15] soc: mediatek: Add cmdq_pkt_finalize_loop to CMDQ driver Content-Language: en-US To: "Jason-JH.Lin" , Jassi Brar , Krzysztof Kozlowski , Rob Herring , Matthias Brugger , Chun-Kuang Hu , AngeloGioacchino Del Regno Cc: Conor Dooley , Jason-ch Chen , Johnson Wang , Elvis Wang , Singo Chang , Nancy Lin , Shawn Sung , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20230918192204.32263-1-jason-jh.lin@mediatek.com> <20230918192204.32263-9-jason-jh.lin@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20230918192204.32263-9-jason-jh.lin@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/09/2023 21:21, Jason-JH.Lin wrote: > Add cmdq_pkt_finalize_loop to CMDQ driver. > > cmdq_pkt_finalize_loop appends end of command(EOC) instruction and > jump to start of command buffer instruction to make the command > buffer loopable. > > Signed-off-by: Jason-JH.Lin > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 23 +++++++++++++++++++++++ > include/linux/soc/mediatek/mtk-cmdq.h | 8 ++++++++ > 2 files changed, 31 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > index 4be2a18a4a02..bbb127620bb3 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -475,6 +475,29 @@ int cmdq_pkt_finalize(struct cmdq_pkt *pkt) > } > EXPORT_SYMBOL(cmdq_pkt_finalize); > > +int cmdq_pkt_finalize_loop(struct cmdq_pkt *pkt) > +{ > + struct cmdq_instruction inst = { {0} }; > + int err; > + > + /* insert EOC and generate IRQ for each command iteration */ > + inst.op = CMDQ_CODE_EOC; > + inst.value = CMDQ_EOC_IRQ_EN; > + err = cmdq_pkt_append_command(pkt, inst); > + if (err < 0) > + return err; > + > + /* JUMP to start of pkt */ > + err = cmdq_pkt_jump(pkt, pkt->pa_base); > + if (err < 0) > + return err; > + > + pkt->loop = true; > + > + return err; > +} > +EXPORT_SYMBOL(cmdq_pkt_finalize_loop); 1. Missing GPL 2. Missing kerneldoc 3. Missing user 4. Are you going to split the patchset into one function per patch? No. Best regards, Krzysztof