From: "Huang, Kai" <kai.huang@intel.com>
To: "pbonzini@redhat.com" <pbonzini@redhat.com>,
"seanjc@google.com" <seanjc@google.com>
Cc: "Li, Xiaoyao" <xiaoyao.li@intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
"binbin.wu@linux.intel.com" <binbin.wu@linux.intel.com>
Subject: Re: [PATCH v2 2/2] KVM: TDX: WARN if a SEAMCALL VM-Exit makes its way out to KVM
Date: Fri, 17 Oct 2025 10:40:50 +0000 [thread overview]
Message-ID: <46eb76240a29cb81b6a8aa41016466810abef559.camel@intel.com> (raw)
In-Reply-To: <20251016182148.69085-3-seanjc@google.com>
On Thu, 2025-10-16 at 11:21 -0700, Sean Christopherson wrote:
> WARN if KVM observes a SEAMCALL VM-Exit while running a TD guest, as the
> TDX-Module is supposed to inject a #UD, per the "Unconditionally Blocked
> Instructions" section of the TDX-Module base specification.
>
> Reported-by: Xiaoyao Li <xiaoyao.li@intel.com>
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
> arch/x86/kvm/vmx/tdx.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/x86/kvm/vmx/tdx.c b/arch/x86/kvm/vmx/tdx.c
> index 097304bf1e1d..ffcfe95f224f 100644
> --- a/arch/x86/kvm/vmx/tdx.c
> +++ b/arch/x86/kvm/vmx/tdx.c
> @@ -2148,6 +2148,9 @@ int tdx_handle_exit(struct kvm_vcpu *vcpu, fastpath_t fastpath)
> * - If it's not an MSMI, no need to do anything here.
> */
> return 1;
> + case EXIT_REASON_SEAMCALL:
> + WARN_ON_ONCE(1);
> + break;
>
While this exit should never happen from a TDX guest, I am wondering why
we need to explicitly handle the SEAMCALL? E.g., per "Unconditionally
Blocked Instructions" ENCLS/ENCLV are also listed, therefore
EXIT_REASON_ELCLS/ENCLV should never come from a TDX guest either.
next prev parent reply other threads:[~2025-10-17 10:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 18:21 [PATCH v2 0/2] KVM: VMX: Handle SEAMCALL or TDCALL VM-Exits Sean Christopherson
2025-10-16 18:21 ` [PATCH v2 1/2] KVM: VMX: Inject #UD if guest tries to execute SEAMCALL or TDCALL Sean Christopherson
2025-10-17 2:53 ` Xiaoyao Li
2025-10-17 5:27 ` Binbin Wu
2025-10-17 10:53 ` Huang, Kai
2025-10-17 13:00 ` Sean Christopherson
2025-10-17 20:34 ` Huang, Kai
2025-10-17 20:34 ` Huang, Kai
2025-10-16 18:21 ` [PATCH v2 2/2] KVM: TDX: WARN if a SEAMCALL VM-Exit makes its way out to KVM Sean Christopherson
2025-10-17 2:56 ` Xiaoyao Li
2025-10-17 5:29 ` Binbin Wu
2025-10-17 10:40 ` Huang, Kai [this message]
2025-10-17 17:25 ` Sean Christopherson
2025-10-17 20:58 ` Huang, Kai
2025-10-17 21:11 ` Huang, Kai
2025-10-20 6:10 ` Xiaoyao Li
2025-10-20 15:03 ` Sean Christopherson
2025-11-04 17:45 ` [PATCH v2 0/2] KVM: VMX: Handle SEAMCALL or TDCALL VM-Exits Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46eb76240a29cb81b6a8aa41016466810abef559.camel@intel.com \
--to=kai.huang@intel.com \
--cc=binbin.wu@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rick.p.edgecombe@intel.com \
--cc=seanjc@google.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®