From: Dongsu Park <dongsu.park@profitbricks.com>
To: linux-kernel@vger.kernel.org
Cc: Christoph Hellwig <hch@infradead.org>,
Kent Overstreet <kmo@daterainc.com>, Jens Axboe <axboe@kernel.dk>,
Dongsu Park <dongsu.park@profitbricks.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org
Subject: [PATCH v2 9/9] Documentation: update notes in biovecs about arbitrarily sized bios
Date: Mon, 12 Jan 2015 12:49:48 +0100 [thread overview]
Message-ID: <46ed4095bbdb89c9bbd1170cb403dffaac9dc13f.1421052746.git.dongsu.park@profitbricks.com> (raw)
In-Reply-To: <3fc2ee4eedd3bc6ef515b14108942425afb733d3.1421052746.git.dongsu.park@profitbricks.com>
In-Reply-To: <cover.1421052745.git.dongsu.park@profitbricks.com>
Update block/biovecs.txt so that it includes a note on what kind of
effects arbitrarily sized bios would bring to the block layer.
Also fix a trivial typo, bio_iter_iovec.
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Kent Overstreet <kmo@daterainc.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org
Signed-off-by: Dongsu Park <dongsu.park@profitbricks.com>
---
Documentation/block/biovecs.txt | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/Documentation/block/biovecs.txt b/Documentation/block/biovecs.txt
index 74a32ad..2568958 100644
--- a/Documentation/block/biovecs.txt
+++ b/Documentation/block/biovecs.txt
@@ -24,7 +24,7 @@ particular, presenting the illusion of partially completed biovecs so that
normal code doesn't have to deal with bi_bvec_done.
* Driver code should no longer refer to biovecs directly; we now have
- bio_iovec() and bio_iovec_iter() macros that return literal struct biovecs,
+ bio_iovec() and bio_iter_iovec() macros that return literal struct biovecs,
constructed from the raw biovecs but taking into account bi_bvec_done and
bi_size.
@@ -109,3 +109,11 @@ Other implications:
over all the biovecs in the new bio - which is silly as it's not needed.
So, don't use bi_vcnt anymore.
+
+ * The current interface allows the block layer to split bios as needed, so we
+ could eliminate a lot of complexity particularly in stacked drivers. Code
+ that creates bios can then create whatever size bios are convenient, and
+ more importantly stacked drivers don't have to deal with both their own bio
+ size limitations and the limitations of the underlying devices. Thus
+ there's no need to define ->merge_bvec_fn() callbacks for individual block
+ drivers.
--
2.1.0
next prev parent reply other threads:[~2015-01-12 11:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 11:49 [RFC PATCH v2 0/9] simplify block layer based on immutable biovecs Dongsu Park
2015-01-12 11:49 ` [PATCH v2 1/9] block: make generic_make_request handle arbitrarily sized bios Dongsu Park
2015-01-12 11:49 ` [PATCH v2 2/9] block: simplify bio_add_page() Dongsu Park
2015-01-12 11:49 ` [PATCH v2 3/9] block: allow __blk_queue_bounce() to handle bios larger than BIO_MAX_PAGES Dongsu Park
2015-01-12 11:49 ` [PATCH v2 4/9] bcache: clean up hacks around bio_split_pool Dongsu Park
2015-01-12 11:49 ` [PATCH v2 5/9] btrfs: remove bio splitting and merge_bvec_fn() calls Dongsu Park
2015-01-12 11:49 ` [PATCH v2 6/9] md/raid5: get rid of bio_fits_rdev() Dongsu Park
2015-01-12 11:49 ` [PATCH v2 7/9] block: kill merge_bvec_fn() completely Dongsu Park
2015-01-12 11:49 ` [PATCH v2 8/9] fs: use helper bio_add_page() instead of open coding on bi_io_vec Dongsu Park
2015-01-12 11:49 ` Dongsu Park [this message]
2015-01-15 17:12 ` [RFC PATCH v2 0/9] simplify block layer based on immutable biovecs Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46ed4095bbdb89c9bbd1170cb403dffaac9dc13f.1421052746.git.dongsu.park@profitbricks.com \
--to=dongsu.park@profitbricks.com \
--cc=axboe@kernel.dk \
--cc=corbet@lwn.net \
--cc=hch@infradead.org \
--cc=kmo@daterainc.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®