From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752479AbdK3MRG (ORCPT ); Thu, 30 Nov 2017 07:17:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57160 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751125AbdK3MRF (ORCPT ); Thu, 30 Nov 2017 07:17:05 -0500 Subject: Re: [PATCH v3 4/9] KVM: x86: Add Intel Processor Trace cpuid emulation To: Luwei Kang , kvm@vger.kernel.org Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, rkrcmar@redhat.com, linux-kernel@vger.kernel.org, joro@8bytes.org, Chao Peng References: <1511814242-12949-1-git-send-email-luwei.kang@intel.com> <1511814242-12949-5-git-send-email-luwei.kang@intel.com> From: Paolo Bonzini Message-ID: <46f714d9-a8be-4f62-1f92-21b2a3f12009@redhat.com> Date: Thu, 30 Nov 2017 13:17:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1511814242-12949-5-git-send-email-luwei.kang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 30 Nov 2017 12:17:05 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/11/2017 21:23, Luwei Kang wrote: > + int t, times = entry->eax & 0xffffffff; This AND is not necessary. Paolo > + > + if (!f_intel_pt) > + break; > + > + entry->flags |= KVM_CPUID_FLAG_SIGNIFCANT_INDEX; > + for (t = 1; t <= times; ++t) { > + if (*nent >= maxnent) > + goto out; > + do_cpuid_1_ent(&entry[t], function, t); > + entry[t].flags |= KVM_CPUID_FLAG_SIGNIFCANT_INDEX; > + ++*nent; > + } > + break; > + }