From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0940A146585 for ; Fri, 11 Apr 2025 13:17:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744377460; cv=none; b=YvEGwTQfeuS6zZDDoyJRWZxlR+ZL9KlMcJfgphqJnDfE6zDd/4IfgoKlymRWk8J7Ul1YOsPpc9AdsoFLz1O+9IwjrBjFcrOutbdhvYmMR5Xxxjc+6iOzXfvidLDIfKO2N3cEHODxN/BWTtea6TmF36RBE4HP6P7sAJDgD1BsZYo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744377460; c=relaxed/simple; bh=0vAlQXUS7Qy2jeHeUT8fAxf4F02U5tCBQQ3d2Vwre84=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=aT2ycLPJyBmkCO6SqXhUm7Es0JZUNLCrKruATc7dNlroA/4PUXZZ6c74RBAnYyclvnNVCDYjas7FUjnJyAg2SKbNIL3kpOambgjwyo5RON+3fxdLK1PzeX6YoL/k4hDmmkcutTzF/u8+Ke8CGLvY7Vv3ZR+HGxf4amW8kptZ9lU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Y8SudLgQ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Y8SudLgQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744377457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aAPMnr15UUC2IJaasw8kvWmrIDi+EshqBG8kRRliicc=; b=Y8SudLgQqJx28Z6N1NWd6qO7QY1ImfArSQLV/HbTaiqD7H0sjMTeaarj4793AW1qgFWJeS /D53CJl7zDXZDOvVTCK2sHttzeFvgpLWiY9uojoyYlY8gz0ZAqowrsBtDl2vEFJTkNXdMz 6GKKPjuyJsqoOBqd2CU0DlbjmK7OlPY= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-104-xSJHeetwPd2MxncaHr6QqA-1; Fri, 11 Apr 2025 09:17:32 -0400 X-MC-Unique: xSJHeetwPd2MxncaHr6QqA-1 X-Mimecast-MFC-AGG-ID: xSJHeetwPd2MxncaHr6QqA_1744377442 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 863C81800EC5; Fri, 11 Apr 2025 13:17:21 +0000 (UTC) Received: from [10.45.225.124] (unknown [10.45.225.124]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 55E621828ABC; Fri, 11 Apr 2025 13:17:16 +0000 (UTC) Message-ID: <46ff3480-caca-4e2c-9382-2897c611758a@redhat.com> Date: Fri, 11 Apr 2025 15:17:14 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 07/14] mfd: zl3073x: Add components versions register defs From: Ivan Vecera To: Andy Shevchenko Cc: netdev@vger.kernel.org, Vadim Fedorenko , Arkadiusz Kubalewski , Jiri Pirko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Prathosh Satish , Lee Jones , Kees Cook , Andy Shevchenko , Andrew Morton , Michal Schmidt , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Andrew Lunn References: <20250409144250.206590-1-ivecera@redhat.com> <20250409144250.206590-8-ivecera@redhat.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 On 11. 04. 25 1:19 odp., Ivan Vecera wrote: > The range for regmap 1: (registers 0x000-0x4FF) > regmap_range_cfg { >     .range_min = 0, >     .range_max = 10 * 128 - 1, /* 10 pages, 128 registers each */ >     .selector_reg = 0x7f,      /* page selector at each page */ >     .selector_shift = 0,       /* no shift in page selector */ >     .selector_mask = GENMASK(3, 0),    /* 4 bits for page sel */ >     .window_start = 0,         /* 128 regs from 0x00-0x7f */ >     .window_len = 128, > }; > > The range for regmap 2: (registers 0x500-0x77F) > regmap_range_cfg { >     .range_min = 10 * 128, >     .range_max = 15 * 128 - 1, /* 5 pages, 128 registers each */ >     .selector_reg = 0x7f,      /* page selector at each page */ >     .selector_shift = 0,       /* no shift in page selector */ >     .selector_mask = GENMASK(3, 0),    /* 4 bits for page sel */ >     .window_start = 0,         /* 128 regs from 0x00-0x7f */ >     .window_len = 128, > }; > > Is it now OK? No this is not good... I cannot use 2 ranges. This is not safe... if the caller use regmap 2 to read/write something below 0x500 (by mistake), no mapping is applied and value is directly used as register number that's wrong :-(. Should I use rather single mapping range to cover all pages and ensure at driver level that regmap 2 is not used for regs < 0x500? -or- what would be the best approach? I.