mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Tanya Agarwal <tanyaagarwal25699@gmail.com>,
	dave.hansen@linux.intel.com, luto@kernel.org,
	peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com,
	bp@alien8.de
Cc: x86@kernel.org, hpa@zytor.com, kirill.shutemov@linux.intel.com,
	rick.p.edgecombe@intel.com, akpm@linux-foundation.org,
	skhan@linuxfoundation.org, anupnewsmail@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] x86/mm: Fix NULL pointer dereference in kernel_page_present()
Date: Fri, 24 Jan 2025 09:10:34 -0800	[thread overview]
Message-ID: <4704cbab-de5a-4c0b-ac71-4fba0fe8b5c3@intel.com> (raw)
In-Reply-To: <20250111175808.48744-1-tanyaagarwal25699@gmail.com>

On 1/11/25 09:58, Tanya Agarwal wrote:
> From: Tanya Agarwal <tanyaagarwal25699@gmail.com>
> 
> The static code analysis tool "Coverity Scan" pointed the following
> details out for further development considerations:
> CID 1271215: Dereference null return value (NULL_RETURNS)
> dereference: Dereferencing pte, which is known to be NULL.

I think we need an actual changelog for this, as opposed to just blindly
trusting Coverity. You can say that Coverity helped identify this as an
issue, but we don't need the "CID" or other Coverity gunk in our
changelogs.  We don't care.

Could you please elaborate on where this issue might affect people? It's
also entirely theoretical as far as I can tell. I can't even conjure up
a contrived case where it could be triggered.

We won't do _anything_ with this patch until the merge window closes, so
you've got at least a week to spruce up the changelog.

      parent reply	other threads:[~2025-01-24 17:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-11 17:58 Tanya Agarwal
2025-01-24 16:47 ` Tanya Agarwal
2025-01-24 17:10 ` Dave Hansen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4704cbab-de5a-4c0b-ac71-4fba0fe8b5c3@intel.com \
    --to=dave.hansen@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=anupnewsmail@gmail.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rick.p.edgecombe@intel.com \
    --cc=skhan@linuxfoundation.org \
    --cc=tanyaagarwal25699@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®