mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephan Mueller <smueller@chronox.de>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	sergey.senozhatsky.work@gmail.com
Subject: Re: [PATCH] crypto/drbg: report backend_cra_name when allocation fails
Date: Wed, 10 Jun 2015 17:09:44 +0200	[thread overview]
Message-ID: <4705999.2gbf3TdHYZ@tauon.atsec.com> (raw)
In-Reply-To: <1433942868-16447-2-git-send-email-sergey.senozhatsky@gmail.com>

Am Wednesday 10 June 2015, 22:27:48 schrieb Sergey Senozhatsky:

Hi Sergey,

>Be more verbose and also report ->backend_cra_name when
>crypto_alloc_shash() or crypto_alloc_cipher() fail in
>drbg_init_hash_kernel() or drbg_init_sym_kernel()
>correspondingly.
>
>Example
> DRBG: could not allocate digest TFM handle: hmac(sha256)
>
>Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

Headscratch -- the Kconfig should have HMAC selected for compilation. When 
HMAC is available (regardless whether it is a module or not), it is pulled in 
by the kernel crypto API. Thus, there should not have been the error that HMAC 
is missing.

Can you send your .config file, please?

Ciao
Stephan

  reply	other threads:[~2015-06-10 15:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-10 13:27 [PATCH] trivial: " Sergey Senozhatsky
2015-06-10 13:27 ` [PATCH] crypto/drbg: " Sergey Senozhatsky
2015-06-10 15:09   ` Stephan Mueller [this message]
2015-06-10 23:38     ` Sergey Senozhatsky
2015-06-11 14:00   ` Herbert Xu
2015-06-11  0:28 ` [PATCH] trivial: " Herbert Xu
2015-06-11 11:09   ` Sergey Senozhatsky
2015-06-11 13:35     ` Stephan Mueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4705999.2gbf3TdHYZ@tauon.atsec.com \
    --to=smueller@chronox.de \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome