From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADE7FC31E50 for ; Mon, 17 Jun 2019 13:45:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8AF232084B for ; Mon, 17 Jun 2019 13:45:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728152AbfFQNpX (ORCPT ); Mon, 17 Jun 2019 09:45:23 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:18627 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725983AbfFQNpW (ORCPT ); Mon, 17 Jun 2019 09:45:22 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 2E8C9E9969F150E33548; Mon, 17 Jun 2019 21:45:19 +0800 (CST) Received: from [10.151.23.176] (10.151.23.176) by smtp.huawei.com (10.3.19.208) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 17 Jun 2019 21:45:09 +0800 Subject: Re: [PATCH] staging: erofs: clean up initialization of pointer de To: Colin King , Chao Yu , "Greg Kroah-Hartman" CC: , , , References: <20190617125529.28327-1-colin.king@canonical.com> From: Gao Xiang Message-ID: <470b93fd-ef5e-0019-b58d-8e38e7944e13@huawei.com> Date: Mon, 17 Jun 2019 21:45:09 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20190617125529.28327-1-colin.king@canonical.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.151.23.176] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/6/17 20:55, Colin King wrote: > From: Colin Ian King > > Currently pointer de is being initialized with a value that is > never read and a few statements later de is being re-assigned. Clean > this up by ininitialzing de and removing the re-assignment. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Loods good for me, Reviewed-by: Gao Xiang Thanks, Gao Xiang