From: Tudor Ambarus <tudor.ambarus@microchip.com>
To: Kees Cook <keescook@chromium.org>,
Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>,
<linux-crypto@vger.kernel.org>,
<kernel-hardening@lists.openwall.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] crypto/ecc: Remove stack VLA usage
Date: Fri, 9 Mar 2018 10:31:17 +0200 [thread overview]
Message-ID: <470bdece-b9a6-17fa-5dec-f4dfec51ef73@microchip.com> (raw)
In-Reply-To: <20180308215702.GA9902@beast>
On 03/08/2018 11:57 PM, Kees Cook wrote:
> On the quest to remove all VLAs from the kernel[1], this switches to
> a pair of kmalloc regions instead of using the stack. This also moves
> the get_random_bytes() after all allocations (and drops the needless
> "nbytes" variable).
>
> [1]https://lkml.org/lkml/2018/3/7/621
>
> Signed-off-by: Kees Cook<keescook@chromium.org>
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
next prev parent reply other threads:[~2018-03-09 8:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 21:57 Kees Cook
2018-03-09 8:31 ` Tudor Ambarus [this message]
2018-03-16 15:56 ` Herbert Xu
2018-03-26 22:38 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470bdece-b9a6-17fa-5dec-f4dfec51ef73@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome