From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62CC334A779 for ; Wed, 17 Dec 2025 10:05:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765965911; cv=none; b=YSbQQC+1SSQQZCmKm10Zy+uCRIG2lqvZdk8Wo4u0O6dM9Hs+ekvMh/LYIwV1/er+VlngeCWQm20RZ8qsbPqSFbEB7G+xa92ofCBwr7J6odxIcsAF+XQue2LuALmQXR9AMXSkEYWhWVAxJDDJ7Fv0OqbiBtLd2A3orsBCIYemTYM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765965911; c=relaxed/simple; bh=gZz3B9iIJzC/jmBs/0TCW0/gvf/+P5s7w8dHI1HIvQo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fJLAHWGMSzgiPyzWmkjmz5RftCny/EEQwViYPgcONXhbyomQGhUOlL2pYA7pMsTbpYtPgZOwPdHgcsOiyRAG50wwOGQVLVHbV891a3dqcS3VlqcxHb3TrkDvgNiKGvqZw+F0lq8nwDaTt516zGn3gg8K2rT2SBnkZGUCIkLSPa8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QEuQIfqj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EhwYLlWy; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QEuQIfqj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EhwYLlWy" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BHA1vwa1281810 for ; Wed, 17 Dec 2025 10:05:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= k3NJNOmNAyFKrjcNT0S5mV7RCgG5RqpzfwwSj7O8e2M=; b=QEuQIfqjtFSzFxDa r502rq2ok7tpkYLWABCygY8WLLHjnZOB6vP7Tr+xn68l3M0gOvOuqKJOf5weWKIJ roi8ToaLyyZvAowmPIhi0DvuaOQa6haqEwFyoWJuR6GvjCBm09NQPTkfguJ/MIgL VwebXygML2+sNSLVD3wIQOI5StnZAktbGUrguAC+FZNr0oYGx6UdniTg796h97ad OoktumscbmgKYLNjLb4uRHSIFtlgzC5qQ4h88fI9nHI73K1ZyEO1RQ4eL9V6qaZ+ cKGXC5j+MeiWYOdl0fWYSUP1AOaAc45oI0VgvW3/vZeona3Y0xh8c3uCrY9SfnxH Fe+pew== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b3fe2a02c-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Dec 2025 10:05:03 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8bbb6031cfdso98767885a.1 for ; Wed, 17 Dec 2025 02:05:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765965903; x=1766570703; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=k3NJNOmNAyFKrjcNT0S5mV7RCgG5RqpzfwwSj7O8e2M=; b=EhwYLlWyk60VvIayQykJrYZhPNZ5ybOKZ+S8mhWchTZZ1ZlQw26kNzgyRZx8l6djyL D7+5T2pbDBHka8U0pygQ9CBO0GjOruPlRuyiSR0Q4MSR8HNCrFagB3gLhl0KX30Xvm8j me+Rb/YRUbqTUJtw+SRzRc9EQyQBIAZLI+q1O+vQFFt4x0KBjD9HPXodNDt3sYzbBuaj bWgjXzO5fOIZfjNkg6tzKOV1zdDXaROWD3p45FXxlZ/JYVSpMyH7dXaiW6AyPT78LYo0 zR0XJxXbP47MHcoTqIyABFrvVqpfxAVaVRZow9cR12/TTuwJPVfIL3JefZ6B2/7kBrjp AYHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765965903; x=1766570703; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=k3NJNOmNAyFKrjcNT0S5mV7RCgG5RqpzfwwSj7O8e2M=; b=FAiHAaQSTJbAKwF4+1ITzivDTkkERZxU6pMPga4Vp/ITqVG3fnXtftTP8OEDw9qfuv awC7vOdSASFBuxnKU2jk+JQPIfbRihpQ+NS5UKRTGbplgYW33/g9lJbM6gc1qaKDq/z7 zBXkCO0Xj2IhnJyeBFWdlXW6fE8UKWziJwIZmkWh8aRHqLhSegsibM6lcm8A1kgEW5D9 AGL3YDHBBqZ4GulDHX6DkPRtUw3pasPvakVksHWWszCk9teCAurjSnvTH129eO74Ha7k X22FnYNpnaDLcbyqx8zOcs0+tO+KxzJ39f/fjLVPBjMlGJq/pgH/YZxSgdG3zZOwFJt/ MAdg== X-Forwarded-Encrypted: i=1; AJvYcCUK6rlIPIJrdXAPRHKU9C+mh2fmG6Oir+wpeeQD6PbMitixFym2vURjMnb5EFRXROFsCFMIZ7lwsW7XI6I=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6UJs5tQwnSD674vQ3vQJNDTAVrJhzuzI7zszDX9uIyoe/rRWm 7/nwD/PPhzzsRynxhXFp9flC6VDxMf+ciBCg0OH6umVJ+pCW3PYk+91T2W5N2n+YA1103+4lFhH qS3jI87CToX3L8xxx44tyLLeKORiYJJfdqvms7BndjIv/N6RWQwqCuUQFa/JCh1Q4W6o= X-Gm-Gg: AY/fxX5O+G8WZu7APfsckAWKOptVIsq1tcYzV3U7D5bAwwoqSrvNNBxi7EfMXvT0Kh6 VEGr4tEQdobjrxZYmQbDyLiysR7kP3ELkClbB301rfs7IfSp1zOo+YZKoYqnvIVCYyWf3gBQ070 pLG/prrTcFvAi2dKIg1+gNQbDPvpTcdETY6rlFecimbh6nt778AQzwoqrRVgZ5j/G9PqT2BIRfk zclq1KqTXQlHUaR3qHxJYy6osGQplGfT9eyMOhtsw7AHbhHj1ccDzA4JDlO6/qzYP49GzVz8S3A 264bdmYj4N5yk3LYTx5s+0HkiaGl4OOkouJyxEOh/NbRtFB1LKoydFG3SOTkOlU1i2zhp/hcCfH gTd4IxF+7j3D63jEYUtlbeawCXNgcPwKG4veNJ8P9GOJh996fROVHlpV9JXmQhGL04Q== X-Received: by 2002:a05:620a:3193:b0:8b2:dbf7:5193 with SMTP id af79cd13be357-8bb3a3a54b3mr1775808585a.8.1765965902770; Wed, 17 Dec 2025 02:05:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IHyT8wqW5vJWs30oNRZ8PJnnBqtLGOozur9GpczUF35gV60z+b4nAtlhuY/qisqT0pp8Zvmlg== X-Received: by 2002:a05:620a:3193:b0:8b2:dbf7:5193 with SMTP id af79cd13be357-8bb3a3a54b3mr1775806085a.8.1765965902296; Wed, 17 Dec 2025 02:05:02 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b3f4880dcsm1994074a12.0.2025.12.17.02.05.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Dec 2025 02:05:01 -0800 (PST) Message-ID: <470f8e79-4fa3-4d02-8e24-3cca5c4fe33a@oss.qualcomm.com> Date: Wed, 17 Dec 2025 11:04:59 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] clk: qcom: Return correct error code in qcom_cc_probe_by_index() To: Haotian Zhang , Bjorn Andersson , Michael Turquette , Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251217041338.2432-1-vulab@iscas.ac.cn> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251217041338.2432-1-vulab@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: yFx44kC0ZgeknJnbiEHfQTYyggbfrK1T X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE3MDA4MCBTYWx0ZWRfXyhUmE8WGtsgw ovT3HWShU8d1SRp/LA4LPMAuWkfYmOY7v7YgrBMQ5aRIUyZJrjmKsk6LjaFc3l/9sIY+VYjdGeR bnUttxpmdmbunzjbuYTPrKj11rYZ97YyO1XA4k1YMRqhZ6O93yFHlga0Je9CexsemmmaZj8Wn6d Bzz/5FMuH9V5l57v6xnnhzJQuQmWAz9I/F1zdhEImQx5XWc98LN11X4IP1XP5MjV0tvOc1Eoc87 gHLxAqP305l0+6jr2SRl6DONi3Dd9E5LKNQ6/uQPx9YBpyGfYtt7TryQAtR6QF73D+hLJUOigS5 tmrQTnrJQ7JxyDDS1yn1hKqU+eNmX4Att7tqxuSEYfnpAHdit7G+PQZhOAaX5KULbJ0ehdwi/yC K8r20p3Pi+YATA6pnhmjJ4/Gqm20zg== X-Proofpoint-ORIG-GUID: yFx44kC0ZgeknJnbiEHfQTYyggbfrK1T X-Authority-Analysis: v=2.4 cv=HpN72kTS c=1 sm=1 tr=0 ts=6942804f cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=P94ZdOjJmrbMzeDvDm4A:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-17_01,2025-12-16_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 clxscore=1015 priorityscore=1501 phishscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512170080 On 12/17/25 5:13 AM, Haotian Zhang wrote: > When devm_platform_ioremap_resource() fails, it returns various > error codes. Returning a hardcoded -ENOMEM masks the actual > failure reason. > > Use PTR_ERR() to propagate the actual error code returned by > devm_platform_ioremap_resource() instead of -ENOMEM. > > Fixes: 75e0a1e30191 ("clk: qcom: define probe by index API as common API") > Signed-off-by: Haotian Zhang > --- > drivers/clk/qcom/common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/qcom/common.c b/drivers/clk/qcom/common.c > index 121591886774..eec369d2173b 100644 > --- a/drivers/clk/qcom/common.c > +++ b/drivers/clk/qcom/common.c > @@ -454,7 +454,7 @@ int qcom_cc_probe_by_index(struct platform_device *pdev, int index, > > base = devm_platform_ioremap_resource(pdev, index); > if (IS_ERR(base)) > - return -ENOMEM; > + return PTR_ERR(base); Nice find! Reviewed-by: Konrad Dybcio Konrad