From: David Ahern <dsahern@gmail.com>
To: Namhyung Kim <namhyung@kernel.org>, David Ahern <dsahern@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH 2/2] perf sched timehist: Fix use of CPU list with summary option
Date: Tue, 11 Aug 2020 21:12:10 -0600 [thread overview]
Message-ID: <47111ff4-c61a-3a12-adb6-748b98fd0be0@gmail.com> (raw)
In-Reply-To: <CAM9d7chXrXh1QfJfwsEJ_Tk0_EDNL9ajBE8H0QYCSn_yuLhNUA@mail.gmail.com>
On 8/11/20 12:42 AM, Namhyung Kim wrote:
>> @@ -2575,7 +2575,8 @@ static int timehist_sched_change_event(struct perf_tool *tool,
>> }
>>
>> if (!sched->idle_hist || thread->tid == 0) {
>> - timehist_update_runtime_stats(tr, t, tprev);
>> + if (!cpu_list || test_bit(sample->cpu, cpu_bitmap))
>> + timehist_update_runtime_stats(tr, t, tprev);
>>
>> if (sched->idle_hist) {
>> struct idle_thread_runtime *itr = (void *)tr;
>> @@ -2848,6 +2849,9 @@ static void timehist_print_summary(struct perf_sched *sched,
>>
>> printf("\nIdle stats:\n");
>> for (i = 0; i < idle_max_cpu; ++i) {
>> + if (!test_bit(i, cpu_bitmap))
>
> Shouldn't it check cpu_list as well?
>
oh, right. will fix.
prev parent reply other threads:[~2020-08-12 3:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 16:49 David Ahern
2020-08-11 6:42 ` Namhyung Kim
2020-08-12 3:12 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47111ff4-c61a-3a12-adb6-748b98fd0be0@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@kernel.org \
--cc=dsahern@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®