From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43D1F3A872F for ; Wed, 4 Mar 2026 11:10:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772622651; cv=none; b=SYjc8vwUoUCT30wNCLSsrtTN9E2Ru2cs9OfmpxKrcjgstGs/+cQjPOrRpnTYFBPCH7PIe+p5aqj9jOPOTjzEgs8lEiHCPoP6FMqiQBavXDupyBTzSEvovPRpD5pv6Bksj71PNHydEZcRJWmRKE3l7Q2X5QYL2ND1b9eXpFbveIw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772622651; c=relaxed/simple; bh=8q4I0+K3Qd+pKpBHKEg0QmrqNR8wj9CrheJKZvAvxoQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=B3ZYO0Oy5qOYqwCthG/CmdYLuV9j/QbE5dRURpV0boYY4WgrkRCeEHvqZ5i9kFTka7gt+nAnH4VxpUil5SOYWgHJyP/wLYR8Xe+YQX9Jb2twRfnC/fN1DZKQNz1PmHYivh8ccP/0XvBS30B7PytlpCLxLcSC/86wfIX7xZT3hdI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PWDaLL3h; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fKK7Ogff; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PWDaLL3h"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fKK7Ogff" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6249KYxU1455809 for ; Wed, 4 Mar 2026 11:10:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MCCLwpZefcWyGX97YnB9vElnqX71UTAgAeEXx3DfaRQ=; b=PWDaLL3hXJ8B+B3K 9BbHZWwPBW6Z86Zthjxd3PjGFDOXiE0Zf2cwHaRhIJ++rZpYaZwOcNUEkzsBPUl9 BosBeVr4+RZa0QEMEbcFuWlnEF9dImhBz86+8iws1Zg2fMoaaoWC/QBL5PsKzMzE x/9ECkbkya3GvPuIFGj0pRVyRBnrpqFbRq0eEfk48E/hHtwe9eo+x/xK9Q8nWVas UJJvNGbTkBycDYOpxWMGlPKNGWqj26mBwTnTh9svxquaLyfYRaHT2UB+aj7TPnRN dBCiThI8kdAMDMSVOqFV2LcmBZqnL/eUrBqzVs46h3Y6yLdsAz3QQK2o8kxAOMfe qKHv9g== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cpj180be8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Mar 2026 11:10:49 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cb4a241582so3814770585a.0 for ; Wed, 04 Mar 2026 03:10:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772622649; x=1773227449; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MCCLwpZefcWyGX97YnB9vElnqX71UTAgAeEXx3DfaRQ=; b=fKK7OgffZtf64i3Lz6lgT8pxLIBMwLa+D7JmZf6dPUKsl8GpmmpEmJoB08asDGsNbj 8HpSy4eJrywXI7Neo8rvA3r93YvzR80D1cyyN3WQr6wFXHkD92J0oaXaKbOLC6auMMlJ H+ejqLiHzey8sKE2MAMWUrKqKmah4D61sKvohb9sn1UMXfSbwwX0OKB+Dkn8BRQdATk7 +LnVtqBOzMujJWgxdZt3XnfL5p0r9aTD83W5HTsB1ZLzM7UokEfxSZgaGu3CtNUYs94y 0xC3iSGecq2oWEI/n/B+cRa6O3+o4DHtHFXjWrXuQpY8GunvF4YOk5rXAchioUp7xmZ4 OD9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772622649; x=1773227449; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MCCLwpZefcWyGX97YnB9vElnqX71UTAgAeEXx3DfaRQ=; b=HOnJNdrH8gEIh0TMOHer5RoeDMOqh5kpC9YFiDcQMcjqkBj92px8kPV1GdNY7+re8H oGv43exEjDOlj3/8BndU8tsiLSSMcrrf8l7aZ9cihXADzYuycGOMsFii0k1fUatE7C1G weiCpx3pGHEw/Ug480nuLkLkBnWEBBSOycFif1Pcci9ARy/IxcCGC0yyzL6lByhHd7jl wFNK9jhKDXRa9qduY93e/qbnyISzNKcFrh+k6cSODBulvikXxfU2SEM5VJHdIoP7IZhD 0sytZVnD7zTKoop6ALu5QhCZLf3vZkM6s2S8dzF12SWfbVXYg3V++c6vicJDBrE/IxD+ vMfA== X-Forwarded-Encrypted: i=1; AJvYcCUWoIueQdO00lwKeypiiO/+3uxAjXOQKWNpjhGAbHXcfF7h2Nz//FRTNJ33FJUJaK2EKP7fmvJL9ceIq8U=@vger.kernel.org X-Gm-Message-State: AOJu0Yz31DaEA9AU1A4oKdKkT+CQtky8XPEFDgsIzUaGVQ6Skc9GChgU VSYF0FPIwe3C74bZsRl480wTzMXJnRf60zWU24MyFYuqw85iHvT3Ux+x5J0uTPh/flRAEdc4l3W GbAC9MyHlnlz6FmvU9cQMmT6/ShhtCcJPHubop4PU2bcrFvzix+6fzWjPtprYI+0XL7o= X-Gm-Gg: ATEYQzzBWARuONKgri4DKZDsTJtZks+py3et03OQlOayUdGeGLi+klhjSUtGMQH0+Fb mUW0nF/cvcmqJQNB7m8KkwWhwfsvhEngzpty/jD3c3GIKCHnbmH0s58IJDjvDXjcWbTEcbIty8b gM7Whfo8tKZnPp9f78gbZtMAsLnr+U8Ag246V1Tz//8MbjnmLFaq8yCwn9urtSjXuvKpHYi3y35 WYkq6FUcVZAuDj7Cv4h/y5UVZYhBolmIjMUPsHw2pFru98yuKktsLCUzpsyDaFyfsDSkeUDYyQK 5Hy0n8rOA3E7FyKozIyTITpU+M6BfsGSpV8fjNGsuOEBGUtylYSh7CuEy6vPsO4F1N0R20ss+6W Iz5WWfCxFTxLdnetBoM5X6MpJZ8RVXB4kqRPXcxHcGP1Wzyo4 X-Received: by 2002:a05:620a:1a08:b0:8c7:6f8:ae4c with SMTP id af79cd13be357-8cd5af774f7mr178537385a.43.1772622648419; Wed, 04 Mar 2026 03:10:48 -0800 (PST) X-Received: by 2002:a05:620a:1a08:b0:8c7:6f8:ae4c with SMTP id af79cd13be357-8cd5af774f7mr178532685a.43.1772622647870; Wed, 04 Mar 2026 03:10:47 -0800 (PST) Received: from [192.168.68.114] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-b935aee56c2sm744482466b.65.2026.03.04.03.10.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Mar 2026 03:10:47 -0800 (PST) Message-ID: <47123dd6-d17f-4d82-b8a1-e04a50e73a27@oss.qualcomm.com> Date: Wed, 4 Mar 2026 11:10:46 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 14/14] ASoC: qcom: q6apm: Add support for early buffer mapping on DSP To: Konrad Dybcio , broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: mohammad.rafi.shaik@oss.qualcomm.com, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, johan@kernel.org, dmitry.baryshkov@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, srini@kernel.org References: <20260223180740.444311-1-srinivas.kandagatla@oss.qualcomm.com> <20260223180740.444311-15-srinivas.kandagatla@oss.qualcomm.com> <3b4dfe95-9043-4682-8fee-7588fa1fde37@oss.qualcomm.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <3b4dfe95-9043-4682-8fee-7588fa1fde37@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: ATVYXTKczH-hJ9zx9p6ZGRzfblIEWHyT X-Proofpoint-ORIG-GUID: ATVYXTKczH-hJ9zx9p6ZGRzfblIEWHyT X-Authority-Analysis: v=2.4 cv=Ed7FgfmC c=1 sm=1 tr=0 ts=69a81339 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=29lxGkwPwxXT-BnxCXIA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA0MDA4NyBTYWx0ZWRfXwIanM1u7AO4w 6FTT/TdmzvhhDMkW3+889QIie74BIPpT0hGvQ/GBFe41FoaGuFmVopgZ7nED+4ArvQMzq7t/SDR Nacp055YhHLO4ru0I8NIST0aJUATxxB/g42zOMLw88XiSazBaqRrjryd1ibPQE3R/2QFLltmqkM Wq3FnScnWw0ZuYXaDEztObnnjJROTZGf2MCGhrdS4qs3Enx6jW4eoUlv1I+nAPn/xdi8qxEWymE LAmy7p5m2DLOtdGSgkh/GNjw6qyj3j6dKVHy7ROi/PmJaS21vAsQeDf19B+9UkRVYEMP+zDDslE d1vwiILPNWlsRfl50CLVUWfsALDw6xH4c6qZUtOe3xERjbz5Xrt3b560DLM2/HlF8uHe75xIAI/ +Jy/ogvtVX8CbfdXMls2Le1+gtHED1nrpSKCGd5N3okEVJFmC67BV9zM2gHWsR4/pSZho/ot9W4 VH1w8QSwS5AtY43PTOw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-04_05,2026-03-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 impostorscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603040087 On 2/24/26 10:16 AM, Konrad Dybcio wrote: > On 2/23/26 7:07 PM, Srinivas Kandagatla wrote: >> Buffers are allocated on pcm_new and mapped in the dsp on every prepare call, >> which is inefficient and unnecessary. >> >> Add new functions q6apm_[un]map_memory_fixed_region to map it on >> to dsp only once after allocation. >> >> Signed-off-by: Srinivas Kandagatla >> --- > > [...] > >> -int q6apm_map_memory_regions(struct q6apm_graph *graph, unsigned int dir, phys_addr_t phys, >> - size_t period_sz, unsigned int periods) >> +int q6apm_set_memory_map_handle(struct q6apm_graph *graph, unsigned int dir) >> +{ >> + if (dir == SNDRV_PCM_STREAM_PLAYBACK) >> + graph->rx_data.mem_map_handle = graph->info->mem_map_handle; >> + else >> + graph->tx_data.mem_map_handle = graph->info->mem_map_handle; >> + >> + return 0; >> +} > > This doesn't return a useful value today, will it ever? return type should be void. > > [...] > > >> + case APM_CMD_SHARED_MEM_UNMAP_REGIONS: >> + apm->result.opcode = hdr->opcode; >> + apm->result.status = 0; >> + rsp = data->payload; >> + >> + info = idr_find(&apm->graph_info_idr, hdr->token); >> + if (info) >> + info->mem_map_handle = 0; >> + else >> + dev_err(dev, "Error (%d) Processing 0x%08x cmd\n", result->status, >> + result->opcode); >> + >> + dev_err(dev, "Memory Map region %x\n", rsp->mem_map_handle); > > Looks like a debug leftover (also in the below 'case') Right, will fix that in next spin. --srini > > Konrad