From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fw-cdev __user annotations
Date: Sun, 14 Oct 2007 20:52:51 +0200 [thread overview]
Message-ID: <47126583.3060803@s5r6.in-berlin.de> (raw)
In-Reply-To: <E1Ih8IS-00041I-60@ZenIV.linux.org.uk>
Al Viro wrote:
> --- a/drivers/firewire/fw-cdev.c
> +++ b/drivers/firewire/fw-cdev.c
> @@ -722,10 +722,11 @@ static int ioctl_queue_iso(struct client *client, void *buffer)
> buffer_end = 0;
> }
>
> - if (!access_ok(VERIFY_READ, request->packets, request->size))
> + p = (struct fw_cdev_iso_packet __user *)u64_to_uptr(request->packets);
> +
> + if (!access_ok(VERIFY_READ, p, request->size))
> return -EFAULT;
>
> - p = (struct fw_cdev_iso_packet __user *)u64_to_uptr(request->packets);
> end = (void __user *)p + request->size;
> count = 0;
> while (p < end) {
Acked-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
I will enqueue it in case Linus doesn't pick it up before my next pull
request.
--
Stefan Richter
-=====-=-=== =-=- -===-
http://arcgraph.de/sr/
prev parent reply other threads:[~2007-10-14 18:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-14 18:34 Al Viro
2007-10-14 18:52 ` Stefan Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47126583.3060803@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®