From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23129C6FA82 for ; Tue, 27 Sep 2022 14:31:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232583AbiI0Oa6 (ORCPT ); Tue, 27 Sep 2022 10:30:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232440AbiI0OaT (ORCPT ); Tue, 27 Sep 2022 10:30:19 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97A7B31EDA for ; Tue, 27 Sep 2022 07:30:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664289008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3uRuuRVYQPLT+MslzRnqQghQMFwXG1xwpNvF+0tAnoc=; b=Kq0lvtAzHCAHxe9DlJgfaZdXeNzouJh9DKCojCksbRIrmLKMRuZ56WWlRh3Ms5QtsNYFco cky9QbfRTdYN6yJMbToJcyUo1BzKZNotdyGrw6PwTlNXZ/Nh+QI6HCLD8aw1NF7oQ8OcUY gN9OY6rZK2eGVwk02IL5v0L9NGUosIU= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-607-noEFTLh-OXG-3-Sw_gbbdA-1; Tue, 27 Sep 2022 10:29:59 -0400 X-MC-Unique: noEFTLh-OXG-3-Sw_gbbdA-1 Received: by mail-ed1-f72.google.com with SMTP id i17-20020a05640242d100b0044f18a5379aso8071611edc.21 for ; Tue, 27 Sep 2022 07:29:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=3uRuuRVYQPLT+MslzRnqQghQMFwXG1xwpNvF+0tAnoc=; b=Hf4lZ3XGXRQsDCpF7abCXIS/hC1CWYdaYcuoeMvFzZxFCZLc95VQ0qMthdaRkAcI2B GuQjjPbjBSzIPjz2T3SmFZWNAaptCn7ZbLiTpMrmoDcTvn76KPjMaz3yxk/I2P1AW/yo wCRS15PtZYasyNiLZ6GKnj45i6sahSeV+KzM3itoSf92DwPpKdEWP1F3nZDZW+4Pc/7P c9RIbSwkn75qhFmJ865aAcWgHI+3Dva3HpGoHl9Nna7WDlcxbKR4AAqJvp5OvjP/V/4F W8xnY9SubJds4A4rYn8RFTcMNTJN7LcTpDT/mr65yD4ct0Zxew9tC762GWWYEz21oKd1 XZBA== X-Gm-Message-State: ACrzQf1d0dxbqYfH6Q7IdG9WxVduzfrEDpWcU0Ix3aauZejWGHXQGtVs gCXRQszN/7VLHQr6rqq7DP/kHG+VcjdsyGop5G/xbwkuvH6mkw2cqypLnbxKHBN2IJx2SDEhHZH ZP17Rp2U9RyX0uWkM2bldjaou X-Received: by 2002:a17:907:1dcc:b0:77a:c5f3:708b with SMTP id og12-20020a1709071dcc00b0077ac5f3708bmr23278267ejc.331.1664288998233; Tue, 27 Sep 2022 07:29:58 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7oaN+oJNzgoKfTucQ5HgkrI0cpFFC7w+y2x3V1IlKbboxXQKgc1ZkJCZioVwRKc/L5CwFSIw== X-Received: by 2002:a17:907:1dcc:b0:77a:c5f3:708b with SMTP id og12-20020a1709071dcc00b0077ac5f3708bmr23278245ejc.331.1664288998021; Tue, 27 Sep 2022 07:29:58 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id r17-20020a17090609d100b00781d411a63csm854954eje.151.2022.09.27.07.29.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Sep 2022 07:29:57 -0700 (PDT) Message-ID: <471449b3-cced-d75d-e349-6bec950b0bc1@redhat.com> Date: Tue, 27 Sep 2022 16:29:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH 1/5] ACPI: battery: Do not unload battery hooks on single error Content-Language: en-US To: Armin Wolf , "Rafael J. Wysocki" Cc: Mark Gross , Len Brown , Henrique de Moraes Holschuh , Matan Ziv-Av , Corentin Chary , Jeremy Soller , productdev@system76.com, Platform Driver , ACPI Devel Maling List , Linux Kernel Mailing List References: <20220912125342.7395-1-W_Armin@gmx.de> <20220912125342.7395-2-W_Armin@gmx.de> From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 9/19/22 22:35, Armin Wolf wrote: > Am 19.09.22 um 21:12 schrieb Armin Wolf: > >> Am 19.09.22 um 18:27 schrieb Rafael J. Wysocki: >> >>> On Mon, Sep 19, 2022 at 12:42 PM Hans de Goede wrote: >>>> Hi, >>>> >>>> On 9/12/22 13:53, Armin Wolf wrote: >>>>> Currently, battery hooks are being unloaded if they return >>>>> an error when adding a single battery. >>>>> This however also causes the removal of successfully added >>>>> hooks if they return -ENODEV for a single unsupported >>>>> battery. >>>>> >>>>> Do not unload battery hooks in such cases since the hook >>>>> handles any cleanup actions. >>>>> >>>>> Signed-off-by: Armin Wolf >>>> Maybe instead of removing all error checking, allow -ENODEV >>>> and behave as before when the error is not -ENODEV ? >>>> >>>> Otherwise we should probably make the add / remove callbacks >>>> void to indicate that any errors are ignored. >>>> >>>> Rafael, do you have any opinion on this? >>> IMV this is not a completely safe change, because things may simply >>> not work in the cases in which an error is returned. >>> >>> It would be somewhat better to use a special error code to indicate >>> "no support" (eg. -ENOTSUPP) and ignore that one only. >> >> I would favor -ENODEV then, since it is already used by quiet a few drivers >> to indicate a unsupported battery. >> >> Armin Wolf >> > While checking all instances where the battery hook mechanism is currently used, > i found out that all but a single battery hook return -ENODEV for all errors they > encounter, the exception being the huawei-wmi driver. Right, so this means that using -ENODEV to not automatically unload the extension on error will result in a behavior change for those drivers, with possibly unwanted side-effects. As such I believe that using -ENOTSUP for the case where the extension does not work for 1 battery but should still be used for the other batter{y|ies} would be better as this preserves the existing behavior for existing drivers. > I do not know the reason for this, but i fear unloading the extension on for > example -ENOTSUP will result in similar behavior by hooks wanting to avoid being > unloaded on harmless errors. I am not sure what you are trying to say here. The whole idea is to add new behavior for -ENOTSUP to allow drivers to opt out of getting their extension unregistered when they return this. Although I wonder why not just have extensions return 0 when they don't want to register any sysfs attr and that not considered an error. If it is not considered an error the hook can just return 0, which would not require any ACPI battery code changes at all. So maybe just returning 0 is the easiest (which is also often the best) answer here? > However, i agree that when ignoring all errors, battery extensions which provide > similar attributes may currently delete each others attributes. AFAIK there are no cases where more then 1 extension driver gets loaded, since all the extension drivers are tied to a specific vendor's interfaces so we won't e.g. see the thinkpad_acpi driver load on the same laptop as where toshiba_acpi also loads. IOW I think you are trying to solve a problem which does not exist here. Regards, Hans > > Any idea on how to solve this? > > Armin Wolf > >>>>> --- >>>>>   drivers/acpi/battery.c | 24 +++--------------------- >>>>>   1 file changed, 3 insertions(+), 21 deletions(-) >>>>> >>>>> diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c >>>>> index 306513fec1e1..e59c261c7c59 100644 >>>>> --- a/drivers/acpi/battery.c >>>>> +++ b/drivers/acpi/battery.c >>>>> @@ -724,20 +724,10 @@ void battery_hook_register(struct acpi_battery_hook *hook) >>>>>         * its attributes. >>>>>         */ >>>>>        list_for_each_entry(battery, &acpi_battery_list, list) { >>>>> -             if (hook->add_battery(battery->bat)) { >>>>> -                     /* >>>>> -                      * If a add-battery returns non-zero, >>>>> -                      * the registration of the extension has failed, >>>>> -                      * and we will not add it to the list of loaded >>>>> -                      * hooks. >>>>> -                      */ >>>>> -                     pr_err("extension failed to load: %s", hook->name); >>>>> -                     __battery_hook_unregister(hook, 0); >>>>> -                     goto end; >>>>> -             } >>>>> +             hook->add_battery(battery->bat); >>>>>        } >>>>>        pr_info("new extension: %s\n", hook->name); >>>>> -end: >>>>> + >>>>>        mutex_unlock(&hook_mutex); >>>>>   } >>>>>   EXPORT_SYMBOL_GPL(battery_hook_register); >>>>> @@ -762,15 +752,7 @@ static void battery_hook_add_battery(struct acpi_battery *battery) >>>>>         * during the battery module initialization. >>>>>         */ >>>>>        list_for_each_entry_safe(hook_node, tmp, &battery_hook_list, list) { >>>>> -             if (hook_node->add_battery(battery->bat)) { >>>>> -                     /* >>>>> -                      * The notification of the extensions has failed, to >>>>> -                      * prevent further errors we will unload the extension. >>>>> -                      */ >>>>> -                     pr_err("error in extension, unloading: %s", >>>>> -                                     hook_node->name); >>>>> -                     __battery_hook_unregister(hook_node, 0); >>>>> -             } >>>>> +             hook_node->add_battery(battery->bat); >>>>>        } >>>>>        mutex_unlock(&hook_mutex); >>>>>   } >>>>> --  >>>>> 2.30.2 >>>>>