From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932714AbcBPQfL (ORCPT <rfc822;w@1wt.eu>);
	Tue, 16 Feb 2016 11:35:11 -0500
Received: from mout.kundenserver.de ([217.72.192.73]:59163 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755404AbcBPQfJ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 16 Feb 2016 11:35:09 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Russell King <linux@arm.linux.org.uk>,
        Kees Cook <keescook@chromium.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Chris Brandt <chris.brandt@renesas.com>,
        Laura Abbott <labbott@fedoraproject.org>
Subject: Re: [PATCH 2/2] ARM: mm: hide __start_rodata_section_aligned for non-debug builds
Date: Tue, 16 Feb 2016 17:34:30 +0100
Message-ID: <4716656.D1MJCNd1N6@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <CAKv+Gu8JcWg4BkxZFPqTotkfHFtP744XYdSx6XROJSM_8pmt2w@mail.gmail.com>
References: <1455638631-3326518-1-git-send-email-arnd@arndb.de> <1455638631-3326518-2-git-send-email-arnd@arndb.de> <CAKv+Gu8JcWg4BkxZFPqTotkfHFtP744XYdSx6XROJSM_8pmt2w@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:YeH98a7n+B+QsxeibVVFXHld1uJYDq/sQ19AeZnCcbw2lF3eMLk
 iCtVyDSu19Lte2sVasD2pbN9ObdwXZqayvVFSYlQ2zeb3JppwTIVYo5oIkpOqxP7FuFK5Dt
 6/JGxYAovCxwNYxDg8Nr+CmeL6BVViPI7hFI+aUIPt1dLF929eE7F2wrdYO6pWF0st/lN9H
 Amj9LQbYNdaKNeu5SkFsw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:LXlCZnzK2Yk=:8UXq1VEQBFwqoak3LIRG3w
 4mkZWFCUvQQdtBa3OxOEnbry1C8QzUeIkjJ0l4l75NRlSHQCp4McSiblHZaFu4h+XiFpH/z0d
 sWZo8vThsxxYgSnWQNPDOYtjTDtHlC7u65EQY5q+WdM8u1CRKgkJaBZZOHv3qe6Pl6xQNL/iB
 CugqmwpCZmPX+M7/7LW1AC7oVru0qLeZXSN6hhT7q2plbDy+4FF4LPvbCn4ZvJGtGpyvr4k95
 oUVpTdJeDUhqM0ecgolNX7QIv1zHnwWAvBbM1h+2lWiiUCcb1stwNwxAZ9/o3EVRR0iyUAHLP
 DvC2LvlrmfHyvlYvmzuZ7gqxpK5M3HQfDjukybLdVnWLcJHFDhsZ39VB9fjYAb2HTuHqIBAWf
 9cXgZkHVeIO24OZ9f6eepbgPoCGht96L/M/BfGwv1nqWUEjrXV9Qp2PVe7SpJ7rKCfrts+CjH
 Jbr5pPmUxGJowFXPGTszgRuYZW3MJm71ntw+ih4tdKR+oFvgf0RVxkqsOxnzfGhd0iLqgRvnj
 TjP46rbnyhMZe40cunPfVNjY7jC+5SWYaK/v6Kgg6XlPZjZXPNVPusQw6gPZoOix0purHzCYC
 Q17Fav3IW3vCeiGO4wJGDeC7w0ENIJAWtirIEFlwQxsl8aesxOlRcAfh68oWvaUMFADyshanQ
 ifO1U4AR82e67vdszdfymKj0EqxPp5FiM2IY2gdoSKHSuB4fBeX/Iq79No6SqGMl6mxwRPQ4z
 Ov+6QOoNbP9iTk05
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 16 February 2016 17:12:52 Ard Biesheuvel wrote:
> > +#ifdef CONFIG_DEBUG_RODATA
> >  /*
> >   * Without CONFIG_DEBUG_ALIGN_RODATA, __start_rodata_section_aligned will
> >   * be the first section-aligned location after __start_rodata. Otherwise,
> >   * it will be equal to __start_rodata.
> >   */
> >  __start_rodata_section_aligned = ALIGN(__start_rodata, 1 << SECTION_SHIFT);
> > +#endif
> >
> 
> Does
> 
> PROVIDE(__start_rodata_section_aligned = xxx);
> 
> do the trick as well? If it does, it's a bit cleaner.
> 

I would assume not, as the problem is that SECTION_SHIFT is a macro that
is not defined when the MMU is disabled.

	Arnd