From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 628D8386548 for ; Mon, 23 Mar 2026 10:17:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774261062; cv=none; b=qaES/NVYSY6pmYs81Fo/igy312SxeXdN4ILFt0+1GT4WnoSwa68SX3PIS6Z+AkegtCxd2LsEGVaain3nkbr0loeAfj6iW3pZodanBSEOvsp2o5jQWJKWU8sr5kvrDkX1X30qIEE93Yuk00V3IWdrjntPoOTc6Q9gogMyv3qQBv0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774261062; c=relaxed/simple; bh=bHPN2CMidJ9Tf8GVrxXqrL+zB9dliXEdZEsMytVl0Ac=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UY0pf/B/NY8WeC929VbhF3LjcTsq3Ae3QKebQeJhv6pC6OfUSKYNZOX7fLhewptCyLh17knx6JsGBuEiULR/8J/v2woNwZ2N2hGoEluC21LQqpNNu2CFfHmItoVGmFaUQwLRmQ4xFs6wTXhtjEmwo7TtTbcoBhlbNW7pC3+7MLM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ehppcrzV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NPy9wxLK; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ehppcrzV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NPy9wxLK" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62N7taKv1627158 for ; Mon, 23 Mar 2026 10:17:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= psp5AD64siCth9lvoT6mZpf4pH76K6Tx3toQAUSZxYo=; b=ehppcrzVVcvjUH5/ 4iXXOs5azDXAEKiIt9aAXx1Rcp5A72TJpXV73SLjFbzpYFf5WNKvWawgcxHrbGUX WNNzpEsWBllOxeYZ5uK7tXoyfI80MmsfObyhkmbHRlP5pY6ZaNkNdcVM1TOelKIQ UFh8zHIccfXekl8M2qktuH75vHjLJBiXOKHzcr5fdI3HACUnOn5VP3006IIwMvFS VcXZDAwCb10r8veONdhOwBxAp0dmAU3VF90KSn6MapYm1zuMzvheF/FICIlyT59M OHH4jDet2HsClc1ZGAUCX+Azk/aSyYg2c1lX4hw8eL8Rt34DKZoo1yn++lB3/oJZ J3cz1w== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d31jc0grn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 10:17:39 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50947db2e97so36711531cf.3 for ; Mon, 23 Mar 2026 03:17:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774261058; x=1774865858; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=psp5AD64siCth9lvoT6mZpf4pH76K6Tx3toQAUSZxYo=; b=NPy9wxLKWJ2lG+xigsCg2j96ioXSn7XP92J2lQkGnaFNED0oCVqyuQFFytUtdtP8ru mJuCe9KqAAaBtBgOTt8NvF4Up6Ej7p7YMgB+Td9mWp5bDUqdymHSbINaSUro3QxBfXWl gSwRRCydXO48lKdlGDO6xkVKEmFwuHi80nSx3vv6ksmiFAi+dbrKpkXhgyA1R+YVDmGR ZoD16dRjsWsF6EnvfOHgX5qADsxs/OpJWUsn6zICmYV42mz5lrx8uS2KxCPi1lqfFD8/ K9NFkFm+dXMDMAF4hcY4ZlGfFMAqXX+eGEUMzq7b2Pm4W30e2xW5qRt0ekh8wrLcea13 aeig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774261058; x=1774865858; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=psp5AD64siCth9lvoT6mZpf4pH76K6Tx3toQAUSZxYo=; b=qmBeiK0PSOYX9CgKWGNogH3HFnVmA+BPItbLVqxjZwVzHIiHHUxBoG+a+Rk31Zzouq uPvxzxT2zQnr48nQfCxBMBpVlUl+9WVwjHOFdUg2KYGqDrt+yHJVxS9BTwUsfn31yC2c 8JDGbvAmmHluvTV6JddP4QlHGu5U+e0EpfnWTyiDpraPAyVHntn/f6aM7Dl2xURKzauh RovLTxR3QrfWx2wi7a2w7V94mrRVPjcp74rru/H3D7j8Hk9s7DYhkLywV8sLw5y8gc34 qL1jgjlmau9AlJdMcwjO15wS8ZDG3qqs2WyiZGOUEBERmlwOqMTe4Bw0vft9ybrysj8u 63Fw== X-Forwarded-Encrypted: i=1; AJvYcCWagXBHRGxjDHxys7JnflxDob5NaNIxyqOIJdWiIzNghaBRQTxYdvQyalzuqHByxrwGVlT8wLMwnyj47ZQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0UGWtCcrojFtYvVg6FqfoKEYoZREunI+BDAlieJxagR09HeWl 9PSaKxjNd5tUo+s9LuPujo0uDCdSDBW5H+Nmpvh91zO7ms91shIUyShzuWaLUfkZRae5JXqdGMy qZ9ZpGsbllQxx1yPMPlrVBeVNlaWsxtn0cznEXP2axoJtzkqDvzDZw5vJz5vDnWtVQis= X-Gm-Gg: ATEYQzyo7sApRMyR8765p+Q5lZl3GIfgHfMvCdNFm7l5DsPm9Vu1wcEFPca45dbx//P GgNJHD6bx3i/UYxpE9pWA6mXy/OL3gVi6qi2wfJyTepPbzYWSAJiKfLF4Z4yFXBsvjGfkslpyQI gihZznYoNar0/wgE6fhlezOddHZ0FNV7cQXgCG46vDJoh84GDANIusBv4NqPU7GZjRnsEhFNZPc gkuM6N5vySdBQyGJUzNIqEmDCbYXbZTiMmciXKz/dxPLu5cIC4n7SQDQXqnDHW/v3Psh3FZlHyq jD5URczQ9yDyaxJmYcuG2TVtcOiVf6y2OyS2vIX75P7bqyrcVVYQTSeP2j0q2AAXFaHnR4yESzh CwXn2URlyWWYTEj09iJwj7dqcqYyLp2A4zqEZ4m0nwD29V6ux7NqzyQvs/lvsJw02z+s6LTJlvb L0qA8= X-Received: by 2002:a05:622a:6788:b0:50b:5075:5256 with SMTP id d75a77b69052e-50b50758e93mr44088551cf.9.1774261058647; Mon, 23 Mar 2026 03:17:38 -0700 (PDT) X-Received: by 2002:a05:622a:6788:b0:50b:5075:5256 with SMTP id d75a77b69052e-50b50758e93mr44088321cf.9.1774261058280; Mon, 23 Mar 2026 03:17:38 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9832f8dc51sm473401066b.22.2026.03.23.03.17.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Mar 2026 03:17:36 -0700 (PDT) Message-ID: <471a736a-f715-4c29-8e76-fe26aa4e77ea@oss.qualcomm.com> Date: Mon, 23 Mar 2026 11:17:34 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] soc: qcom: ocmem: return -EPROBE_DEFER is ocmem is not available To: Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Stephen Boyd , Georgi Djakov , Rob Clark , Brian Masney Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260323-ocmem-v1-0-ad9bcae44763@oss.qualcomm.com> <20260323-ocmem-v1-3-ad9bcae44763@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260323-ocmem-v1-3-ad9bcae44763@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=fKc0HJae c=1 sm=1 tr=0 ts=69c11343 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=1Mc-sfmLbtUOKB2LNIsA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: 0grNbVoWjGFx31_st-4BxnuWpWvLKVnS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDA3OSBTYWx0ZWRfX7zXo6vrOtnlb AAkQvMUPf3Jcv6kzHS2PM1hag591VT3kB16SP03ByVZdGazBU6ST+RwLsfSvt6gIwewGiY0hw9u s+XhiRvarXXe9evnsuZS2sxsEucoU6wKZqbCyU+vSvD8zUYNY73j7yePKrhtChvaSZZZiFqa1l3 F15MzxYVGLNYcYSO2YswPFgtMJbSXYdvufKE9fOUffLUym0CMMwW3Y+bGwWQ5VDuBhjhkt2PSx8 JLHGttisYHm/BXFbpONaV5TxhX6t0tT3/xWYv/2FjHziep2r6ad9f8Qdk/IK9eDUUxRT/OCUwuH z0HwXzbab/awcLJB6hyMe0njQyGdRAX4HcYjI1Luihg+OnTySWeLo6gOf6v+IRXL9e7jR27Wfme rRULrXWMi3at6tH9P082v5AkwpTszUsd8wiQXk4CZf5vTb1KzDfztrtOeWjinMck2IzXJPO+LHU PnpzcLj/GX6Eb+C6bVw== X-Proofpoint-ORIG-GUID: 0grNbVoWjGFx31_st-4BxnuWpWvLKVnS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_03,2026-03-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 spamscore=0 suspectscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230079 On 3/23/26 2:20 AM, Dmitry Baryshkov wrote: > If OCMEM is declared in DT, it is expected that it is present and > handled by the driver. The GPU driver will ignore -ENODEV error, which > typically means that OCMEM isn't defined in DT. Let ocmem return > -EPROBE_DEFER if it supposed to be used, but it is not probed (yet). > > Fixes: 88c1e9404f1d ("soc: qcom: add OCMEM driver") > Signed-off-by: Dmitry Baryshkov > --- > drivers/soc/qcom/ocmem.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/soc/qcom/ocmem.c b/drivers/soc/qcom/ocmem.c > index d57baa9cfa03..c35a98984acc 100644 > --- a/drivers/soc/qcom/ocmem.c > +++ b/drivers/soc/qcom/ocmem.c > @@ -203,10 +203,9 @@ struct ocmem *of_get_ocmem(struct device *dev) > > ocmem = platform_get_drvdata(pdev); > put_device(&pdev->dev); > - if (!ocmem) { > - dev_err(dev, "Cannot get ocmem\n"); > - return ERR_PTR(-ENODEV); > - } > + if (!ocmem) > + return ERR_PTR(dev_err_probe(dev, -EPROBE_DEFER, "Cannot get ocmem\n")); dev_err_ptr_probe() Reviewed-by: Konrad Dybcio Konrad